René's URL Explorer Experiment


Title: gh-89653: PEP 670: Convert macros to functions by vstinner · Pull Request #99843 · python/cpython · GitHub

Open Graph Title: gh-89653: PEP 670: Convert macros to functions by vstinner · Pull Request #99843 · python/cpython

X Title: gh-89653: PEP 670: Convert macros to functions by vstinner · Pull Request #99843 · python/cpython

Description: Convert macros to static inline functions to avoid macro pitfalls, like duplication of side effects: DK_ENTRIES() DK_UNICODE_ENTRIES() PyCode_GetNumFree() PyFloat_AS_DOUBLE() PyInstanceMethod_GET_FUNCTION() PyMemoryView_GET_BASE() PyMemoryView_GET_BUFFER() PyMethod_GET_FUNCTION() PyMethod_GET_SELF() PySet_GET_SIZE() _PyHeapType_GET_MEMBERS() Changes: Add also assertions in some functions using "CAST" macro to check the type of the arguments when Python is built with assertions (debug build). Remove an outdated comment in unicodeobject.h. PyCode_GetNumFree() doesn't cast its argument: the replaced macro already required the exact type PyCodeObject*. PyCode_GetNumFree() casts PyCode_GetNumFree.co_nfreevars from int to Py_ssize_t to be future proof, and because Py_ssize_t is commonly used in the C API. Issue: gh-89653

Open Graph Description: Convert macros to static inline functions to avoid macro pitfalls, like duplication of side effects: DK_ENTRIES() DK_UNICODE_ENTRIES() PyCode_GetNumFree() PyFloat_AS_DOUBLE() PyInstanceMethod_GET_...

X Description: Convert macros to static inline functions to avoid macro pitfalls, like duplication of side effects: DK_ENTRIES() DK_UNICODE_ENTRIES() PyCode_GetNumFree() PyFloat_AS_DOUBLE() PyInstanceMethod_GET_...

Opengraph URL: https://github.com/python/cpython/pull/99843

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8c942a1a-07cf-4a97-8343-1cd567c02c9d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2DA:21E6C4:D206C3:124FEAA:696A3942
html-safe-nonce228e4dfce1e94434f1143a7cad53efa3626e72de7e1e7c0fb4320af79c1f9013
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkRBOjIxRTZDNDpEMjA2QzM6MTI0RkVBQTo2OTZBMzk0MiIsInZpc2l0b3JfaWQiOiI3MDI3NzIwMjcyMjY5MTYyODE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd3af90314a5f160b37a7911ac880df63e1f619b91d7ad6566820fa4b15632ae5
hovercard-subject-tagpull_request:1137653951
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99843/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altConvert macros to static inline functions to avoid macro pitfalls, like duplication of side effects: DK_ENTRIES() DK_UNICODE_ENTRIES() PyCode_GetNumFree() PyFloat_AS_DOUBLE() PyInstanceMethod_GET_...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99843/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99843%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99843%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99843/files
Reloadhttps://github.com/python/cpython/pull/99843/files
Reloadhttps://github.com/python/cpython/pull/99843/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/99843/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/99843/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
Conversation 4 https://github.com/python/cpython/pull/99843
Commits 2 https://github.com/python/cpython/pull/99843/commits
Checks 0 https://github.com/python/cpython/pull/99843/checks
Files changed https://github.com/python/cpython/pull/99843/files
Please reload this pagehttps://github.com/python/cpython/pull/99843/files
gh-89653: PEP 670: Convert macros to functions https://github.com/python/cpython/pull/99843/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/99843/files
5442376 gh-89653: PEP 670: Convert macros to functions vstinner Nov 23, 2022 https://github.com/python/cpython/pull/99843/commits/544237666d6643f6e7c538ecd56fc8b6e409fa12
f1594c1 Reformat _PyHeapType_GET_MEMBERS() vstinner Nov 28, 2022 https://github.com/python/cpython/pull/99843/commits/f1594c1db33767283fabe34d91b5f671fcb33b27
Clear filters https://github.com/python/cpython/pull/99843/files
Please reload this pagehttps://github.com/python/cpython/pull/99843/files
Please reload this pagehttps://github.com/python/cpython/pull/99843/files
classobject.h https://github.com/python/cpython/pull/99843/files#diff-fa8c4436a9b93875b4e3718fc0489730d7c927d354a89ba180fd308f17b4b4e1
code.h https://github.com/python/cpython/pull/99843/files#diff-b0fcb97ad50c6f97009037466945581575bc3b18633dc8b32a38f633950144c2
floatobject.h https://github.com/python/cpython/pull/99843/files#diff-a38ecb0cb7ceda1f518d31e1bc6032c042ae27b2bc62e96fd106d84f17a64309
memoryobject.h https://github.com/python/cpython/pull/99843/files#diff-66e840eea49a61a0b940b3b3b7b008e0e4355c51e62bb02a4f922c9cfe3c41c9
setobject.h https://github.com/python/cpython/pull/99843/files#diff-70a493a0cd7b8b18ad0ab653bbe236a6eac25bf62c926cad51c26edf17414ed1
unicodeobject.h https://github.com/python/cpython/pull/99843/files#diff-6be7f081fe6c5e9cbc89323a00399b291d1cda855bcb4c6eeaee0fac89c2f8dd
pycore_dict.h https://github.com/python/cpython/pull/99843/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
pycore_object.h https://github.com/python/cpython/pull/99843/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
Include/cpython/classobject.hhttps://github.com/python/cpython/pull/99843/files#diff-fa8c4436a9b93875b4e3718fc0489730d7c927d354a89ba180fd308f17b4b4e1
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/cpython/classobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-fa8c4436a9b93875b4e3718fc0489730d7c927d354a89ba180fd308f17b4b4e1
https://github.com/python/cpython/pull/99843/files#diff-fa8c4436a9b93875b4e3718fc0489730d7c927d354a89ba180fd308f17b4b4e1
https://github.com/python/cpython/pull/99843/files#diff-fa8c4436a9b93875b4e3718fc0489730d7c927d354a89ba180fd308f17b4b4e1
Include/cpython/code.hhttps://github.com/python/cpython/pull/99843/files#diff-b0fcb97ad50c6f97009037466945581575bc3b18633dc8b32a38f633950144c2
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/cpython/code.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-b0fcb97ad50c6f97009037466945581575bc3b18633dc8b32a38f633950144c2
https://github.com/python/cpython/pull/99843/files#diff-b0fcb97ad50c6f97009037466945581575bc3b18633dc8b32a38f633950144c2
Include/cpython/floatobject.hhttps://github.com/python/cpython/pull/99843/files#diff-a38ecb0cb7ceda1f518d31e1bc6032c042ae27b2bc62e96fd106d84f17a64309
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/cpython/floatobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-a38ecb0cb7ceda1f518d31e1bc6032c042ae27b2bc62e96fd106d84f17a64309
https://github.com/python/cpython/pull/99843/files#diff-a38ecb0cb7ceda1f518d31e1bc6032c042ae27b2bc62e96fd106d84f17a64309
Include/cpython/memoryobject.hhttps://github.com/python/cpython/pull/99843/files#diff-66e840eea49a61a0b940b3b3b7b008e0e4355c51e62bb02a4f922c9cfe3c41c9
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/cpython/memoryobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-66e840eea49a61a0b940b3b3b7b008e0e4355c51e62bb02a4f922c9cfe3c41c9
Include/cpython/setobject.hhttps://github.com/python/cpython/pull/99843/files#diff-70a493a0cd7b8b18ad0ab653bbe236a6eac25bf62c926cad51c26edf17414ed1
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/cpython/setobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-70a493a0cd7b8b18ad0ab653bbe236a6eac25bf62c926cad51c26edf17414ed1
https://github.com/python/cpython/pull/99843/files#diff-70a493a0cd7b8b18ad0ab653bbe236a6eac25bf62c926cad51c26edf17414ed1
Include/cpython/unicodeobject.hhttps://github.com/python/cpython/pull/99843/files#diff-6be7f081fe6c5e9cbc89323a00399b291d1cda855bcb4c6eeaee0fac89c2f8dd
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/cpython/unicodeobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-6be7f081fe6c5e9cbc89323a00399b291d1cda855bcb4c6eeaee0fac89c2f8dd
https://github.com/python/cpython/pull/99843/files#diff-6be7f081fe6c5e9cbc89323a00399b291d1cda855bcb4c6eeaee0fac89c2f8dd
Include/internal/pycore_dict.hhttps://github.com/python/cpython/pull/99843/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/internal/pycore_dict.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
https://github.com/python/cpython/pull/99843/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4
Include/internal/pycore_object.hhttps://github.com/python/cpython/pull/99843/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
View file https://github.com/python/cpython/blob/f1594c1db33767283fabe34d91b5f671fcb33b27/Include/internal/pycore_object.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99843/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99843/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
https://github.com/python/cpython/pull/99843/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.