René's URL Explorer Experiment


Title: gh-89727: Fix os.walk RecursionError on deep trees by jonburdo · Pull Request #99803 · python/cpython · GitHub

Open Graph Title: gh-89727: Fix os.walk RecursionError on deep trees by jonburdo · Pull Request #99803 · python/cpython

X Title: gh-89727: Fix os.walk RecursionError on deep trees by jonburdo · Pull Request #99803 · python/cpython

Description: Use a stack to implement os.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees. Issue: gh-89727

Open Graph Description: Use a stack to implement os.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees. Issue: gh-89727

X Description: Use a stack to implement os.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees. Issue: gh-89727

Opengraph URL: https://github.com/python/cpython/pull/99803

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4bcf803e-aa82-f73b-0440-8268ed3b19bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF38:6BE0D:F6B86D:148F2A2:696992E5
html-safe-nonce3544c45ec29aeffd98fbcf7822ecadb8ec0eab14a872cb49665137dc9d96bf96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjM4OjZCRTBEOkY2Qjg2RDoxNDhGMkEyOjY5Njk5MkU1IiwidmlzaXRvcl9pZCI6IjU5Nzk0NDI3NjM5MDYyNTc2MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac995eac4626a9ef12eb3a810fb84566158ab1561e92b3648945a8f58ca15d728c
hovercard-subject-tagpull_request:1136570177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99803/files
twitter:imagehttps://avatars.githubusercontent.com/u/79213343?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/79213343?s=400&v=4
og:image:altUse a stack to implement os.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees. Issue: gh-89727
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99803/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99803%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99803%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99803/files
Reloadhttps://github.com/python/cpython/pull/99803/files
Reloadhttps://github.com/python/cpython/pull/99803/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/99803/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/99803/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
jonburdo:iterative-os-walkhttps://github.com/jonburdo/cpython/tree/iterative-os-walk
Conversation 37 https://github.com/python/cpython/pull/99803
Commits 16 https://github.com/python/cpython/pull/99803/commits
Checks 0 https://github.com/python/cpython/pull/99803/checks
Files changed https://github.com/python/cpython/pull/99803/files
Please reload this pagehttps://github.com/python/cpython/pull/99803/files
gh-89727: Fix os.walk RecursionError on deep trees https://github.com/python/cpython/pull/99803/files#top
Show all changes 16 commits https://github.com/python/cpython/pull/99803/files
99f4691 gh-89727: Fix os.walk RecursionError on deep trees jonburdo Nov 26, 2022 https://github.com/python/cpython/pull/99803/commits/99f4691399229be2daacfacdba09ab4d4805f5c4
3552d49 add unit test to ensure os.walk is not affect by recursion limit jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/3552d4989724e9086774e76b21c6871fc83f820f
3078ea6 move os._walk code to os.walk jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/3078ea601feae31baecb36fc2eecfe5e0c19040f
f37bbe8 fix blurb to mention os.walk jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/f37bbe8aaa3ffd91b879a17bc5d0daee2cbd20e2
f26a5b8 use deque in os.walk jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/f26a5b88b8636d2ffd27f5410d94a795b8ec0d4d
955d21b Merge branch 'main' into iterative-os-walk jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/955d21b55fe5b548405b80576159e7a8b3b7b8fb
8fbfb2e Merge branch 'main' into iterative-os-walk jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/8fbfb2e7261faf5ad414a43470cfe4cd15513345
ef46eda move deque import inside os.walk jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/ef46eda965d1c8dc1a63dbf464a79ab19fc8d80d
e261b9f rename temp_recursion_limit to set_recursion_limit jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/e261b9fd1b2628f578ceff19b86df9bc02206601
5ec53f7 Merge branch 'main' into iterative-os-walk jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/5ec53f7cdd277c9ca8a267a2efcb3783d66e8659
507b650 switch back to list instead of deque for os.walk stack jonburdo Dec 16, 2022 https://github.com/python/cpython/pull/99803/commits/507b650a7d8dc01b6115f434591238699ef8ad38
1c35610 Apply suggestions from code review jonburdo Dec 18, 2022 https://github.com/python/cpython/pull/99803/commits/1c356102d80ac154b9379c86603d975d2dfe20e0
73138a6 clean up os.walk comments jonburdo Dec 18, 2022 https://github.com/python/cpython/pull/99803/commits/73138a6363e5b8276e10d4639e66788bcd7323f4
2814cc5 test correct value in test_walk_above_recursion_limit jonburdo Dec 18, 2022 https://github.com/python/cpython/pull/99803/commits/2814cc5f728a054fe463dd8aa65ccfd0b14c6f74
37f3cc7 set islink and join before loop in os.walk jonburdo Dec 18, 2022 https://github.com/python/cpython/pull/99803/commits/37f3cc77d8cc9380561280bf49f4979c68437657
d9c766c Merge branch 'main' into iterative-os-walk jonburdo Dec 19, 2022 https://github.com/python/cpython/pull/99803/commits/d9c766c05c0b3e49f6f4d1051fd80fb3c651d304
Clear filters https://github.com/python/cpython/pull/99803/files
Please reload this pagehttps://github.com/python/cpython/pull/99803/files
Please reload this pagehttps://github.com/python/cpython/pull/99803/files
os.py https://github.com/python/cpython/pull/99803/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
__init__.py https://github.com/python/cpython/pull/99803/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
test_os.py https://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
2022-11-29-20-44-54.gh-issue-89727.UJZjkk.rst https://github.com/python/cpython/pull/99803/files#diff-f11dc19ca8f9d31279d0807c91ddf75a94156ed8c0390d27c870b31b5241bd26
Lib/os.pyhttps://github.com/python/cpython/pull/99803/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
View file https://github.com/jonburdo/cpython/blob/d9c766c05c0b3e49f6f4d1051fd80fb3c651d304/Lib/os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99803/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99803/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
Please reload this pagehttps://github.com/python/cpython/pull/99803/files
https://github.com/python/cpython/pull/99803/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
Lib/test/support/__init__.pyhttps://github.com/python/cpython/pull/99803/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
View file https://github.com/jonburdo/cpython/blob/d9c766c05c0b3e49f6f4d1051fd80fb3c651d304/Lib/test/support/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99803/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99803/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/pull/99803/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
Lib/test/test_os.pyhttps://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
View file https://github.com/jonburdo/cpython/blob/d9c766c05c0b3e49f6f4d1051fd80fb3c651d304/Lib/test/test_os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99803/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99803/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
Misc/NEWS.d/next/Library/2022-11-29-20-44-54.gh-issue-89727.UJZjkk.rsthttps://github.com/python/cpython/pull/99803/files#diff-f11dc19ca8f9d31279d0807c91ddf75a94156ed8c0390d27c870b31b5241bd26
View file https://github.com/jonburdo/cpython/blob/d9c766c05c0b3e49f6f4d1051fd80fb3c651d304/Misc/NEWS.d/next/Library/2022-11-29-20-44-54.gh-issue-89727.UJZjkk.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99803/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.