René's URL Explorer Experiment


Title: gh-99508: fix `TypeError` in `Lib/importlib/_bootstrap_external.py` by sobolevn · Pull Request #99635 · python/cpython · GitHub

Open Graph Title: gh-99508: fix `TypeError` in `Lib/importlib/_bootstrap_external.py` by sobolevn · Pull Request #99635 · python/cpython

X Title: gh-99508: fix `TypeError` in `Lib/importlib/_bootstrap_external.py` by sobolevn · Pull Request #99635 · python/cpython

Description: This code is clearly not covered and not used (otherwise this bug would be noticed): Do we need to test it? How can we do it? CC @FFY00 Issue: Call to _imp.source_hash with incorrect arguments ...

Open Graph Description: This code is clearly not covered and not used (otherwise this bug would be noticed): Do we need to test it? How can we do it? CC @FFY00 Issue: Call to _imp.source_hash with incorrect arguments ...

X Description: This code is clearly not covered and not used (otherwise this bug would be noticed): Do we need to test it? How can we do it? CC @FFY00 Issue: Call to _imp.source_hash with incorrect arguments ...

Opengraph URL: https://github.com/python/cpython/pull/99635

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ed6dd385-6585-31f0-3711-33159283cef6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD98E:E1D0E:E38CAD:12B37C4:696B657C
html-safe-nonce01fcc719aeb172d3a592d394fbd86e76ad540d77556cec722fd2c8934bf1d013
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOThFOkUxRDBFOkUzOENBRDoxMkIzN0M0OjY5NkI2NTdDIiwidmlzaXRvcl9pZCI6IjM0NDk0NDM2MjQ4MDgwNDc5OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac13199b1554d01b4c44f1aeb195ba5376c7ea32544c1ce6a7ee44321166a9f8bc
hovercard-subject-tagpull_request:1129634250
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/99635/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d744f649f602134825121152488432e2a96e9a8247e24c6782bef82eddfab09/python/cpython/pull/99635
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d744f649f602134825121152488432e2a96e9a8247e24c6782bef82eddfab09/python/cpython/pull/99635
og:image:altThis code is clearly not covered and not used (otherwise this bug would be noticed): Do we need to test it? How can we do it? CC @FFY00 Issue: Call to _imp.source_hash with incorrect arguments ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99635#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99635
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99635
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99635
Reloadhttps://github.com/python/cpython/pull/99635
Reloadhttps://github.com/python/cpython/pull/99635
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/99635
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/99635
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/99635#issue-comment-box
benjaminphttps://github.com/benjaminp
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-99508https://github.com/sobolevn/cpython/tree/issue-99508
gh-99508: fix TypeError in Lib/importlib/_bootstrap_external.py https://github.com/python/cpython/pull/99635#top
benjaminphttps://github.com/benjaminp
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-99508https://github.com/sobolevn/cpython/tree/issue-99508
Conversation 6 https://github.com/python/cpython/pull/99635
Commits 1 https://github.com/python/cpython/pull/99635/commits
Checks 0 https://github.com/python/cpython/pull/99635/checks
Files changed https://github.com/python/cpython/pull/99635/files
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Nov 21, 2022https://github.com/python/cpython/pull/99635#issue-1457471605
Please reload this pagehttps://github.com/python/cpython/pull/99635
@FFY00https://github.com/FFY00
Call to _imp.source_hash with incorrect arguments in (unreachable?) part of SourceLoader.get_code (importlib._bootstrap_external) #99508https://github.com/python/cpython/issues/99508
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/sobolevn
pythongh-99508https://github.com/python/cpython/issues/99508
: fixhttps://github.com/python/cpython/pull/99635/commits/4890a21158382b61e1662107c7a80dd34d037ad4
TypeErrorhttps://github.com/python/cpython/pull/99635/commits/4890a21158382b61e1662107c7a80dd34d037ad4
in `Lib/importlib/_bootstrap_external…https://github.com/python/cpython/pull/99635/commits/4890a21158382b61e1662107c7a80dd34d037ad4
4890a21https://github.com/python/cpython/pull/99635/commits/4890a21158382b61e1662107c7a80dd34d037ad4
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 21, 2022 https://github.com/python/cpython/pull/99635#ref-issue-1449688589
Call to _imp.source_hash with incorrect arguments in (unreachable?) part of SourceLoader.get_code (importlib._bootstrap_external) #99508 https://github.com/python/cpython/issues/99508
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 21, 2022https://github.com/python/cpython/pull/99635#event-7854668831
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
Nov 21, 2022https://github.com/python/cpython/pull/99635#issuecomment-1322069637
Please reload this pagehttps://github.com/python/cpython/pull/99635
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/FFY00
FFY00https://github.com/FFY00
Nov 21, 2022 https://github.com/python/cpython/pull/99635#pullrequestreview-1188569936
View reviewed changes https://github.com/python/cpython/pull/99635/files/4890a21158382b61e1662107c7a80dd34d037ad4
FFY00https://github.com/FFY00
https://github.com/python/cpython/pull/99635#pullrequestreview-1188569936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@benjaminphttps://github.com/benjaminp
#4575https://github.com/python/cpython/pull/4575
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 21, 2022https://github.com/python/cpython/pull/99635#event-7859131166
https://github.com/FFY00
FFY00https://github.com/FFY00
benjaminphttps://github.com/benjaminp
November 21, 2022 16:27https://github.com/python/cpython/pull/99635#event-7859132265
https://github.com/benjaminp
benjaminphttps://github.com/benjaminp
Nov 21, 2022https://github.com/python/cpython/pull/99635#issuecomment-1322761256
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
Nov 22, 2022https://github.com/python/cpython/pull/99635#issuecomment-1322898947
cpython/Lib/importlib/_bootstrap_external.pyhttps://github.com/python/cpython/blob/2781ec9b0e41a62cecc189c22dfc849f9a56927c/Lib/importlib/_bootstrap_external.py#L1099-L1110
2781ec9https://github.com/python/cpython/commit/2781ec9b0e41a62cecc189c22dfc849f9a56927c
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Nov 22, 2022https://github.com/python/cpython/pull/99635#issuecomment-1323371427
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/DavidCEllis
DavidCEllishttps://github.com/DavidCEllis
Nov 22, 2022https://github.com/python/cpython/pull/99635#issuecomment-1323461306
cpython/Lib/importlib/_bootstrap_external.pyhttps://github.com/python/cpython/blob/2781ec9b0e41a62cecc189c22dfc849f9a56927c/Lib/importlib/_bootstrap_external.py#L1133-L1138
2781ec9https://github.com/python/cpython/commit/2781ec9b0e41a62cecc189c22dfc849f9a56927c
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/benjaminp
benjaminphttps://github.com/benjaminp
c69cfcdhttps://github.com/python/cpython/commit/c69cfcdb116c4907b306e2bd0e263d5ceba48bd5
Nov 23, 2022https://github.com/python/cpython/pull/99635#event-7881192535
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 23, 2022https://github.com/python/cpython/pull/99635#event-7881192702
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99635
https://github.com/FFY00
FFY00 https://github.com/FFY00
https://github.com/python/cpython/pull/99635/files/4890a21158382b61e1662107c7a80dd34d037ad4
https://github.com/benjaminp
benjaminp https://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/99635
https://github.com/sobolevn
https://github.com/DavidCEllis
https://github.com/benjaminp
https://github.com/FFY00
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.