René's URL Explorer Experiment


Title: gh-100519: simplification to `eff_request_host` in cookiejar.py by glyph · Pull Request #99588 · python/cpython · GitHub

Open Graph Title: gh-100519: simplification to `eff_request_host` in cookiejar.py by glyph · Pull Request #99588 · python/cpython

X Title: gh-100519: simplification to `eff_request_host` in cookiejar.py by glyph · Pull Request #99588 · python/cpython

Description: IPV4_RE includes a ., and the .find(".") == -1 included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern in syntax to make it clear what the check is doing here This change is trivial so I did not open an issue. I filed #31004 for this same change, and a bot linked linked me to some CLA instructions which tell me a bot will present me with a button in the comment. So I assume the workflow has changed and I'll get a CLA bot request on this new PR. Issue: gh-100519

Open Graph Description: IPV4_RE includes a ., and the .find(".") == -1 included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern in...

X Description: IPV4_RE includes a ., and the .find(".") == -1 included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use mo...

Opengraph URL: https://github.com/python/cpython/pull/99588

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:674817e4-01bc-2224-7541-d508f59cc108
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FCC:B510C:1B2DC68:2645AA3:696902CF
html-safe-nonce4cd22abbc9dc0b42f60ac87ed608a2822ed3922e9385b049c2c3d74adcda7a7d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkNDOkI1MTBDOjFCMkRDNjg6MjY0NUFBMzo2OTY5MDJDRiIsInZpc2l0b3JfaWQiOiI0NzE2NTU3MzAxODE0MTk4OTkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd7bdf803b6a2897a4fbc4931eb54e04d892a9422de19b033359f0013f9121136
hovercard-subject-tagpull_request:1128344575
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99588/files
twitter:imagehttps://avatars.githubusercontent.com/u/716529?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/716529?s=400&v=4
og:image:altIPV4_RE includes a ., and the .find(".") == -1 included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee6156bd4ef9f2dc8dadf4c49a8f7ed8532186388cef72eda3ccb9f0ab3b8cfca
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefd1938215b152e2c6a29cf56fec07fd9f91f1203
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99588/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99588%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99588%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99588/files
Reloadhttps://github.com/python/cpython/pull/99588/files
Reloadhttps://github.com/python/cpython/pull/99588/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/99588/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/99588/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hauntsaninjahttps://github.com/hauntsaninja
python:mainhttps://github.com/python/cpython/tree/main
glyph:patch-1https://github.com/glyph/cpython/tree/patch-1
Conversation 13 https://github.com/python/cpython/pull/99588
Commits 4 https://github.com/python/cpython/pull/99588/commits
Checks 0 https://github.com/python/cpython/pull/99588/checks
Files changed https://github.com/python/cpython/pull/99588/files
Please reload this pagehttps://github.com/python/cpython/pull/99588/files
gh-100519: simplification to eff_request_host in cookiejar.py https://github.com/python/cpython/pull/99588/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/99588/files
33c0ea6 small simplification to `eff_request_host` in cookiejar.py glyph Jan 29, 2022 https://github.com/python/cpython/pull/99588/commits/33c0ea6c721a3f9f623a4e8b26165d79a0025f35
51d53dc Merge branch 'main' into patch-1 glyph Nov 18, 2022 https://github.com/python/cpython/pull/99588/commits/51d53dca4a2e5413b492de53154a4ce7be6573ab
a431fb6 news hauntsaninja Dec 24, 2022 https://github.com/python/cpython/pull/99588/commits/a431fb6eeab8795025030f33cb72eb3263d5aace
e1506dd Merge branch 'main' into patch-1 JelleZijlstra Dec 24, 2022 https://github.com/python/cpython/pull/99588/commits/e1506dd77374c827aea5c7dac9004f0e8499571a
Clear filters https://github.com/python/cpython/pull/99588/files
Please reload this pagehttps://github.com/python/cpython/pull/99588/files
Please reload this pagehttps://github.com/python/cpython/pull/99588/files
cookiejar.py https://github.com/python/cpython/pull/99588/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
2022-12-24-16-39-53.gh-issue-100519.G_dZLP.rst https://github.com/python/cpython/pull/99588/files#diff-e624d7cab8b7da96513afd91a143b561552b36f421e6bab8034d56a89c04bbd5
Lib/http/cookiejar.pyhttps://github.com/python/cpython/pull/99588/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
View file https://github.com/glyph/cpython/blob/e1506dd77374c827aea5c7dac9004f0e8499571a/Lib/http/cookiejar.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99588/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99588/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
https://github.com/python/cpython/pull/99588/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
Misc/NEWS.d/next/Library/2022-12-24-16-39-53.gh-issue-100519.G_dZLP.rsthttps://github.com/python/cpython/pull/99588/files#diff-e624d7cab8b7da96513afd91a143b561552b36f421e6bab8034d56a89c04bbd5
View file https://github.com/glyph/cpython/blob/e1506dd77374c827aea5c7dac9004f0e8499571a/Misc/NEWS.d/next/Library/2022-12-24-16-39-53.gh-issue-100519.G_dZLP.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99588/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.