René's URL Explorer Experiment


Title: bpo-35017: Lib/socketserver, do not accept any request after shutdown by beledouxdenis · Pull Request #9952 · python/cpython · GitHub

Open Graph Title: bpo-35017: Lib/socketserver, do not accept any request after shutdown by beledouxdenis · Pull Request #9952 · python/cpython

X Title: bpo-35017: Lib/socketserver, do not accept any request after shutdown by beledouxdenis · Pull Request #9952 · python/cpython

Description: Prior to this revision, After the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problematic for instance for a server restart for which you do not want to interrupt the service, by not closing the listening socket during the restart. One request failed because of this behavior. Note that only one request failed, following requests were not accepted, as expected. https://bugs.python.org/issue35017 We solved this issue in odoo/odoo by overriding _handle_request_noblock, in the below revision: odoo/odoo@dcb5641#diff-7c4c00ad10cee1a79d1ed0d8b96f0bfaR140 We would like to avoid having to do so, as this is not a method which is supposed to be overridden.

Open Graph Description: Prior to this revision, After the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problemat...

X Description: Prior to this revision, After the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problemat...

Opengraph URL: https://github.com/python/cpython/pull/9952

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:800cfa9a-e46e-e31a-b053-7405ec5d3286
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF8E:1F87:3E3D8D:4E05E4:6B020ADE
html-safe-nonce363585d0fb8511a75df3d1c401d517ecc153b0a7663cf50ae45c06c8092528ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjhFOjFGODc6M0UzRDhEOjRFMDVFNDo2QjAyMEFERSIsInZpc2l0b3JfaWQiOiI2NzY3ODQ1NTg4MDU5OTQ5NzkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca405b9f545e84b19f22e40523a7542c30d71cb0169e691ad5dffd1cb9808cec5
hovercard-subject-tagpull_request:223929408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/9952/files
twitter:imagehttps://avatars.githubusercontent.com/u/5822488?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5822488?s=400&v=4
og:image:altPrior to this revision, After the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problemat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9952/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9952%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9952%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9952/files
Reloadhttps://github.com/python/cpython/pull/9952/files
Reloadhttps://github.com/python/cpython/pull/9952/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
beledouxdenis:fix-issue-35017https://github.com/beledouxdenis/cpython/tree/fix-issue-35017
Conversation 31 https://github.com/python/cpython/pull/9952
Commits 4 https://github.com/python/cpython/pull/9952/commits
Checks 0 https://github.com/python/cpython/pull/9952/checks
Files changed https://github.com/python/cpython/pull/9952/files
Please reload this pagehttps://github.com/python/cpython/pull/9952/files
bpo-35017: Lib/socketserver, do not accept any request after shutdown https://github.com/python/cpython/pull/9952/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/9952/files
57f0822 bpo-35017: `BaseServer` should not accept any request after shutdown … beledouxdenis Oct 18, 2018 https://github.com/python/cpython/pull/9952/commits/57f0822397fb78ff2540cd26476ecdb3933fc816
928be37 bpo-35017: remove the unit test as it's time-based beledouxdenis Oct 25, 2018 https://github.com/python/cpython/pull/9952/commits/928be3765b977b80a48d4144b0b055f6243b431d
b9fb425 bpo-35017: reword the news to represent the new behavior beledouxdenis Oct 25, 2018 https://github.com/python/cpython/pull/9952/commits/b9fb425f3e87ad8f52683708235e731654011a9d
7992fb0 bpo-35017: reword inline comment to be shorter and cleaner beledouxdenis Oct 26, 2018 https://github.com/python/cpython/pull/9952/commits/7992fb06b57899b2ea84115e29d6ac64c89b8112
Clear filters https://github.com/python/cpython/pull/9952/files
Please reload this pagehttps://github.com/python/cpython/pull/9952/files
Please reload this pagehttps://github.com/python/cpython/pull/9952/files
socketserver.py https://github.com/python/cpython/pull/9952/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
2018-10-26-00-11-21.bpo-35017.6Ez4Cv.rst https://github.com/python/cpython/pull/9952/files#diff-60ea7316d244642d613c88667fc1b5a470ce4fdb71cca46ad1481b1dcde6099f
Lib/socketserver.pyhttps://github.com/python/cpython/pull/9952/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
View file https://github.com/beledouxdenis/cpython/blob/7992fb06b57899b2ea84115e29d6ac64c89b8112/Lib/socketserver.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9952/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9952/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
Please reload this pagehttps://github.com/python/cpython/pull/9952/files
https://github.com/python/cpython/pull/9952/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
Misc/NEWS.d/next/Library/2018-10-26-00-11-21.bpo-35017.6Ez4Cv.rsthttps://github.com/python/cpython/pull/9952/files#diff-60ea7316d244642d613c88667fc1b5a470ce4fdb71cca46ad1481b1dcde6099f
View file https://github.com/beledouxdenis/cpython/blob/7992fb06b57899b2ea84115e29d6ac64c89b8112/Misc/NEWS.d/next/Library/2018-10-26-00-11-21.bpo-35017.6Ez4Cv.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9952/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.