Title: gh-94912: Added marker for non-standard coroutine function detection by carltongibson · Pull Request #99247 · python/cpython · GitHub
Open Graph Title: gh-94912: Added marker for non-standard coroutine function detection by carltongibson · Pull Request #99247 · python/cpython
X Title: gh-94912: Added marker for non-standard coroutine function detection by carltongibson · Pull Request #99247 · python/cpython
Description: This is ref the discussion on #94912 to add an official way of marking callables as coroutine functions where they would not otherwise be detected. cc. @gvanrossum @andrewgodwin I've just had time this afternoon to block off some first tests, and docs. I wanted to break ground so we keep it moving. It's very consciously drafts: please make suggestions of how you think it should go. @gvanrossum Can I ask for a pointer on how I'm meant to set co_flags for the _has_code_flag() check? 🤔 cpython/Lib/inspect.py Lines 376 to 385 in c43714f def _has_code_flag(f, flag): """Return true if ``f`` is a function (or a method or functools.partial wrapper wrapping a function) whose code object has the given ``flag`` set in its flags.""" while ismethod(f): f = f.__func__ f = functools._unwrap_partial(f) if not (isfunction(f) or _signature_is_functionlike(f)): return False return bool(f.__code__.co_flags & flag) Thanks! First PR on CPython, so likely it's wrong 😊 Clone and Build as per https://devguide.python.org. Run new just tests with % ./python.exe -m unittest test.test_inspect.TestPredicates Do we need to create a new ticket, or is #94912 OK? Issue: gh-94912
Open Graph Description: This is ref the discussion on #94912 to add an official way of marking callables as coroutine functions where they would not otherwise be detected. cc. @gvanrossum @andrewgodwin I've just had t...
X Description: This is ref the discussion on #94912 to add an official way of marking callables as coroutine functions where they would not otherwise be detected. cc. @gvanrossum @andrewgodwin I've just h...
Opengraph URL: https://github.com/python/cpython/pull/99247
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:5670870d-3874-0f12-1317-5beb7015d604 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 91D0:27A700:148F8C7:1CFB4CA:69691CB9 |
| html-safe-nonce | 82f2b9748f81cbf5fa4ad3f319c72fa8bcbf672add70aca3c52bc04726341989 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUQwOjI3QTcwMDoxNDhGOEM3OjFDRkI0Q0E6Njk2OTFDQjkiLCJ2aXNpdG9yX2lkIjoiNTY2MDc1MDY4MDA5OTk4NjYxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 419908f80a1c7c88e4b1081ece31dd05aca368bb63a4b6a68c1257817bf77f49 |
| hovercard-subject-tag | pull_request:1114489506 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/99247/checks |
| twitter:image | https://avatars.githubusercontent.com/u/64686?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/64686?s=400&v=4 |
| og:image:alt | This is ref the discussion on #94912 to add an official way of marking callables as coroutine functions where they would not otherwise be detected. cc. @gvanrossum @andrewgodwin I've just had t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd206f7ed6207863172be4a783826e86bd2375c3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width