René's URL Explorer Experiment


Title: gh-86018 Inconsistent errors for JSON-encoding NaNs with allow_nan=False by WillAyd · Pull Request #99172 · python/cpython · GitHub

Open Graph Title: gh-86018 Inconsistent errors for JSON-encoding NaNs with allow_nan=False by WillAyd · Pull Request #99172 · python/cpython

X Title: gh-86018 Inconsistent errors for JSON-encoding NaNs with allow_nan=False by WillAyd · Pull Request #99172 · python/cpython

Description: Fix issue where json.dumps provided a different error message than json.dump with non-finite values Issue: Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018

Open Graph Description: Fix issue where json.dumps provided a different error message than json.dump with non-finite values Issue: Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018

X Description: Fix issue where json.dumps provided a different error message than json.dump with non-finite values Issue: Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018

Opengraph URL: https://github.com/python/cpython/pull/99172

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:20ae9398-53de-bae2-9ec3-f024fc051bd8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91DC:1E6D3F:918495:C24F2B:69697C89
html-safe-nonce1525c0a3a13252ba10caba75c3cced1c9cb694d7d9631746edcca9de0ebeec56
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MURDOjFFNkQzRjo5MTg0OTU6QzI0RjJCOjY5Njk3Qzg5IiwidmlzaXRvcl9pZCI6IjQ0NzYxODMwMjc1Mjc1NDgwNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac442ec50639da2692bfc9e42e5189204e14c2dbe945171dec22b83b89004ac42c
hovercard-subject-tagpull_request:1112049326
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99172
twitter:imagehttps://opengraph.githubassets.com/e9475d22a47a49db4d000755a9fe3323d3fb35a6882feb245b414c35c3e2b369/python/cpython/pull/99172
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e9475d22a47a49db4d000755a9fe3323d3fb35a6882feb245b414c35c3e2b369/python/cpython/pull/99172
og:image:altFix issue where json.dumps provided a different error message than json.dump with non-finite values Issue: Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameWillAyd
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99172#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99172
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99172
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99172
Reloadhttps://github.com/python/cpython/pull/99172
Reloadhttps://github.com/python/cpython/pull/99172
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/99172
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/99172
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/99172#issue-comment-box
WillAydhttps://github.com/WillAyd
python:mainhttps://github.com/python/cpython/tree/main
WillAyd:json-better-errorhttps://github.com/WillAyd/cpython/tree/json-better-error
gh-86018 Inconsistent errors for JSON-encoding NaNs with allow_nan=False https://github.com/python/cpython/pull/99172#top
WillAydhttps://github.com/WillAyd
python:mainhttps://github.com/python/cpython/tree/main
WillAyd:json-better-errorhttps://github.com/WillAyd/cpython/tree/json-better-error
Conversation 3 https://github.com/python/cpython/pull/99172
Commits 3 https://github.com/python/cpython/pull/99172/commits
Checks 0 https://github.com/python/cpython/pull/99172/checks
Files changed https://github.com/python/cpython/pull/99172/files
Please reload this pagehttps://github.com/python/cpython/pull/99172
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/WillAyd
WillAydhttps://github.com/WillAyd
Nov 6, 2022https://github.com/python/cpython/pull/99172#issue-1437520072
Please reload this pagehttps://github.com/python/cpython/pull/99172
Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018https://github.com/python/cpython/issues/86018
Please reload this pagehttps://github.com/python/cpython/pull/99172
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 6, 2022 https://github.com/python/cpython/pull/99172#ref-issue-1199044039
Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018 https://github.com/python/cpython/issues/86018
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 6, 2022https://github.com/python/cpython/pull/99172#event-7747831892
https://github.com/WillAyd
pythongh-86018https://github.com/python/cpython/issues/86018
Inconsistent errors for JSON-encoding NaNs with allow_…https://github.com/python/cpython/pull/99172/commits/17901af607074436228727243ae6c2356e6b4903
17901afhttps://github.com/python/cpython/pull/99172/commits/17901af607074436228727243ae6c2356e6b4903
https://github.com/WillAyd
WillAydhttps://github.com/WillAyd
force-pushedhttps://github.com/python/cpython/compare/4ade4c007de38489135a67a92b440462735cd56f..17901af607074436228727243ae6c2356e6b4903
4ade4c0https://github.com/python/cpython/commit/4ade4c007de38489135a67a92b440462735cd56f
17901afhttps://github.com/python/cpython/commit/17901af607074436228727243ae6c2356e6b4903
Compare https://github.com/python/cpython/compare/4ade4c007de38489135a67a92b440462735cd56f..17901af607074436228727243ae6c2356e6b4903
November 6, 2022 20:02https://github.com/python/cpython/pull/99172#event-7747841331
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Nov 7, 2022 https://github.com/python/cpython/pull/99172#pullrequestreview-1169996694
View reviewed changes https://github.com/python/cpython/pull/99172/files/17901af607074436228727243ae6c2356e6b4903
Misc/NEWS.d/next/Library/2022-11-06-19-59-56.gh-issue-86018.xAt6g2.rsthttps://github.com/python/cpython/pull/99172/files/17901af607074436228727243ae6c2356e6b4903#diff-4e0a450ed181a50f6b4aba98cd738fb0f4fd3347704ce4ab9bfe4d7d5727e20a
Please reload this pagehttps://github.com/python/cpython/pull/99172
Modules/_json.chttps://github.com/python/cpython/pull/99172/files/17901af607074436228727243ae6c2356e6b4903#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
Please reload this pagehttps://github.com/python/cpython/pull/99172
WillAydhttps://github.com/WillAyd
November 7, 2022 10:36https://github.com/python/cpython/pull/99172#commits-pushed-0d2798e
https://github.com/WillAyd
suggestionshttps://github.com/python/cpython/pull/99172/commits/0d2798e9d94f374499054a3b788e73ff26d22736
0d2798ehttps://github.com/python/cpython/pull/99172/commits/0d2798e9d94f374499054a3b788e73ff26d22736
https://github.com/WillAyd
simplified implementationhttps://github.com/python/cpython/pull/99172/commits/4b8516cf143129225aca0d7b90180d86dfd1ac77
4b8516chttps://github.com/python/cpython/pull/99172/commits/4b8516cf143129225aca0d7b90180d86dfd1ac77
https://github.com/WillAyd
WillAydhttps://github.com/WillAyd
Oct 24, 2023https://github.com/python/cpython/pull/99172#event-10758441278
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99172
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/cpython/pull/99172/files/17901af607074436228727243ae6c2356e6b4903
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/99172
https://github.com/WillAyd
https://github.com/sobolevn
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.