René's URL Explorer Experiment


Title: gh-75729: Fix os.spawn tests not handling spaces on Windows by CAM-Gerlach · Pull Request #99150 · python/cpython · GitHub

Open Graph Title: gh-75729: Fix os.spawn tests not handling spaces on Windows by CAM-Gerlach · Pull Request #99150 · python/cpython

X Title: gh-75729: Fix os.spawn tests not handling spaces on Windows by CAM-Gerlach · Pull Request #99150 · python/cpython

Description: As originally reported in #75729 and confirmed to still be reproducible on the latest Python 3.12, the various os.spawn* tests are broken on Windows if the current working directory contains any spaces in its path (e.g. due to spaces in the username), as on Windows the arguments are simply concatenated and not quoted. This PR fixes the immediate issue with the tests by quoting the arguments in question on Windows. Issue: gh-75729

Open Graph Description: As originally reported in #75729 and confirmed to still be reproducible on the latest Python 3.12, the various os.spawn* tests are broken on Windows if the current working directory contains any sp...

X Description: As originally reported in #75729 and confirmed to still be reproducible on the latest Python 3.12, the various os.spawn* tests are broken on Windows if the current working directory contains any sp...

Opengraph URL: https://github.com/python/cpython/pull/99150

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:11c1b640-5639-aef7-5bdb-220fd6ded4b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD88:308D9D:28A5575:378B535:6B004B79
html-safe-nonce5c6ae2fd1646f8f1464e23d413dc6f8bd0e5d84f049b20877f8e9e340b3b4666
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDg4OjMwOEQ5RDoyOEE1NTc1OjM3OEI1MzU6NkIwMDRCNzkiLCJ2aXNpdG9yX2lkIjoiNTA5OTQ1ODMyMjA4ODYxMDY4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac72b94e0936fcc6aee12ffef0c62f73db909a4873a8038f696a826f7a5b4d13ce
hovercard-subject-tagpull_request:1111889322
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99150/files
twitter:imagehttps://avatars.githubusercontent.com/u/17051931?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17051931?s=400&v=4
og:image:altAs originally reported in #75729 and confirmed to still be reproducible on the latest Python 3.12, the various os.spawn* tests are broken on Windows if the current working directory contains any sp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99150/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99150%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99150%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99150/files
Reloadhttps://github.com/python/cpython/pull/99150/files
Reloadhttps://github.com/python/cpython/pull/99150/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
CAM-Gerlach:fix-spawn-tests-space-in-pathhttps://github.com/CAM-Gerlach/cpython/tree/fix-spawn-tests-space-in-path
Conversation 13 https://github.com/python/cpython/pull/99150
Commits 4 https://github.com/python/cpython/pull/99150/commits
Checks 0 https://github.com/python/cpython/pull/99150/checks
Files changed https://github.com/python/cpython/pull/99150/files
Please reload this pagehttps://github.com/python/cpython/pull/99150/files
gh-75729: Fix os.spawn tests not handling spaces on Windows https://github.com/python/cpython/pull/99150/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/99150/files
b427d44 Quote paths in os.spawn tests on Windows so they work with spaces CAM-Gerlach Nov 6, 2022 https://github.com/python/cpython/pull/99150/commits/b427d44fec66b0b7eea83e6eee386855f7fb858a
2362e81 Add NEWS entry for os spawn test fix CAM-Gerlach Nov 7, 2022 https://github.com/python/cpython/pull/99150/commits/2362e819b954b4232d783c7a3364efff309e74c0
29a45d8 Fix code style to avoid double negative in os.spawn tests CAM-Gerlach Nov 7, 2022 https://github.com/python/cpython/pull/99150/commits/29a45d8c48a1b58167c12e549c7462d554df0033
fa1c8e8 Merge branch 'main' into fix-spawn-tests-space-in-path CAM-Gerlach Apr 8, 2023 https://github.com/python/cpython/pull/99150/commits/fa1c8e8e318159c05871cb99b2e2d53fe71ce456
Clear filters https://github.com/python/cpython/pull/99150/files
Please reload this pagehttps://github.com/python/cpython/pull/99150/files
Please reload this pagehttps://github.com/python/cpython/pull/99150/files
test_os.py https://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
2022-11-06-18-42-38.gh-issue-75729.uGYJrv.rst https://github.com/python/cpython/pull/99150/files#diff-75567bf5caaa3dcfd0ab2a1578b2aeed7ab239be38807597d85a254e0a4acb44
Lib/test/test_os.pyhttps://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
View file https://github.com/CAM-Gerlach/cpython/blob/fa1c8e8e318159c05871cb99b2e2d53fe71ce456/Lib/test/test_os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99150/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
Please reload this pagehttps://github.com/python/cpython/pull/99150/files
https://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/99150/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
Misc/NEWS.d/next/Tests/2022-11-06-18-42-38.gh-issue-75729.uGYJrv.rsthttps://github.com/python/cpython/pull/99150/files#diff-75567bf5caaa3dcfd0ab2a1578b2aeed7ab239be38807597d85a254e0a4acb44
View file https://github.com/CAM-Gerlach/cpython/blob/fa1c8e8e318159c05871cb99b2e2d53fe71ce456/Misc/NEWS.d/next/Tests/2022-11-06-18-42-38.gh-issue-75729.uGYJrv.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99150/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.