| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9abdb169-086d-7d58-728f-21e204864946 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA18:16AB79:4437A5A:56925A7:6B023368 |
| html-safe-nonce | 1c1d498d88acbefc4d2bce2a3c3fbb1a34d58ddc0d2b688fa7a8a0b9aa9ab768 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTE4OjE2QUI3OTo0NDM3QTVBOjU2OTI1QTc6NkIwMjMzNjgiLCJ2aXNpdG9yX2lkIjoiODgyMTY0MjI1NDQxNjc0MDg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ebba773cc70b181cecc9b6a7145362643691eca8e931bd4ace17a9b468923600 |
| hovercard-subject-tag | pull_request:1110625911 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/99092/files |
| twitter:image | https://avatars.githubusercontent.com/u/68491?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/68491?s=400&v=4 |
| og:image:alt | There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonabl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/99092/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99092%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99092%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/99092/files |
| Reload | https://github.com/python/cpython/pull/99092/files |
| Reload | https://github.com/python/cpython/pull/99092/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| gpshead:security/idna_dos_mitigation | https://github.com/gpshead/cpython/tree/security/idna_dos_mitigation |
|
Conversation
19
| https://github.com/python/cpython/pull/99092 |
|
Commits
8
| https://github.com/python/cpython/pull/99092/commits |
|
Checks
0
| https://github.com/python/cpython/pull/99092/checks |
|
Files changed
| https://github.com/python/cpython/pull/99092/files |
| Please reload this page | https://github.com/python/cpython/pull/99092/files |
|
gh-98433: Fix quadratic time idna decoding.
| https://github.com/python/cpython/pull/99092/files#top |
|
Show all changes
8 commits
| https://github.com/python/cpython/pull/99092/files |
|
365a6cb
gh-98433: Fix quadratic time idna decoding.
gpshead Nov 4, 2022
| https://github.com/python/cpython/pull/99092/commits/365a6cb2e43b51a2a0fa80b8b21f489f3a397532 |
|
4bf248b
drop the timing test, add an upfront limit.
gpshead Nov 4, 2022
| https://github.com/python/cpython/pull/99092/commits/4bf248b97ab3c99b7864a272fe34741cddfea0c9 |
|
db498cb
Expand the label limit comments.
gpshead Nov 4, 2022
| https://github.com/python/cpython/pull/99092/commits/db498cb463b95d268c5eb91b041c6032dcd0df8a |
|
be30a48
Also add a short "too long" test assert.
gpshead Nov 4, 2022
| https://github.com/python/cpython/pull/99092/commits/be30a482515d1343821c72a757b73b89f33c9d8a |
|
038bbcd
Refactor into nicer code. Expand the NEWS entry.
gpshead Nov 4, 2022
| https://github.com/python/cpython/pull/99092/commits/038bbcdb8187ce7bce0a4086b40f9466e8f42780 |
|
cf3a20e
news wording tweak.
gpshead Nov 4, 2022
| https://github.com/python/cpython/pull/99092/commits/cf3a20ec7b8fac342b4afd9d42a8571e0cc73452 |
|
bd51456
more RFC links and explanation.
gpshead Nov 4, 2022
| https://github.com/python/cpython/pull/99092/commits/bd51456952dedc5af1864b6595d97e78bf67a9c0 |
|
5a3b037
assertRaisesRegex
gpshead Nov 7, 2022
| https://github.com/python/cpython/pull/99092/commits/5a3b03750f57429f7529c9e0e3603c07d38cedd9 |
|
Clear filters
| https://github.com/python/cpython/pull/99092/files |
| Please reload this page | https://github.com/python/cpython/pull/99092/files |
| Please reload this page | https://github.com/python/cpython/pull/99092/files |
|
idna.py
| https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce |
|
test_codecs.py
| https://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96 |
|
2022-11-04-09-29-36.gh-issue-98433.l76c5G.rst
| https://github.com/python/cpython/pull/99092/files#diff-cf32da3207a99d845c7e4a746c7ebc5d08c475f4b94890714c6661e1663701dd |
| Lib/encodings/idna.py | https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce |
|
View file
| https://github.com/gpshead/cpython/blob/5a3b03750f57429f7529c9e0e3603c07d38cedd9/Lib/encodings/idna.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/99092/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce |
|
| https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce |
|
| https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce |
|
| https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce |
| Lib/test/test_codecs.py | https://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96 |
|
View file
| https://github.com/gpshead/cpython/blob/5a3b03750f57429f7529c9e0e3603c07d38cedd9/Lib/test/test_codecs.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/99092/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96 |
|
| https://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96 |
| Misc/NEWS.d/next/Security/2022-11-04-09-29-36.gh-issue-98433.l76c5G.rst | https://github.com/python/cpython/pull/99092/files#diff-cf32da3207a99d845c7e4a746c7ebc5d08c475f4b94890714c6661e1663701dd |
|
View file
| https://github.com/gpshead/cpython/blob/5a3b03750f57429f7529c9e0e3603c07d38cedd9/Misc/NEWS.d/next/Security/2022-11-04-09-29-36.gh-issue-98433.l76c5G.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/99092/{{ revealButtonHref }} |
| gpshead | https://github.com/gpshead |
| Nov 4, 2022 | https://github.com/python/cpython/pull/99092/files#r1014441324 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/python/cpython/blob/main/Lib/encodings/idna.py#L18 | https://github.com/python/cpython/blob/main/Lib/encodings/idna.py#L18 |
| non-ascii unicode oddities | https://datatracker.ietf.org/doc/html/rfc3454#section-3.1 |
| https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/uidna.cpp#763 | https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/uidna.cpp#763 |
| https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/usprep.cpp#604 | https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/usprep.cpp#604 |
| Please reload this page | https://github.com/python/cpython/pull/99092/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |