René's URL Explorer Experiment


Title: gh-98433: Fix quadratic time idna decoding. by gpshead · Pull Request #99092 · python/cpython · GitHub

Open Graph Title: gh-98433: Fix quadratic time idna decoding. by gpshead · Pull Request #99092 · python/cpython

X Title: gh-98433: Fix quadratic time idna decoding. by gpshead · Pull Request #99092 · python/cpython

Description: There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonable. test-with-buildbots (to be done on the backport PR chain) get release manager decision on the shape of the backports. Issue: gh-98433

Open Graph Description: There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonabl...

X Description: There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonabl...

Opengraph URL: https://github.com/python/cpython/pull/99092

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9abdb169-086d-7d58-728f-21e204864946
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA18:16AB79:4437A5A:56925A7:6B023368
html-safe-nonce1c1d498d88acbefc4d2bce2a3c3fbb1a34d58ddc0d2b688fa7a8a0b9aa9ab768
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTE4OjE2QUI3OTo0NDM3QTVBOjU2OTI1QTc6NkIwMjMzNjgiLCJ2aXNpdG9yX2lkIjoiODgyMTY0MjI1NDQxNjc0MDg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacebba773cc70b181cecc9b6a7145362643691eca8e931bd4ace17a9b468923600
hovercard-subject-tagpull_request:1110625911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99092/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altThere was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonabl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99092/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99092%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99092%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99092/files
Reloadhttps://github.com/python/cpython/pull/99092/files
Reloadhttps://github.com/python/cpython/pull/99092/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:security/idna_dos_mitigationhttps://github.com/gpshead/cpython/tree/security/idna_dos_mitigation
Conversation 19 https://github.com/python/cpython/pull/99092
Commits 8 https://github.com/python/cpython/pull/99092/commits
Checks 0 https://github.com/python/cpython/pull/99092/checks
Files changed https://github.com/python/cpython/pull/99092/files
Please reload this pagehttps://github.com/python/cpython/pull/99092/files
gh-98433: Fix quadratic time idna decoding. https://github.com/python/cpython/pull/99092/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/99092/files
365a6cb gh-98433: Fix quadratic time idna decoding. gpshead Nov 4, 2022 https://github.com/python/cpython/pull/99092/commits/365a6cb2e43b51a2a0fa80b8b21f489f3a397532
4bf248b drop the timing test, add an upfront limit. gpshead Nov 4, 2022 https://github.com/python/cpython/pull/99092/commits/4bf248b97ab3c99b7864a272fe34741cddfea0c9
db498cb Expand the label limit comments. gpshead Nov 4, 2022 https://github.com/python/cpython/pull/99092/commits/db498cb463b95d268c5eb91b041c6032dcd0df8a
be30a48 Also add a short "too long" test assert. gpshead Nov 4, 2022 https://github.com/python/cpython/pull/99092/commits/be30a482515d1343821c72a757b73b89f33c9d8a
038bbcd Refactor into nicer code. Expand the NEWS entry. gpshead Nov 4, 2022 https://github.com/python/cpython/pull/99092/commits/038bbcdb8187ce7bce0a4086b40f9466e8f42780
cf3a20e news wording tweak. gpshead Nov 4, 2022 https://github.com/python/cpython/pull/99092/commits/cf3a20ec7b8fac342b4afd9d42a8571e0cc73452
bd51456 more RFC links and explanation. gpshead Nov 4, 2022 https://github.com/python/cpython/pull/99092/commits/bd51456952dedc5af1864b6595d97e78bf67a9c0
5a3b037 assertRaisesRegex gpshead Nov 7, 2022 https://github.com/python/cpython/pull/99092/commits/5a3b03750f57429f7529c9e0e3603c07d38cedd9
Clear filters https://github.com/python/cpython/pull/99092/files
Please reload this pagehttps://github.com/python/cpython/pull/99092/files
Please reload this pagehttps://github.com/python/cpython/pull/99092/files
idna.py https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce
test_codecs.py https://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
2022-11-04-09-29-36.gh-issue-98433.l76c5G.rst https://github.com/python/cpython/pull/99092/files#diff-cf32da3207a99d845c7e4a746c7ebc5d08c475f4b94890714c6661e1663701dd
Lib/encodings/idna.pyhttps://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce
View file https://github.com/gpshead/cpython/blob/5a3b03750f57429f7529c9e0e3603c07d38cedd9/Lib/encodings/idna.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99092/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce
https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce
https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce
https://github.com/python/cpython/pull/99092/files#diff-91bf9852343bf8a6f898248b859b8f425e93105e2af7ab32320b5d087e3b89ce
Lib/test/test_codecs.pyhttps://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
View file https://github.com/gpshead/cpython/blob/5a3b03750f57429f7529c9e0e3603c07d38cedd9/Lib/test/test_codecs.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99092/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
https://github.com/python/cpython/pull/99092/files#diff-a71f034c62318430dc94a9f744b5333e7d8eec577d3a23ab0b76a781872c9b96
Misc/NEWS.d/next/Security/2022-11-04-09-29-36.gh-issue-98433.l76c5G.rsthttps://github.com/python/cpython/pull/99092/files#diff-cf32da3207a99d845c7e4a746c7ebc5d08c475f4b94890714c6661e1663701dd
View file https://github.com/gpshead/cpython/blob/5a3b03750f57429f7529c9e0e3603c07d38cedd9/Misc/NEWS.d/next/Security/2022-11-04-09-29-36.gh-issue-98433.l76c5G.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99092/{{ revealButtonHref }}
gpsheadhttps://github.com/gpshead
Nov 4, 2022https://github.com/python/cpython/pull/99092/files#r1014441324
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/main/Lib/encodings/idna.py#L18https://github.com/python/cpython/blob/main/Lib/encodings/idna.py#L18
non-ascii unicode odditieshttps://datatracker.ietf.org/doc/html/rfc3454#section-3.1
https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/uidna.cpp#763https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/uidna.cpp#763
https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/usprep.cpp#604https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad55c4d3609585820244d59a4462632540c/source/common/usprep.cpp#604
Please reload this pagehttps://github.com/python/cpython/pull/99092/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.