René's URL Explorer Experiment


Title: gh-98433: Fix quadratic time idna decoding. by gpshead · Pull Request #99092 · python/cpython · GitHub

Open Graph Title: gh-98433: Fix quadratic time idna decoding. by gpshead · Pull Request #99092 · python/cpython

X Title: gh-98433: Fix quadratic time idna decoding. by gpshead · Pull Request #99092 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonabl...

X Description: There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonabl...

Opengraph URL: https://github.com/python/cpython/pull/99092

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:80370ef1-ce57-3d05-a8e0-df0e2ad8b08c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2A8:11D6DE:2E476C:3D36DE:6B0233C2
html-safe-nonce5bbf0291c87895ec338f80127063132112ef4e98a55a3cf8003609fe08447b59
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkE4OjExRDZERToyRTQ3NkM6M0QzNkRFOjZCMDIzM0MyIiwidmlzaXRvcl9pZCI6Ijg4NzE4Nzc2MTQ1NjcwNDQwMzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8107b5855fdb1821dae2d9f5415fea5ee5e4f6875c5affae4f33db14ff3dc09f
hovercard-subject-tagpull_request:1110625911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99092/commits
twitter:imagehttps://opengraph.githubassets.com/86b3dd88503f708f53f361600b2328de5bd204caba434cd79b46d825c85a1a92/python/cpython/pull/99092
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/86b3dd88503f708f53f361600b2328de5bd204caba434cd79b46d825c85a1a92/python/cpython/pull/99092
og:image:altThere was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear and adds an upfront length check to avoid even bothering the decoding attempt when clearly unreasonabl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/99092/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99092%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99092%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99092/commits
Reloadhttps://github.com/python/cpython/pull/99092/commits
Reloadhttps://github.com/python/cpython/pull/99092/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:security/idna_dos_mitigationhttps://github.com/gpshead/cpython/tree/security/idna_dos_mitigation
Conversationhttps://github.com/python/cpython/pull/99092
Commits8 (8)https://github.com/python/cpython/pull/99092/commits
Checkshttps://github.com/python/cpython/pull/99092/checks
Files changedhttps://github.com/python/cpython/pull/99092/files
gh-98433: Fix quadratic time idna decoding.https://github.com/python/cpython/pull/99092/commits#top
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:security/idna_dos_mitigationhttps://github.com/gpshead/cpython/tree/security/idna_dos_mitigation
gh-98433: Fix quadratic time idna decoding.https://github.com/python/cpython/pull/99092/commits/365a6cb2e43b51a2a0fa80b8b21f489f3a397532
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
365a6cbhttps://github.com/python/cpython/pull/99092/commits/365a6cb2e43b51a2a0fa80b8b21f489f3a397532
https://github.com/python/cpython/tree/365a6cb2e43b51a2a0fa80b8b21f489f3a397532
drop the timing test, add an upfront limit.https://github.com/python/cpython/pull/99092/commits/4bf248b97ab3c99b7864a272fe34741cddfea0c9
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
4bf248bhttps://github.com/python/cpython/pull/99092/commits/4bf248b97ab3c99b7864a272fe34741cddfea0c9
https://github.com/python/cpython/tree/4bf248b97ab3c99b7864a272fe34741cddfea0c9
Expand the label limit comments.https://github.com/python/cpython/pull/99092/commits/db498cb463b95d268c5eb91b041c6032dcd0df8a
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
db498cbhttps://github.com/python/cpython/pull/99092/commits/db498cb463b95d268c5eb91b041c6032dcd0df8a
https://github.com/python/cpython/tree/db498cb463b95d268c5eb91b041c6032dcd0df8a
Also add a short "too long" test assert.https://github.com/python/cpython/pull/99092/commits/be30a482515d1343821c72a757b73b89f33c9d8a
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
be30a48https://github.com/python/cpython/pull/99092/commits/be30a482515d1343821c72a757b73b89f33c9d8a
https://github.com/python/cpython/tree/be30a482515d1343821c72a757b73b89f33c9d8a
Refactor into nicer code. Expand the NEWS entry.https://github.com/python/cpython/pull/99092/commits/038bbcdb8187ce7bce0a4086b40f9466e8f42780
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
038bbcdhttps://github.com/python/cpython/pull/99092/commits/038bbcdb8187ce7bce0a4086b40f9466e8f42780
https://github.com/python/cpython/tree/038bbcdb8187ce7bce0a4086b40f9466e8f42780
news wording tweak.https://github.com/python/cpython/pull/99092/commits/cf3a20ec7b8fac342b4afd9d42a8571e0cc73452
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
cf3a20ehttps://github.com/python/cpython/pull/99092/commits/cf3a20ec7b8fac342b4afd9d42a8571e0cc73452
https://github.com/python/cpython/tree/cf3a20ec7b8fac342b4afd9d42a8571e0cc73452
more RFC links and explanation.https://github.com/python/cpython/pull/99092/commits/bd51456952dedc5af1864b6595d97e78bf67a9c0
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
bd51456https://github.com/python/cpython/pull/99092/commits/bd51456952dedc5af1864b6595d97e78bf67a9c0
https://github.com/python/cpython/tree/bd51456952dedc5af1864b6595d97e78bf67a9c0
assertRaisesRegexhttps://github.com/python/cpython/pull/99092/commits/5a3b03750f57429f7529c9e0e3603c07d38cedd9
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
5a3b037https://github.com/python/cpython/pull/99092/commits/5a3b03750f57429f7529c9e0e3603c07d38cedd9
https://github.com/python/cpython/tree/5a3b03750f57429f7529c9e0e3603c07d38cedd9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.