René's URL Explorer Experiment


Title: gh-98963: Add a note to the error for property subclasses without __doc__ by encukou · Pull Request #99058 · python/cpython · GitHub

Open Graph Title: gh-98963: Add a note to the error for property subclasses without __doc__ by encukou · Pull Request #99058 · python/cpython

X Title: gh-98963: Add a note to the error for property subclasses without __doc__ by encukou · Pull Request #99058 · python/cpython

Description: Subclasses created using the C API don't get __dict__, which means their __doc__ can't be set for each property separately. The __doc__ descriptor from property itself is shadowed by the subclass's docstring. This edge case isn't really worth mentioning in the docs. This adds a note that should guide anyone encountering the issue to the right fix. The newfangled __notes__ mechanism is as non-invasive as it gets -- it even retains the original exception object -- while getting the information to the surprised user. (The message is longer than typical error messages, but IMO it's better to explain here than in the docs, where 99%+ of the readers don't need it.) Issue: gh-98963

Open Graph Description: Subclasses created using the C API don't get __dict__, which means their __doc__ can't be set for each property separately. The __doc__ descriptor from property itself is shadowed by the su...

X Description: Subclasses created using the C API don't get __dict__, which means their __doc__ can't be set for each property separately. The __doc__ descriptor from property itself is shadowed b...

Opengraph URL: https://github.com/python/cpython/pull/99058

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3913daaa-a2d3-b85c-2cf9-eb169fde16c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF60:2C4B08:7DB2AD:A9B9FE:6969DE22
html-safe-noncef26c3f2608017704cb1fc4bebd95d6c4ea3455a556673a9915d2b2cab32c0f06
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjYwOjJDNEIwODo3REIyQUQ6QTlCOUZFOjY5NjlERTIyIiwidmlzaXRvcl9pZCI6IjMwMDE2OTA0NTM4MTY0OTk3NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac413f45dd95bc78482107d58cff091c3aa210d1edd03eb7472d2be520f42cbd3b
hovercard-subject-tagpull_request:1109631749
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99058/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altSubclasses created using the C API don't get __dict__, which means their __doc__ can't be set for each property separately. The __doc__ descriptor from property itself is shadowed by the su...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99058/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99058%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99058%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99058/files
Reloadhttps://github.com/python/cpython/pull/99058/files
Reloadhttps://github.com/python/cpython/pull/99058/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/99058/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/99058/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:property-subclasses-dochttps://github.com/encukou/cpython/tree/property-subclasses-doc
Conversation 2 https://github.com/python/cpython/pull/99058
Commits 3 https://github.com/python/cpython/pull/99058/commits
Checks 0 https://github.com/python/cpython/pull/99058/checks
Files changed https://github.com/python/cpython/pull/99058/files
Please reload this pagehttps://github.com/python/cpython/pull/99058/files
gh-98963: Add a note to the error for property subclasses without __doc__ https://github.com/python/cpython/pull/99058/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/99058/files
f530eaf gh-98963: Add a note to the error for property subclasses without __d… encukou Nov 3, 2022 https://github.com/python/cpython/pull/99058/commits/f530eaf58f34c03fc4a8dd79dd04e1257f99620e
2d79454 Fix ReST syntax encukou Nov 3, 2022 https://github.com/python/cpython/pull/99058/commits/2d7945467d4895b286567da4351ee572c049aeb4
66428bc Move the note check to an existing test encukou Nov 3, 2022 https://github.com/python/cpython/pull/99058/commits/66428bc68973e2edee5358170d707a57ae1330df
Clear filters https://github.com/python/cpython/pull/99058/files
Please reload this pagehttps://github.com/python/cpython/pull/99058/files
Please reload this pagehttps://github.com/python/cpython/pull/99058/files
test_property.py https://github.com/python/cpython/pull/99058/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
2022-11-03-13-54-54.gh-issue-98963.Z3c6M5.rst https://github.com/python/cpython/pull/99058/files#diff-a6c4d9e46288466ea705c047cc532d0c7434c249a991e77fefee061ecd720f96
descrobject.c https://github.com/python/cpython/pull/99058/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
Lib/test/test_property.pyhttps://github.com/python/cpython/pull/99058/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
View file https://github.com/encukou/cpython/blob/66428bc68973e2edee5358170d707a57ae1330df/Lib/test/test_property.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99058/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99058/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
https://github.com/python/cpython/pull/99058/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
Misc/NEWS.d/next/Core and Builtins/2022-11-03-13-54-54.gh-issue-98963.Z3c6M5.rsthttps://github.com/python/cpython/pull/99058/files#diff-a6c4d9e46288466ea705c047cc532d0c7434c249a991e77fefee061ecd720f96
View file https://github.com/encukou/cpython/blob/66428bc68973e2edee5358170d707a57ae1330df/Misc/NEWS.d/next/Core%20and%20Builtins/2022-11-03-13-54-54.gh-issue-98963.Z3c6M5.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99058/{{ revealButtonHref }}
Objects/descrobject.chttps://github.com/python/cpython/pull/99058/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
View file https://github.com/encukou/cpython/blob/66428bc68973e2edee5358170d707a57ae1330df/Objects/descrobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99058/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99058/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
https://github.com/python/cpython/pull/99058/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.