René's URL Explorer Experiment


Title: GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add tests by twisteroidambassador · Pull Request #98607 · python/cpython · GitHub

Open Graph Title: GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add tests by twisteroidambassador · Pull Request #98607 · python/cpython

X Title: GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add tests by twisteroidambassador · Pull Request #98607 · python/cpython

Description: Issue: gh-86296

Open Graph Description: Issue: gh-86296

X Description: Issue: gh-86296

Opengraph URL: https://github.com/python/cpython/pull/98607

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fc413c1b-c7ea-5f4f-1f99-b7c6f3f0ec45
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7BC:103FB4:B7DCF9:F6A9E0:6A5B54E6
html-safe-nonceb239fddc24ed8fb51f843320f4911b64cbecf8d087e0934bdc75155a4d0c1f09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0JDOjEwM0ZCNDpCN0RDRjk6RjZBOUUwOjZBNUI1NEU2IiwidmlzaXRvcl9pZCI6Ijg0Nzc3MDEzNDczNzg2ODEwNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac957a8076aaf5afffd06b94ac577cdbf02311ad12605dc1bd49509736508370aa
hovercard-subject-tagpull_request:1097761080
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/98607/files
twitter:imagehttps://avatars.githubusercontent.com/u/12976218?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12976218?s=400&v=4
og:image:altIssue: gh-86296
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98607/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98607%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98607%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98607/files
Reloadhttps://github.com/python/cpython/pull/98607/files
Reloadhttps://github.com/python/cpython/pull/98607/files
Please reload this pagehttps://github.com/python/cpython/pull/98607/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98607/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
twisteroidambassadorhttps://github.com/twisteroidambassador
python:mainhttps://github.com/python/cpython/tree/main
twisteroidambassador:wait_for_specshttps://github.com/twisteroidambassador/cpython/tree/wait_for_specs
Conversation 11 https://github.com/python/cpython/pull/98607
Commits 7 https://github.com/python/cpython/pull/98607/commits
Checks 0 https://github.com/python/cpython/pull/98607/checks
Files changed https://github.com/python/cpython/pull/98607/files
Please reload this pagehttps://github.com/python/cpython/pull/98607/files
GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add tests https://github.com/python/cpython/pull/98607/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/98607/files
c1649a9 Add tests for wait_for() behavior when things happen simultaneously. twisteroidambassador Oct 24, 2022 https://github.com/python/cpython/pull/98607/commits/c1649a91552528228c95e95953aa7299c283de1c
992d843 Actually use do_cancel argument. twisteroidambassador Oct 24, 2022 https://github.com/python/cpython/pull/98607/commits/992d843a1470b357d9eeb736c8adc1b5a97d5590
55f5547 Ensure wait_for() does not swallow cancellation. twisteroidambassador Oct 25, 2022 https://github.com/python/cpython/pull/98607/commits/55f5547c704651423739449afb6ff8527d33b5d4
c834122 Remove tests for simultaneous *timeout* and *inner becoming done*. twisteroidambassador Oct 26, 2022 https://github.com/python/cpython/pull/98607/commits/c834122db8f08928b2e555801314f877c7bfa5d2
7660179 Spec change: when cancelled, always raise CancelledError. twisteroidambassador Oct 26, 2022 https://github.com/python/cpython/pull/98607/commits/7660179b100494d47efb316ca575c0af4ad04f1b
02a624c 📜🤖 Added by blurb_it. blurb-it[bot] Oct 26, 2022 https://github.com/python/cpython/pull/98607/commits/02a624c18db2b8dd249e7dd051992b75b8bc81f0
baf5d1b Merge branch 'main' into wait_for_specs kumaraditya303 Dec 14, 2022 https://github.com/python/cpython/pull/98607/commits/baf5d1bcc30e85c4f2a20ff9a4eff6e215b8a47d
Clear filters https://github.com/python/cpython/pull/98607/files
Please reload this pagehttps://github.com/python/cpython/pull/98607/files
Please reload this pagehttps://github.com/python/cpython/pull/98607/files
tasks.py https://github.com/python/cpython/pull/98607/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
test_waitfor.py https://github.com/python/cpython/pull/98607/files#diff-9b8c79985426f4ffe3ce61d6be9740077e3f73e144a582809fc6396af26198c3
2022-10-26-06-51-59.gh-issue-86296.l1MdXh.rst https://github.com/python/cpython/pull/98607/files#diff-c3f620e3287ced35701d05bda867b4be7fca8d3ff2f397de97e20008c4779e88
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L379
Lib/asyncio/tasks.pyhttps://github.com/python/cpython/pull/98607/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
View file https://github.com/twisteroidambassador/cpython/blob/baf5d1bcc30e85c4f2a20ff9a4eff6e215b8a47d/Lib/asyncio/tasks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98607/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98607/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/98607/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L380
Lib/test/test_asyncio/test_waitfor.pyhttps://github.com/python/cpython/pull/98607/files#diff-9b8c79985426f4ffe3ce61d6be9740077e3f73e144a582809fc6396af26198c3
View file https://github.com/twisteroidambassador/cpython/blob/baf5d1bcc30e85c4f2a20ff9a4eff6e215b8a47d/Lib/test/test_asyncio/test_waitfor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98607/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98607/files#diff-9b8c79985426f4ffe3ce61d6be9740077e3f73e144a582809fc6396af26198c3
Misc/NEWS.d/next/Library/2022-10-26-06-51-59.gh-issue-86296.l1MdXh.rsthttps://github.com/python/cpython/pull/98607/files#diff-c3f620e3287ced35701d05bda867b4be7fca8d3ff2f397de97e20008c4779e88
View file https://github.com/twisteroidambassador/cpython/blob/baf5d1bcc30e85c4f2a20ff9a4eff6e215b8a47d/Misc/NEWS.d/next/Library/2022-10-26-06-51-59.gh-issue-86296.l1MdXh.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98607/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.