René's URL Explorer Experiment


Title: GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add tests by twisteroidambassador · Pull Request #98607 · python/cpython · GitHub

Open Graph Title: GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add tests by twisteroidambassador · Pull Request #98607 · python/cpython

X Title: GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add tests by twisteroidambassador · Pull Request #98607 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: AsyncIO's wait_for can hide cancellation in a rare race condition #86296

X Description: Issue: AsyncIO's wait_for can hide cancellation in a rare race condition #86296

Opengraph URL: https://github.com/python/cpython/pull/98607

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:615686ed-41aa-4f8c-9647-a7008cc1efa2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF9A:24B261:1360290:19BC6F3:6A5AA79B
html-safe-nonceb9f14160b9ff8e3e6ee31f4e26d75ec1de7b7a781acff595b34ff9097267635e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjlBOjI0QjI2MToxMzYwMjkwOjE5QkM2RjM6NkE1QUE3OUIiLCJ2aXNpdG9yX2lkIjoiNDM2MTU4NjY3NzI0NjUwMjgxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac18c1830d9d1da2c4f13a9e4642c6aecd460eb7cf1d0a45b0e6d08fba0b2ba3b3
hovercard-subject-tagpull_request:1097761080
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/98607/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ae799b74c23e3f4728fb8b9ffbf6770078230ff17bc1f17d0a032c15c0eb5ec1/python/cpython/pull/98607
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ae799b74c23e3f4728fb8b9ffbf6770078230ff17bc1f17d0a032c15c0eb5ec1/python/cpython/pull/98607
og:image:altIssue: AsyncIO's wait_for can hide cancellation in a rare race condition #86296
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametwisteroidambassador
hostnamegithub.com
expected-hostnamegithub.com
None17a57ee6ab03686731c491fccb57e6a97c066a29d7cdf1a7d83c46f5c56684fc
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5cb870aa6b86b87be75e23ca7caec54726a25af9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98607#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98607
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98607
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98607
Reloadhttps://github.com/python/cpython/pull/98607
Reloadhttps://github.com/python/cpython/pull/98607
Please reload this pagehttps://github.com/python/cpython/pull/98607
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98607
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
twisteroidambassadorhttps://github.com/twisteroidambassador
python:mainhttps://github.com/python/cpython/tree/main
twisteroidambassador:wait_for_specshttps://github.com/twisteroidambassador/cpython/tree/wait_for_specs
Conversationhttps://github.com/python/cpython/pull/98607
Commits7 (7)https://github.com/python/cpython/pull/98607/commits
Checkshttps://github.com/python/cpython/pull/98607/checks
Files changedhttps://github.com/python/cpython/pull/98607/files
GH-86296: Fix for asyncio.wait_for() swallowing cancellation, and add testshttps://github.com/python/cpython/pull/98607#top
twisteroidambassadorhttps://github.com/twisteroidambassador
python:mainhttps://github.com/python/cpython/tree/main
twisteroidambassador:wait_for_specshttps://github.com/twisteroidambassador/cpython/tree/wait_for_specs
https://github.com/twisteroidambassador
twisteroidambassadorhttps://github.com/twisteroidambassador
Oct 24, 2022https://github.com/python/cpython/pull/98607#issue-1421156567
Please reload this pagehttps://github.com/python/cpython/pull/98607
AsyncIO's wait_for can hide cancellation in a rare race condition #86296https://github.com/python/cpython/issues/86296
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/twisteroidambassador
Add tests for wait_for() behavior when things happen simultaneously.https://github.com/python/cpython/pull/98607/commits/c1649a91552528228c95e95953aa7299c283de1c
c1649a9https://github.com/python/cpython/pull/98607/commits/c1649a91552528228c95e95953aa7299c283de1c
https://github.com/twisteroidambassador
twisteroidambassadorhttps://github.com/twisteroidambassador
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/c5a9d3f67fc4b62543ddf6bc7b9ed392c2a81ec3/.github/CODEOWNERS#L11
October 24, 2022 17:13https://github.com/python/cpython/pull/98607#event-7655987703
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Oct 24, 2022https://github.com/python/cpython/pull/98607#event-7655987984
https://github.com/twisteroidambassador
Actually use do_cancel argument.https://github.com/python/cpython/pull/98607/commits/992d843a1470b357d9eeb736c8adc1b5a97d5590
992d843https://github.com/python/cpython/pull/98607/commits/992d843a1470b357d9eeb736c8adc1b5a97d5590
https://github.com/twisteroidambassador
twisteroidambassadorhttps://github.com/twisteroidambassador
Oct 24, 2022https://github.com/python/cpython/pull/98607#issuecomment-1289363134
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/twisteroidambassador
Ensure wait_for() does not swallow cancellation.https://github.com/python/cpython/pull/98607/commits/55f5547c704651423739449afb6ff8527d33b5d4
55f5547https://github.com/python/cpython/pull/98607/commits/55f5547c704651423739449afb6ff8527d33b5d4
https://github.com/twisteroidambassador
twisteroidambassadorhttps://github.com/twisteroidambassador
Oct 25, 2022https://github.com/python/cpython/pull/98607#event-7660203773
https://github.com/twisteroidambassador
twisteroidambassadorhttps://github.com/twisteroidambassador
Oct 25, 2022https://github.com/python/cpython/pull/98607#issuecomment-1290040113
#86296https://github.com/python/cpython/issues/86296
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 25, 2022 https://github.com/python/cpython/pull/98607#ref-pullrequest-1418306501
GH-96764: rewrite asyncio.wait_for to use asyncio.timeout #98518 https://github.com/python/cpython/pull/98518
twisteroidambassadorhttps://github.com/twisteroidambassador
October 26, 2022 13:42https://github.com/python/cpython/pull/98607#commits-pushed-c834122
https://github.com/twisteroidambassador
Remove tests for simultaneous *timeout* and *inner becoming done*.https://github.com/python/cpython/pull/98607/commits/c834122db8f08928b2e555801314f877c7bfa5d2
c834122https://github.com/python/cpython/pull/98607/commits/c834122db8f08928b2e555801314f877c7bfa5d2
https://github.com/twisteroidambassador
Spec change: when cancelled, always raise CancelledError.https://github.com/python/cpython/pull/98607/commits/7660179b100494d47efb316ca575c0af4ad04f1b
7660179https://github.com/python/cpython/pull/98607/commits/7660179b100494d47efb316ca575c0af4ad04f1b
https://github.com/twisteroidambassador
twisteroidambassadorhttps://github.com/twisteroidambassador
Oct 26, 2022https://github.com/python/cpython/pull/98607#issuecomment-1291563873
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/98607/commits/02a624c18db2b8dd249e7dd051992b75b8bc81f0
02a624chttps://github.com/python/cpython/pull/98607/commits/02a624c18db2b8dd249e7dd051992b75b8bc81f0
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 30, 2022https://github.com/python/cpython/pull/98607#issuecomment-1332721866
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/robsdedude
robsdedudehttps://github.com/robsdedude
Dec 14, 2022https://github.com/python/cpython/pull/98607#issuecomment-1350811242
Please reload this pagehttps://github.com/python/cpython/pull/98607
bpo-42130: Fix swallowing of cancellation by wait_for #26097https://github.com/python/cpython/pull/26097
bpo-42130: Fix for explicit suppressing of cancellations in wait_for() #28149https://github.com/python/cpython/pull/28149
GH-96764: rewrite asyncio.wait_for to use asyncio.timeout #98518https://github.com/python/cpython/pull/98518
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Dec 14, 2022https://github.com/python/cpython/pull/98607#event-8035652111
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Dec 14, 2022 https://github.com/python/cpython/pull/98607#ref-issue-1199045827
AsyncIO's wait_for can hide cancellation in a rare race condition #86296 https://github.com/python/cpython/issues/86296
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
kumaraditya303https://github.com/kumaraditya303
December 14, 2022 10:39https://github.com/python/cpython/pull/98607#event-8035653310
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Dec 14, 2022https://github.com/python/cpython/pull/98607#event-8035657139
https://github.com/kumaraditya303
Merge branch 'main' into wait_for_specshttps://github.com/python/cpython/pull/98607/commits/baf5d1bcc30e85c4f2a20ff9a4eff6e215b8a47d
baf5d1bhttps://github.com/python/cpython/pull/98607/commits/baf5d1bcc30e85c4f2a20ff9a4eff6e215b8a47d
https://github.com/apps/netlify
netlifyhttps://github.com/apps/netlify
Dec 14, 2022https://github.com/python/cpython/pull/98607#issuecomment-1350947042
Please reload this pagehttps://github.com/python/cpython/pull/98607
02a624chttps://github.com/python/cpython/commit/02a624c18db2b8dd249e7dd051992b75b8bc81f0
https://app.netlify.com/sites/python-cpython-preview/deploys/6399ad3ee3d81200085d9b09https://app.netlify.com/sites/python-cpython-preview/deploys/6399ad3ee3d81200085d9b09
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Mar 14, 2023https://github.com/python/cpython/pull/98607#issuecomment-1467658723
Please reload this pagehttps://github.com/python/cpython/pull/98607
#96764https://github.com/python/cpython/issues/96764
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/robsdedude
robsdedudehttps://github.com/robsdedude
Mar 14, 2023https://github.com/python/cpython/pull/98607#issuecomment-1468158417
@kumaraditya303https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 14, 2023https://github.com/python/cpython/pull/98607#issuecomment-1468362114
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Mar 14, 2023https://github.com/python/cpython/pull/98607#issuecomment-1468416695
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 14, 2023https://github.com/python/cpython/pull/98607#issuecomment-1468518366
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 14, 2023https://github.com/python/cpython/pull/98607#event-8746569702
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98607
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/98607
https://github.com/twisteroidambassador
https://github.com/gvanrossum
https://github.com/robsdedude
https://github.com/kumaraditya303
https://github.com/bedevere-bot
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.