René's URL Explorer Experiment


Title: GH-79033: Fix asyncio.Server.wait_closed() by gvanrossum · Pull Request #98582 · python/cpython · GitHub

Open Graph Title: GH-79033: Fix asyncio.Server.wait_closed() by gvanrossum · Pull Request #98582 · python/cpython

X Title: GH-79033: Fix asyncio.Server.wait_closed() by gvanrossum · Pull Request #98582 · python/cpython

Description: wait_closed() was a no-op when used as recommended (after close()). I had to debug one test (test__sock_sendfile_native_failure) -- the cleanup sequence for the test fixture was botched. Hopefully that's not a portend of problems in user code -- this has never worked so people may well be doing this wrong. :-( Issue: gh-79033

Open Graph Description: wait_closed() was a no-op when used as recommended (after close()). I had to debug one test (test__sock_sendfile_native_failure) -- the cleanup sequence for the test fixture was botched. Hopefully ...

X Description: wait_closed() was a no-op when used as recommended (after close()). I had to debug one test (test__sock_sendfile_native_failure) -- the cleanup sequence for the test fixture was botched. Hopefully ...

Opengraph URL: https://github.com/python/cpython/pull/98582

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:732da505-302c-635c-8ffc-4087e9f0c221
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3C2:1B7E6F:1FE1F12:2BC835A:696AB5B8
html-safe-nonceb1feb97f3df1e1463bff8656eca6650582d3525fa1ab474d2f36be83626ad6bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0MyOjFCN0U2RjoxRkUxRjEyOjJCQzgzNUE6Njk2QUI1QjgiLCJ2aXNpdG9yX2lkIjoiODU5OTQzNjkzODMyODA2MTM2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4c5e69b8d33ccd9696b9a7ee40eb065d79d119c4545e5a30ce1d71a7143f1b82
hovercard-subject-tagpull_request:1096852589
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/98582/files
twitter:imagehttps://avatars.githubusercontent.com/u/2894642?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2894642?s=400&v=4
og:image:altwait_closed() was a no-op when used as recommended (after close()). I had to debug one test (test__sock_sendfile_native_failure) -- the cleanup sequence for the test fixture was botched. Hopefully ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98582/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98582%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98582%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98582/files
Reloadhttps://github.com/python/cpython/pull/98582/files
Reloadhttps://github.com/python/cpython/pull/98582/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98582/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/98582/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
gvanrossum:fix-server-wait-closedhttps://github.com/gvanrossum/cpython/tree/fix-server-wait-closed
Conversation 6 https://github.com/python/cpython/pull/98582
Commits 4 https://github.com/python/cpython/pull/98582/commits
Checks 0 https://github.com/python/cpython/pull/98582/checks
Files changed https://github.com/python/cpython/pull/98582/files
Please reload this pagehttps://github.com/python/cpython/pull/98582/files
GH-79033: Fix asyncio.Server.wait_closed() https://github.com/python/cpython/pull/98582/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/98582/files
d2eca95 Fix asyncio.Server.wait_closed() gvanrossum Oct 24, 2022 https://github.com/python/cpython/pull/98582/commits/d2eca9506ef2627108637be14e60295cc2088bc0
496566c Merge branch 'main' into fix-server-wait-closed gvanrossum Nov 22, 2022 https://github.com/python/cpython/pull/98582/commits/496566c4ffb6438addd96a9c548dc157b9afe231
a9aebfc 📜🤖 Added by blurb_it. blurb-it[bot] Nov 22, 2022 https://github.com/python/cpython/pull/98582/commits/a9aebfccc444630f4001a7c44b0bb5c641fdfe61
0b4057a Add a test (most of it contributed by Kumar) gvanrossum Nov 23, 2022 https://github.com/python/cpython/pull/98582/commits/0b4057a2ea66bd92e74a33f93d88a820571fe86b
Clear filters https://github.com/python/cpython/pull/98582/files
Please reload this pagehttps://github.com/python/cpython/pull/98582/files
Please reload this pagehttps://github.com/python/cpython/pull/98582/files
base_events.py https://github.com/python/cpython/pull/98582/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
test_base_events.py https://github.com/python/cpython/pull/98582/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
test_server.py https://github.com/python/cpython/pull/98582/files#diff-4fbe1407e942e75e35b9d64f415a13065b5cb1f36eab8d3ae6e98fb97a339200
2022-11-22-19-31-26.gh-issue-79033.MW6kHq.rst https://github.com/python/cpython/pull/98582/files#diff-6984d7db8a0d22a890a8e7f864a6bd3d9781fa305f6b0b562a2037de1ed26ae2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L369
Lib/asyncio/base_events.pyhttps://github.com/python/cpython/pull/98582/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
View file https://github.com/gvanrossum/cpython/blob/0b4057a2ea66bd92e74a33f93d88a820571fe86b/Lib/asyncio/base_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98582/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98582/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
https://github.com/python/cpython/pull/98582/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/test/test_asyncio/test_base_events.pyhttps://github.com/python/cpython/pull/98582/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
View file https://github.com/gvanrossum/cpython/blob/0b4057a2ea66bd92e74a33f93d88a820571fe86b/Lib/test/test_asyncio/test_base_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98582/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98582/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
https://github.com/python/cpython/pull/98582/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/test/test_asyncio/test_server.pyhttps://github.com/python/cpython/pull/98582/files#diff-4fbe1407e942e75e35b9d64f415a13065b5cb1f36eab8d3ae6e98fb97a339200
View file https://github.com/gvanrossum/cpython/blob/0b4057a2ea66bd92e74a33f93d88a820571fe86b/Lib/test/test_asyncio/test_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98582/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98582/files#diff-4fbe1407e942e75e35b9d64f415a13065b5cb1f36eab8d3ae6e98fb97a339200
https://github.com/python/cpython/pull/98582/files#diff-4fbe1407e942e75e35b9d64f415a13065b5cb1f36eab8d3ae6e98fb97a339200
Misc/NEWS.d/next/Library/2022-11-22-19-31-26.gh-issue-79033.MW6kHq.rsthttps://github.com/python/cpython/pull/98582/files#diff-6984d7db8a0d22a890a8e7f864a6bd3d9781fa305f6b0b562a2037de1ed26ae2
View file https://github.com/gvanrossum/cpython/blob/0b4057a2ea66bd92e74a33f93d88a820571fe86b/Misc/NEWS.d/next/Library/2022-11-22-19-31-26.gh-issue-79033.MW6kHq.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98582/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.