René's URL Explorer Experiment


Title: GH-96764: rewrite `asyncio.wait_for` to use `asyncio.timeout` by kumaraditya303 · Pull Request #98518 · python/cpython · GitHub

Open Graph Title: GH-96764: rewrite `asyncio.wait_for` to use `asyncio.timeout` by kumaraditya303 · Pull Request #98518 · python/cpython

X Title: GH-96764: rewrite `asyncio.wait_for` to use `asyncio.timeout` by kumaraditya303 · Pull Request #98518 · python/cpython

Description: This PR changes asyncio.wait_for to use asyncio.timeout as its underlying implementation. It simplifies the code and makes it easy to understand the cancellation semantics as both asyncio.timeout and asyncio.wait_for behaves similarly. Fixes #86296 Fixes #81839 Fixes #96764 Issue: gh-96764

Open Graph Description: This PR changes asyncio.wait_for to use asyncio.timeout as its underlying implementation. It simplifies the code and makes it easy to understand the cancellation semantics as both asyncio.timeout a...

X Description: This PR changes asyncio.wait_for to use asyncio.timeout as its underlying implementation. It simplifies the code and makes it easy to understand the cancellation semantics as both asyncio.timeout a...

Opengraph URL: https://github.com/python/cpython/pull/98518

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2e681ced-ded9-f8ad-3fe8-9890f8439c88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85EA:2824AF:2AB87C:3934BE:6A5B20DD
html-safe-nonce70fed192a9cf93307ec30bf71b36720a180eb447bd69ba83ac03e534de08fccb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUVBOjI4MjRBRjoyQUI4N0M6MzkzNEJFOjZBNUIyMEREIiwidmlzaXRvcl9pZCI6IjM2NTkzODM2NDQ4ODY4NjgxODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac468b9fb2afd5d8cbf84733beb263745206ed52e5332ce9cd974cf7cf02d4363e
hovercard-subject-tagpull_request:1095298727
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/98518/files
twitter:imagehttps://avatars.githubusercontent.com/u/59607654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/59607654?s=400&v=4
og:image:altThis PR changes asyncio.wait_for to use asyncio.timeout as its underlying implementation. It simplifies the code and makes it easy to understand the cancellation semantics as both asyncio.timeout a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98518/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98518%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98518%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98518/files
Reloadhttps://github.com/python/cpython/pull/98518/files
Reloadhttps://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
kumaraditya303:waitforhttps://github.com/kumaraditya303/cpython/tree/waitfor
Conversation 61 https://github.com/python/cpython/pull/98518
Commits 29 https://github.com/python/cpython/pull/98518/commits
Checks 0 https://github.com/python/cpython/pull/98518/checks
Files changed 4 https://github.com/python/cpython/pull/98518/files
GH-96764: rewrite asyncio.wait_for to use asyncio.timeout https://github.com/python/cpython/pull/98518/files#top
Show all changes 29 commits https://github.com/python/cpython/pull/98518/files
487eac1 rewrite wait_for to use timeouts.timeout kumaraditya303 Sep 12, 2022 https://github.com/python/cpython/pull/98518/commits/487eac18d204f24ff37b3bebe21f8c717d11cc1e
794cb3a skip one test kumaraditya303 Oct 21, 2022 https://github.com/python/cpython/pull/98518/commits/794cb3adab23005ef2ed9a1fb95d4a1e822a2264
13ab78f fix test as wait_for no longer creates kumaraditya303 Oct 21, 2022 https://github.com/python/cpython/pull/98518/commits/13ab78fb85bcb4f570a9729a9ee76cd7786ebab7
1eb0053 remove outdated tests kumaraditya303 Oct 21, 2022 https://github.com/python/cpython/pull/98518/commits/1eb005362bc16e1e6cffa41e9197b6020605954a
c704996 fix future test kumaraditya303 Oct 22, 2022 https://github.com/python/cpython/pull/98518/commits/c7049965c6724144ae9b5c1e82f930b4fd8a496d
bdaed9d more tests kumaraditya303 Oct 22, 2022 https://github.com/python/cpython/pull/98518/commits/bdaed9d0024cc768fe8d2fbe9f4940db1ae28c7e
8ec6b37 fix whitespaces and comment kumaraditya303 Oct 22, 2022 https://github.com/python/cpython/pull/98518/commits/8ec6b37fd2aa94a4ac5fa9ef7995e436b5d030b0
b711aa1 📜🤖 Added by blurb_it. blurb-it[bot] Oct 22, 2022 https://github.com/python/cpython/pull/98518/commits/b711aa15c6c9d5a78d8bb2d38fb15f6a4b3550c9
69c03b1 remove None special case kumaraditya303 Oct 22, 2022 https://github.com/python/cpython/pull/98518/commits/69c03b1d9e4d7a848982d14b4368829d82cb782c
92df33b Update Misc/NEWS.d/next/Library/2022-10-22-09-26-43.gh-issue-96764.Dh… kumaraditya303 Oct 23, 2022 https://github.com/python/cpython/pull/98518/commits/92df33b2f6bd8dc2e905a27e65c44407908aff37
0290362 fix typo kumaraditya303 Oct 24, 2022 https://github.com/python/cpython/pull/98518/commits/0290362ed203e43a541d4a3a4fefe95617b96421
4d3e9a3 remove a test kumaraditya303 Oct 26, 2022 https://github.com/python/cpython/pull/98518/commits/4d3e9a34571fd1a5c42efc8b55f5656bfa0d8c07
5fece55 fix comment kumaraditya303 Nov 30, 2022 https://github.com/python/cpython/pull/98518/commits/5fece55bb90b3d6e46b5d27d60bb31cbf5e5b9fc
e7595a2 Merge branch 'main' of https://github.com/python/cpython into waitfor kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/e7595a29454e401995a01bfdf5d26f663cc6eca5
9b0ef93 code review kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/9b0ef93407dd90359c1fc081e472705efc02f0f0
c98ea70 add shield tests kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/c98ea70ae9309154a7b2684bce82d807ca0ab8a9
8b54ce5 more comments kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/8b54ce5aed21a178d4cec218e65055ce530b7de1
6d39219 whitespace kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/6d392193ad6d6fdb17d4def66961a0b689ccbc19
d7efdcb typo kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/d7efdcb55af61f25a654a6dd009b0ac1f7a8884f
27cfdf9 formatting kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/27cfdf94eaa6500f108553d14682337fdb12e153
979f07f improve test kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/979f07f4a1bdde059a153ac3d320c92c8211aa62
7a7082c more comments kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/7a7082c31ea3fb9032d59b2b5b1dc895acb393d5
1239246 Update Lib/test/test_asyncio/test_waitfor.py kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/1239246fee22c11105c7d2a4c51c52e64d49e6b3
f0b5480 add back tasks.py changes, somehow got lost kumaraditya303 Feb 12, 2023 https://github.com/python/cpython/pull/98518/commits/f0b54809ab1d4c8251f9e3302f10b7d929850b5a
355f2df comments++ kumaraditya303 Feb 16, 2023 https://github.com/python/cpython/pull/98518/commits/355f2df0e16e87fbe96840ee58f6cc68fa91a25e
49d0ee4 fix typo kumaraditya303 Feb 16, 2023 https://github.com/python/cpython/pull/98518/commits/49d0ee4c8840781491f4daa42b1aceeb3feb8667
549b03f remove wrong comment kumaraditya303 Feb 16, 2023 https://github.com/python/cpython/pull/98518/commits/549b03f70bf5c696844e0e2b0acc2e899ce743c3
56e6038 add code as explanantion kumaraditya303 Feb 16, 2023 https://github.com/python/cpython/pull/98518/commits/56e60383397e176d814ed7536114d6e27e969a2a
1a912f4 Update Lib/asyncio/tasks.py kumaraditya303 Feb 16, 2023 https://github.com/python/cpython/pull/98518/commits/1a912f48bb60e9b8c55e1bdf73310a439cb31da2
Clear filters https://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
tasks.py https://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
test_futures2.py https://github.com/python/cpython/pull/98518/files#diff-f2f40e1c2d0b5f6342cdd3f8aac482cd8b70b01b607b4dddea5d65b549af00c2
test_waitfor.py https://github.com/python/cpython/pull/98518/files#diff-9b8c79985426f4ffe3ce61d6be9740077e3f73e144a582809fc6396af26198c3
2022-10-22-09-26-43.gh-issue-96764.Dh9Y5L.rst https://github.com/python/cpython/pull/98518/files#diff-eedd753f1d5f6e396ca04db248764e7b93de3d1c10a680b426689cea69ec93ec
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L379
Lib/asyncio/tasks.pyhttps://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
View file https://github.com/kumaraditya303/cpython/blob/1a912f48bb60e9b8c55e1bdf73310a439cb31da2/Lib/asyncio/tasks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98518/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
https://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/98518/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L380
Lib/test/test_asyncio/test_futures2.pyhttps://github.com/python/cpython/pull/98518/files#diff-f2f40e1c2d0b5f6342cdd3f8aac482cd8b70b01b607b4dddea5d65b549af00c2
View file https://github.com/kumaraditya303/cpython/blob/1a912f48bb60e9b8c55e1bdf73310a439cb31da2/Lib/test/test_asyncio/test_futures2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98518/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98518/files#diff-f2f40e1c2d0b5f6342cdd3f8aac482cd8b70b01b607b4dddea5d65b549af00c2
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
https://github.com/python/cpython/pull/98518/files#diff-f2f40e1c2d0b5f6342cdd3f8aac482cd8b70b01b607b4dddea5d65b549af00c2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L380
Lib/test/test_asyncio/test_waitfor.pyhttps://github.com/python/cpython/pull/98518/files#diff-9b8c79985426f4ffe3ce61d6be9740077e3f73e144a582809fc6396af26198c3
View file https://github.com/kumaraditya303/cpython/blob/1a912f48bb60e9b8c55e1bdf73310a439cb31da2/Lib/test/test_asyncio/test_waitfor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98518/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98518/files#diff-9b8c79985426f4ffe3ce61d6be9740077e3f73e144a582809fc6396af26198c3
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
https://github.com/python/cpython/pull/98518/files#diff-9b8c79985426f4ffe3ce61d6be9740077e3f73e144a582809fc6396af26198c3
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Please reload this pagehttps://github.com/python/cpython/pull/98518/files
Misc/NEWS.d/next/Library/2022-10-22-09-26-43.gh-issue-96764.Dh9Y5L.rsthttps://github.com/python/cpython/pull/98518/files#diff-eedd753f1d5f6e396ca04db248764e7b93de3d1c10a680b426689cea69ec93ec
View file https://github.com/kumaraditya303/cpython/blob/1a912f48bb60e9b8c55e1bdf73310a439cb31da2/Misc/NEWS.d/next/Library/2022-10-22-09-26-43.gh-issue-96764.Dh9Y5L.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98518/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.