René's URL Explorer Experiment


Title: bpo-33234 Improve list() pre-sizing for inputs with known lengths (no __length_hint__) by pablogsal · Pull Request #9846 · python/cpython · GitHub

Open Graph Title: bpo-33234 Improve list() pre-sizing for inputs with known lengths (no __length_hint__) by pablogsal · Pull Request #9846 · python/cpython

X Title: bpo-33234 Improve list() pre-sizing for inputs with known lengths (no __length_hint__) by pablogsal · Pull Request #9846 · python/cpython

Description: This is a version of #6493 that only preallocates the list when __len__ is available to reduce memory overallocation and possible performance hit on big iterables. This are the L1 and L2 cache miss...

Open Graph Description: This is a version of #6493 that only preallocates the list when __len__ is available to reduce memory overallocation and possible performance hit on big iterables. This are the L1 and L2 cache miss...

X Description: This is a version of #6493 that only preallocates the list when __len__ is available to reduce memory overallocation and possible performance hit on big iterables. This are the L1 and L2 cache miss...

Opengraph URL: https://github.com/python/cpython/pull/9846

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a818e193-6fc0-1256-e418-624ac908ef82
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1EA:3CA8DF:C3857E:FF33C7:696B5F82
html-safe-nonce6c103e29465cf792f7280076125a207e0c3a5305fecea47714cebe207031306f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUVBOjNDQThERjpDMzg1N0U6RkYzM0M3OjY5NkI1RjgyIiwidmlzaXRvcl9pZCI6IjE1NTczMDU2NTIzOTAwOTI2NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfb54bc87826ec6369b9a651654f875a733915bd1e7155ed4ab4eb16e37568527
hovercard-subject-tagpull_request:222662280
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/9846/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/82c8f47094a86f76f42798ca2916a54dbffa5d1ed44f463c5bd40a48777f14c7/python/cpython/pull/9846
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/82c8f47094a86f76f42798ca2916a54dbffa5d1ed44f463c5bd40a48777f14c7/python/cpython/pull/9846
og:image:altThis is a version of #6493 that only preallocates the list when __len__ is available to reduce memory overallocation and possible performance hit on big iterables. This are the L1 and L2 cache miss...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepablogsal
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9846#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9846
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9846
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9846
Reloadhttps://github.com/python/cpython/pull/9846
Reloadhttps://github.com/python/cpython/pull/9846
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9846
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/9846
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/9846#issue-comment-box
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
pablogsal:bpo33234-2https://github.com/pablogsal/cpython/tree/bpo33234-2
bpo-33234 Improve list() pre-sizing for inputs with known lengths (no __length_hint__) https://github.com/python/cpython/pull/9846#top
pablogsalhttps://github.com/pablogsal
python:masterhttps://github.com/python/cpython/tree/master
pablogsal:bpo33234-2https://github.com/pablogsal/cpython/tree/bpo33234-2
Conversation 39 https://github.com/python/cpython/pull/9846
Commits 10 https://github.com/python/cpython/pull/9846/commits
Checks 0 https://github.com/python/cpython/pull/9846/checks
Files changed https://github.com/python/cpython/pull/9846/files
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 13, 2018https://github.com/python/cpython/pull/9846#issue-369820750
Please reload this pagehttps://github.com/python/cpython/pull/9846
#6493https://github.com/python/cpython/pull/6493
https://bugs.python.org/issue33234https://bugs.python.org/issue33234
Please reload this pagehttps://github.com/python/cpython/pull/9846
pablogsalhttps://github.com/pablogsal
April 17, 2018 21:51https://github.com/python/cpython/pull/9846#commits-pushed-7602879
https://github.com/pablogsal
Improve list() pre-sizing for inputs with known lengthshttps://github.com/python/cpython/pull/9846/commits/76028798d0ddef4e6d88c0313db691592bcdd58a
7602879https://github.com/python/cpython/pull/9846/commits/76028798d0ddef4e6d88c0313db691592bcdd58a
https://github.com/pablogsal
Preallocate only when __len__ is available to avoid loss of performan…https://github.com/python/cpython/pull/9846/commits/39a87576b5a3075ec5e0a512065901b436bf8e54
39a8757https://github.com/python/cpython/pull/9846/commits/39a87576b5a3075ec5e0a512065901b436bf8e54
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 13, 2018https://github.com/python/cpython/pull/9846#event-1902245122
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 13, 2018https://github.com/python/cpython/pull/9846#event-1902245124
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
rhettingerhttps://github.com/rhettinger
serhiy-storchakahttps://github.com/serhiy-storchaka
vstinnerhttps://github.com/vstinner
October 13, 2018 17:01https://github.com/python/cpython/pull/9846#event-1902245135
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 15, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-164892372
View reviewed changes https://github.com/python/cpython/pull/9846/files/39a87576b5a3075ec5e0a512065901b436bf8e54
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/9846#pullrequestreview-164892372
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
Misc/NEWS.d/next/Core and Builtins/2018-04-17-01-24-51.bpo-33234.l9IDtp.rsthttps://github.com/python/cpython/pull/9846/files/39a87576b5a3075ec5e0a512065901b436bf8e54#diff-f69f0dc0516d28a1acd579c1ac914a1044bffcc69ab8387a9dc5ee1c111b7749
vstinnerhttps://github.com/vstinner
Oct 15, 2018https://github.com/python/cpython/pull/9846#discussion_r225313835
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
Misc/NEWS.d/next/Core and Builtins/2018-04-17-01-24-51.bpo-33234.l9IDtp.rsthttps://github.com/python/cpython/pull/9846/files/39a87576b5a3075ec5e0a512065901b436bf8e54#diff-f69f0dc0516d28a1acd579c1ac914a1044bffcc69ab8387a9dc5ee1c111b7749
vstinnerhttps://github.com/vstinner
Oct 15, 2018https://github.com/python/cpython/pull/9846#discussion_r225313962
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/39a87576b5a3075ec5e0a512065901b436bf8e54#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
vstinnerhttps://github.com/vstinner
Oct 15, 2018https://github.com/python/cpython/pull/9846#discussion_r225314645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
Fix NEWS entry and correct stylehttps://github.com/python/cpython/pull/9846/commits/ab450b3d5a453f36a4988d83b391a79bfbfa5a61
ab450b3https://github.com/python/cpython/pull/9846/commits/ab450b3d5a453f36a4988d83b391a79bfbfa5a61
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 15, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-164911559
View reviewed changes https://github.com/python/cpython/pull/9846/files/ab450b3d5a453f36a4988d83b391a79bfbfa5a61
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/9846#pullrequestreview-164911559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 15, 2018https://github.com/python/cpython/pull/9846#issuecomment-430027887
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 15, 2018https://github.com/python/cpython/pull/9846#issuecomment-430033781
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 23, 2018https://github.com/python/cpython/pull/9846#issuecomment-432187442
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 23, 2018https://github.com/python/cpython/pull/9846#issuecomment-432220026
Please reload this pagehttps://github.com/python/cpython/pull/9846
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 23, 2018https://github.com/python/cpython/pull/9846#issuecomment-432223459
Please reload this pagehttps://github.com/python/cpython/pull/9846
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Oct 23, 2018https://github.com/python/cpython/pull/9846#event-1920310590
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 23, 2018https://github.com/python/cpython/pull/9846#issuecomment-432231774
@methanehttps://github.com/methane
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 23, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-167396928
View reviewed changes https://github.com/python/cpython/pull/9846/files/ab450b3d5a453f36a4988d83b391a79bfbfa5a61
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/ab450b3d5a453f36a4988d83b391a79bfbfa5a61#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
vstinnerhttps://github.com/vstinner
Oct 23, 2018https://github.com/python/cpython/pull/9846#discussion_r227373110
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
pablogsalhttps://github.com/pablogsal
Oct 23, 2018https://github.com/python/cpython/pull/9846#discussion_r227376580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 23, 2018https://github.com/python/cpython/pull/9846#issuecomment-432235688
Please reload this pagehttps://github.com/python/cpython/pull/9846
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
Use _PyObject_HasLen to check if the object has lenght to avoid overheadhttps://github.com/python/cpython/pull/9846/commits/717ca6732b8a15b24542648bdba56812b5ef6867
717ca67https://github.com/python/cpython/pull/9846/commits/717ca6732b8a15b24542648bdba56812b5ef6867
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 23, 2018https://github.com/python/cpython/pull/9846#issuecomment-432340754
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 23, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-167561563
View reviewed changes https://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 23, 2018https://github.com/python/cpython/pull/9846#discussion_r227504242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 23, 2018https://github.com/python/cpython/pull/9846#discussion_r227506773
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 23, 2018https://github.com/python/cpython/pull/9846#discussion_r227510433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
Simplify implementation and don't capture all expections on errorhttps://github.com/python/cpython/pull/9846/commits/b67844271da9a4cb3046820be74bf6e0c7b46927
b678442https://github.com/python/cpython/pull/9846/commits/b67844271da9a4cb3046820be74bf6e0c7b46927
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 23, 2018https://github.com/python/cpython/pull/9846#issuecomment-432399920
Please reload this pagehttps://github.com/python/cpython/pull/9846
b678442https://github.com/python/cpython/commit/b67844271da9a4cb3046820be74bf6e0c7b46927
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/methane
methanehttps://github.com/methane
Oct 25, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-168321950
View reviewed changes https://github.com/python/cpython/pull/9846/files/b67844271da9a4cb3046820be74bf6e0c7b46927
methanehttps://github.com/methane
https://github.com/python/cpython/pull/9846#pullrequestreview-168321950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 25, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-168325394
View reviewed changes https://github.com/python/cpython/pull/9846/files/b67844271da9a4cb3046820be74bf6e0c7b46927
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/9846#pullrequestreview-168325394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/b67844271da9a4cb3046820be74bf6e0c7b46927#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
vstinnerhttps://github.com/vstinner
Oct 25, 2018https://github.com/python/cpython/pull/9846#discussion_r228129847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
pablogsalhttps://github.com/pablogsal
October 25, 2018 22:36https://github.com/python/cpython/pull/9846#commits-pushed-b40bd62
https://github.com/pablogsal
Add assert and fix formattinghttps://github.com/python/cpython/pull/9846/commits/b40bd623c5536dd90a4cc8ebbc72fc5ff0889ca3
b40bd62https://github.com/python/cpython/pull/9846/commits/b40bd623c5536dd90a4cc8ebbc72fc5ff0889ca3
https://github.com/pablogsal
Remove uneeded test modificationhttps://github.com/python/cpython/pull/9846/commits/38374862963005541cb0af9b7a9beb2c7a98b467
3837486https://github.com/python/cpython/pull/9846/commits/38374862963005541cb0af9b7a9beb2c7a98b467
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 26, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-168673296
View reviewed changes https://github.com/python/cpython/pull/9846/files/38374862963005541cb0af9b7a9beb2c7a98b467
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/38374862963005541cb0af9b7a9beb2c7a98b467#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 26, 2018https://github.com/python/cpython/pull/9846#discussion_r228406952
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
pablogsalhttps://github.com/pablogsal
Oct 26, 2018https://github.com/python/cpython/pull/9846#discussion_r228461304
Please reload this pagehttps://github.com/python/cpython/pull/9846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 27, 2018https://github.com/python/cpython/pull/9846#discussion_r228718987
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 27, 2018https://github.com/python/cpython/pull/9846#discussion_r228719394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
pablogsalhttps://github.com/pablogsal
Oct 27, 2018https://github.com/python/cpython/pull/9846#discussion_r228720132
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 28, 2018https://github.com/python/cpython/pull/9846#discussion_r228735288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
pablogsalhttps://github.com/pablogsal
Oct 28, 2018https://github.com/python/cpython/pull/9846#discussion_r228752773
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/717ca6732b8a15b24542648bdba56812b5ef6867#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
force-pushedhttps://github.com/python/cpython/compare/d99098c70a109e9c98c6dff18f00f58421db94c1..38374862963005541cb0af9b7a9beb2c7a98b467
d99098chttps://github.com/python/cpython/commit/d99098c70a109e9c98c6dff18f00f58421db94c1
3837486https://github.com/python/cpython/commit/38374862963005541cb0af9b7a9beb2c7a98b467
Compare https://github.com/python/cpython/compare/d99098c70a109e9c98c6dff18f00f58421db94c1..38374862963005541cb0af9b7a9beb2c7a98b467
October 26, 2018 09:30https://github.com/python/cpython/pull/9846#event-1928348453
https://github.com/pablogsal
Don't preallocate if list is modified when calling PyObject_Sizehttps://github.com/python/cpython/pull/9846/commits/b6ff7ce618bc958a4be4cf29aa98a622cf4cebea
b6ff7cehttps://github.com/python/cpython/pull/9846/commits/b6ff7ce618bc958a4be4cf29aa98a622cf4cebea
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 26, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-168780347
View reviewed changes https://github.com/python/cpython/pull/9846/files/b6ff7ce618bc958a4be4cf29aa98a622cf4cebea
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/b6ff7ce618bc958a4be4cf29aa98a622cf4cebea#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
vstinnerhttps://github.com/vstinner
Oct 26, 2018https://github.com/python/cpython/pull/9846#discussion_r228493274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
Improve readability in the error handling branchhttps://github.com/python/cpython/pull/9846/commits/e7f8c464258acf2e82278909fb5e1a792aa65dbf
e7f8c46https://github.com/python/cpython/pull/9846/commits/e7f8c464258acf2e82278909fb5e1a792aa65dbf
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Oct 26, 2018https://github.com/python/cpython/pull/9846#event-1928700124
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 26, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-168808979
View reviewed changes https://github.com/python/cpython/pull/9846/files/e7f8c464258acf2e82278909fb5e1a792aa65dbf
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/9846#pullrequestreview-168808979
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
Capture only TypeError as suggested by Serhiyhttps://github.com/python/cpython/pull/9846/commits/0a6c8ba7d2bc269767e0bdbec283b36f59817d22
0a6c8bahttps://github.com/python/cpython/pull/9846/commits/0a6c8ba7d2bc269767e0bdbec283b36f59817d22
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 28, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-169097723
View reviewed changes https://github.com/python/cpython/pull/9846/files/0a6c8ba7d2bc269767e0bdbec283b36f59817d22
Objects/listobject.chttps://github.com/python/cpython/pull/9846/files/0a6c8ba7d2bc269767e0bdbec283b36f59817d22#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81
vstinnerhttps://github.com/vstinner
Oct 28, 2018https://github.com/python/cpython/pull/9846#discussion_r228753731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pablogsalhttps://github.com/pablogsal
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/9846
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 28, 2018https://github.com/python/cpython/pull/9846#discussion_r228755494
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Oct 28, 2018 https://github.com/python/cpython/pull/9846#pullrequestreview-169099756
View reviewed changes https://github.com/python/cpython/pull/9846/files/0a6c8ba7d2bc269767e0bdbec283b36f59817d22
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
372d705https://github.com/python/cpython/commit/372d705d958964289d762953d0a61622755f5386
Oct 28, 2018https://github.com/python/cpython/pull/9846#event-1930946079
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 28, 2018https://github.com/python/cpython/pull/9846#event-1930946091
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
October 28, 2018 20:16https://github.com/python/cpython/pull/9846#event-1930946119
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9846
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/9846/files/0a6c8ba7d2bc269767e0bdbec283b36f59817d22
https://github.com/methane
methane https://github.com/methane
https://github.com/python/cpython/pull/9846/files/b67844271da9a4cb3046820be74bf6e0c7b46927
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/9846/files/0a6c8ba7d2bc269767e0bdbec283b36f59817d22
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
Please reload this pagehttps://github.com/python/cpython/pull/9846
https://github.com/pablogsal
https://github.com/vstinner
https://github.com/methane
https://github.com/serhiy-storchaka
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.