René's URL Explorer Experiment


Title: gh-96035: Make urllib.parse.urlparse reject non-numeric ports by kenballus · Pull Request #98273 · python/cpython · GitHub

Open Graph Title: gh-96035: Make urllib.parse.urlparse reject non-numeric ports by kenballus · Pull Request #98273 · python/cpython

X Title: gh-96035: Make urllib.parse.urlparse reject non-numeric ports by kenballus · Pull Request #98273 · python/cpython

Description: urllib.parse.urlparse uses int to parse port numbers, which means they can contain signs, underscores, and whitespace. This patch adds a check to ensure that only numeric port numbers parse without error. Issue: gh-96035

Open Graph Description: urllib.parse.urlparse uses int to parse port numbers, which means they can contain signs, underscores, and whitespace. This patch adds a check to ensure that only numeric port numbers parse without...

X Description: urllib.parse.urlparse uses int to parse port numbers, which means they can contain signs, underscores, and whitespace. This patch adds a check to ensure that only numeric port numbers parse without...

Opengraph URL: https://github.com/python/cpython/pull/98273

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:61142fa2-5dc3-e4b8-5973-44f6b9804836
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD954:291B58:3E582C5:4ED99BB:6B024A6A
html-safe-nonceb72fbebcb94ce4676b5c6576e3bc360a8cf6de1f08fab375e719f470246aad0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTU0OjI5MUI1ODozRTU4MkM1OjRFRDk5QkI6NkIwMjRBNkEiLCJ2aXNpdG9yX2lkIjoiMzE4MTM2Njg4ODc5ODI0MzQzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac85cc0d9622433ebc48085d8b248b3980e10be9d3f05f5acf789cd8ef0933a581
hovercard-subject-tagpull_request:1088018089
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/98273/files
twitter:imagehttps://avatars.githubusercontent.com/u/49924171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/49924171?s=400&v=4
og:image:alturllib.parse.urlparse uses int to parse port numbers, which means they can contain signs, underscores, and whitespace. This patch adds a check to ensure that only numeric port numbers parse without...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98273/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98273%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98273%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98273/files
Reloadhttps://github.com/python/cpython/pull/98273/files
Reloadhttps://github.com/python/cpython/pull/98273/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
Conversation 22 https://github.com/python/cpython/pull/98273
Commits 14 https://github.com/python/cpython/pull/98273/commits
Checks 0 https://github.com/python/cpython/pull/98273/checks
Files changed https://github.com/python/cpython/pull/98273/files
Please reload this pagehttps://github.com/python/cpython/pull/98273/files
gh-96035: Make urllib.parse.urlparse reject non-numeric ports https://github.com/python/cpython/pull/98273/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/98273/files
2509db4 pythongh-96035: Make urllib.parse.urlparse reject non-numeric port st… kenballus Oct 15, 2022 https://github.com/python/cpython/pull/98273/commits/2509db49e9a3f7bf85a56ed697c39124d3fb783c
6e6db6b Merge branch 'python:main' into main kenballus Oct 16, 2022 https://github.com/python/cpython/pull/98273/commits/6e6db6b9b9af06600558b09dab397b6a2e2a537c
a41b8e0 Merge branch 'python:main' into main kenballus Oct 17, 2022 https://github.com/python/cpython/pull/98273/commits/a41b8e010b7cefa5ba0854edd11898c21e322229
5482221 Merge branch 'python:main' into main kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/5482221ad366c27d9962f9ecd81e9ac1a35335c3
98450a6 Add tests and remove nested errors. kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/98450a62e6abb0954aa4f160d7fef37343bc4419
b4ea289 Simplify port number validation. A port is valid iff it consists only… kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/b4ea289858a081f1682627816c5117206a6e2e7e
58d8e30 add check for ascii kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/58d8e3006d84230b690833fad6122d34dc13f683
40f1b37 Update Misc/NEWS.d/next/Library/2022-10-14-19-57-37.gh-issue-96035.0x… kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/40f1b37064b0db76e6824cd3fa53a1b963aacf3c
4b5c236 Merge branch 'main' into main kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/4b5c236f4813633a294bc6761f319a3922f19551
63c74e5 Merge branch 'python:main' into main kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/63c74e50d1934600f68e1672f0f1b37ad800e2cb
6a6683b add test for non-ascii port number kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/6a6683becf71e70e603f2283f5434a9192878ba6
67ecd2f Merge branch 'main' of github.com:kenballus/cpython kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/67ecd2f4c332411bcb36d2cd9dbfe32095680f89
c4c1554 Update Misc/NEWS.d/next/Library/2022-10-14-19-57-37.gh-issue-96035.0x… kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/c4c15542ccb3cd3814edbce5c137ca0fe060880f
b1aeb37 Merge branch 'python:main' into main kenballus Oct 20, 2022 https://github.com/python/cpython/pull/98273/commits/b1aeb37d6e0ba662249a3f0dbaef262f38836860
Clear filters https://github.com/python/cpython/pull/98273/files
Please reload this pagehttps://github.com/python/cpython/pull/98273/files
Please reload this pagehttps://github.com/python/cpython/pull/98273/files
test_urlparse.py https://github.com/python/cpython/pull/98273/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
parse.py https://github.com/python/cpython/pull/98273/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
2022-10-14-19-57-37.gh-issue-96035.0xcX-p.rst https://github.com/python/cpython/pull/98273/files#diff-e03ad930bf1773f361ccfc37ae86ec94faec5897008efba50a551c81a359fe5b
Lib/test/test_urlparse.pyhttps://github.com/python/cpython/pull/98273/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
View file https://github.com/python/cpython/blob/b1aeb37d6e0ba662249a3f0dbaef262f38836860/Lib/test/test_urlparse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98273/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98273/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/98273/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/98273/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/pull/98273/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643
Lib/urllib/parse.pyhttps://github.com/python/cpython/pull/98273/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
View file https://github.com/python/cpython/blob/b1aeb37d6e0ba662249a3f0dbaef262f38836860/Lib/urllib/parse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98273/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98273/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/98273/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/98273/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/98273/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
Misc/NEWS.d/next/Library/2022-10-14-19-57-37.gh-issue-96035.0xcX-p.rsthttps://github.com/python/cpython/pull/98273/files#diff-e03ad930bf1773f361ccfc37ae86ec94faec5897008efba50a551c81a359fe5b
View file https://github.com/python/cpython/blob/b1aeb37d6e0ba662249a3f0dbaef262f38836860/Misc/NEWS.d/next/Library/2022-10-14-19-57-37.gh-issue-96035.0xcX-p.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98273/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.