| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:aea6a6b9-6575-a1f2-c6c2-45dc9301ef57 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E0E:124678:C5FC0C:10B6EDF:6969EBD9 |
| html-safe-nonce | 28ff649fe7d3ab39c6bea7d3c95ab2db5c80136b60f431c643c9ecbb8b39b456 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTBFOjEyNDY3ODpDNUZDMEM6MTBCNkVERjo2OTY5RUJEOSIsInZpc2l0b3JfaWQiOiIxMzI3OTU2NjY2NTI2MzI5ODE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 49cbc7d4009e44cb307364712a7400bc97614d42a4946592f6731151cb74307b |
| hovercard-subject-tag | pull_request:1082527167 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/98164/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/50b58f4e3fdeb71c23ac3c6bf478de11a2d38e7b715db5a4365904761a920875/python/cpython/pull/98164 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/50b58f4e3fdeb71c23ac3c6bf478de11a2d38e7b715db5a4365904761a920875/python/cpython/pull/98164 |
| og:image:alt | asciilib_count() is the same than ucs1lib_count(): the code is not specialized for ASCII strings, so it's not worth it to have a separated function. Remove asciilib_count() function.
Define STR... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vstinner |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/98164#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98164 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98164 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/98164 |
| Reload | https://github.com/python/cpython/pull/98164 |
| Reload | https://github.com/python/cpython/pull/98164 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/98164#issue-comment-box |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
|
gh-97982: Remove asciilib_count()
| https://github.com/python/cpython/pull/98164#top |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
|
Conversation
6
| https://github.com/python/cpython/pull/98164 |
|
Commits
1
| https://github.com/python/cpython/pull/98164/commits |
|
Checks
0
| https://github.com/python/cpython/pull/98164/checks |
|
Files changed
| https://github.com/python/cpython/pull/98164/files |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Oct 10, 2022 | https://github.com/python/cpython/pull/98164#issue-1403732132 |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| Unify PyUncode_Count and unicode_count #97982 | https://github.com/python/cpython/issues/97982 |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Oct 10, 2022 | https://github.com/python/cpython/pull/98164#event-7557281755 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 10, 2022 | https://github.com/python/cpython/pull/98164#event-7557281916 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Oct 10, 2022
| https://github.com/python/cpython/pull/98164#ref-pullrequest-1400943228 |
|
gh-97982: Reuse PyUnicode_Count in unicode_count
#98025
| https://github.com/python/cpython/pull/98025 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Oct 10, 2022 | https://github.com/python/cpython/pull/98164#issuecomment-1273839521 |
| #98025 (comment) | https://github.com/python/cpython/pull/98025#issue-1400943228 |
| c3cec78 | https://github.com/python/cpython/commit/c3cec7868bf1019c0987f1e9aadb56d73fa93d61 |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Oct 10, 2022 | https://github.com/python/cpython/pull/98164#issuecomment-1273840696 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Oct 11, 2022 | https://github.com/python/cpython/pull/98164#issuecomment-1274288523 |
| #98025 (comment) | https://github.com/python/cpython/pull/98025#issuecomment-1273828220 |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Oct 11, 2022
| https://github.com/python/cpython/pull/98164#pullrequestreview-1137130233 |
|
View reviewed changes
| https://github.com/python/cpython/pull/98164/files |
| Objects/stringlib/count.h | https://github.com/python/cpython/pull/98164/files#diff-e2887aeddd6080f90064090b8315f4942be445b5354a85ed98ec956c182fa632 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Oct 11, 2022 | https://github.com/python/cpython/pull/98164#discussion_r992076244 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| vstinner | https://github.com/vstinner |
| Oct 11, 2022 | https://github.com/python/cpython/pull/98164#discussion_r992305337 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 11, 2022 | https://github.com/python/cpython/pull/98164#event-7560836617 |
|
| https://github.com/vstinner |
| gh-97982 | https://github.com/python/cpython/issues/97982 |
| : Remove asciilib_count() | https://github.com/python/cpython/pull/98164/commits/8587224af6727439b1b6c957d276c648618db87a |
| 8587224 | https://github.com/python/cpython/pull/98164/commits/8587224af6727439b1b6c957d276c648618db87a |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Oct 11, 2022 | https://github.com/python/cpython/pull/98164#issuecomment-1274928401 |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| df3a6d9 | https://github.com/python/cpython/commit/df3a6d9beb8a7a3fe87a6d4126384fd3e0213853 |
| Oct 11, 2022 | https://github.com/python/cpython/pull/98164#event-7564324330 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Oct 11, 2022 | https://github.com/python/cpython/pull/98164#event-7564324713 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| October 11, 2022 16:00 | https://github.com/python/cpython/pull/98164#event-7564324725 |
| carljm | https://github.com/carljm |
|
Oct 14, 2022
| https://github.com/python/cpython/pull/98164#ref-commit-6e53514 |
|
| https://github.com/carljm |
| Merge branch 'main' into typewatch | https://github.com/carljm/cpython/commit/6e53514f7cc3a1248b9be0fa21936068ac96d042 |
| 6e53514 | https://github.com/carljm/cpython/commit/6e53514f7cc3a1248b9be0fa21936068ac96d042 |
| pythongh-98251 | https://github.com/python/cpython/issues/98251 |
| pythonGH-98259 | https://github.com/python/cpython/pull/98259 |
| python#21399 | https://github.com/python/cpython/pull/21399 |
| python#30596 | https://github.com/python/cpython/pull/30596 |
| pythongh-98178 | https://github.com/python/cpython/issues/98178 |
| python#98213 | https://github.com/python/cpython/pull/98213 |
| pythonGH-98189 | https://github.com/python/cpython/pull/98189 |
| pythongh-97982 | https://github.com/python/cpython/issues/97982 |
| python#98025 | https://github.com/python/cpython/pull/98025 |
| pythongh-96265 | https://github.com/python/cpython/issues/96265 |
| python#98129 | https://github.com/python/cpython/pull/98129 |
| python#98204 | https://github.com/python/cpython/pull/98204 |
| pythongh-97669 | https://github.com/python/cpython/issues/97669 |
| python#98214 | https://github.com/python/cpython/pull/98214 |
| python#98217 | https://github.com/python/cpython/pull/98217 |
| pythongh-97669 | https://github.com/python/cpython/issues/97669 |
| python#98216 | https://github.com/python/cpython/pull/98216 |
| pythongh-97669 | https://github.com/python/cpython/issues/97669 |
| python#98186 | https://github.com/python/cpython/pull/98186 |
| pythongh-65046 | https://github.com/python/cpython/issues/65046 |
| python#98207 | https://github.com/python/cpython/pull/98207 |
| python#98111 | https://github.com/python/cpython/pull/98111 |
| pythongh-95276 | https://github.com/python/cpython/issues/95276 |
| python#95738 | https://github.com/python/cpython/pull/95738 |
| pythongh-96130 | https://github.com/python/cpython/issues/96130 |
| python#98144 | https://github.com/python/cpython/pull/98144 |
| python#98177 | https://github.com/python/cpython/pull/98177 |
| pythongh-98172 | https://github.com/python/cpython/issues/98172 |
| python#98173 | https://github.com/python/cpython/pull/98173 |
| pythongh-97982 | https://github.com/python/cpython/issues/97982 |
| python#98164 | https://github.com/python/cpython/pull/98164 |
| pythongh-95756 | https://github.com/python/cpython/issues/95756 |
| pythonGH-98181 | https://github.com/python/cpython/pull/98181 |
| carljm | https://github.com/carljm |
|
Oct 14, 2022
| https://github.com/python/cpython/pull/98164#ref-commit-0bb0c69 |
|
| https://github.com/carljm |
| Merge branch 'main' into cached_property | https://github.com/carljm/cpython/commit/0bb0c697c314dd5573eb4712e499eb9d9f884afa |
| 0bb0c69 | https://github.com/carljm/cpython/commit/0bb0c697c314dd5573eb4712e499eb9d9f884afa |
| pythongh-98251 | https://github.com/python/cpython/issues/98251 |
| pythonGH-98259 | https://github.com/python/cpython/pull/98259 |
| python#21399 | https://github.com/python/cpython/pull/21399 |
| python#30596 | https://github.com/python/cpython/pull/30596 |
| pythongh-98178 | https://github.com/python/cpython/issues/98178 |
| python#98213 | https://github.com/python/cpython/pull/98213 |
| pythonGH-98189 | https://github.com/python/cpython/pull/98189 |
| pythongh-97982 | https://github.com/python/cpython/issues/97982 |
| python#98025 | https://github.com/python/cpython/pull/98025 |
| pythongh-96265 | https://github.com/python/cpython/issues/96265 |
| python#98129 | https://github.com/python/cpython/pull/98129 |
| python#98204 | https://github.com/python/cpython/pull/98204 |
| pythongh-97669 | https://github.com/python/cpython/issues/97669 |
| python#98214 | https://github.com/python/cpython/pull/98214 |
| python#98217 | https://github.com/python/cpython/pull/98217 |
| pythongh-97669 | https://github.com/python/cpython/issues/97669 |
| python#98216 | https://github.com/python/cpython/pull/98216 |
| pythongh-97669 | https://github.com/python/cpython/issues/97669 |
| python#98186 | https://github.com/python/cpython/pull/98186 |
| pythongh-65046 | https://github.com/python/cpython/issues/65046 |
| python#98207 | https://github.com/python/cpython/pull/98207 |
| python#98111 | https://github.com/python/cpython/pull/98111 |
| pythongh-95276 | https://github.com/python/cpython/issues/95276 |
| python#95738 | https://github.com/python/cpython/pull/95738 |
| pythongh-96130 | https://github.com/python/cpython/issues/96130 |
| python#98144 | https://github.com/python/cpython/pull/98144 |
| python#98177 | https://github.com/python/cpython/pull/98177 |
| pythongh-98172 | https://github.com/python/cpython/issues/98172 |
| python#98173 | https://github.com/python/cpython/pull/98173 |
| pythongh-97982 | https://github.com/python/cpython/issues/97982 |
| python#98164 | https://github.com/python/cpython/pull/98164 |
| pythongh-95756 | https://github.com/python/cpython/issues/95756 |
| pythonGH-98181 | https://github.com/python/cpython/pull/98181 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98164 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/98164/files/895796602c84364f888028a02049bf81cebad5df |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/98164 |
|
| https://github.com/vstinner |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |