René's URL Explorer Experiment


Title: gh-96151: Use a private name for passing builtins to dataclass by hauntsaninja · Pull Request #98143 · python/cpython · GitHub

Open Graph Title: gh-96151: Use a private name for passing builtins to dataclass by hauntsaninja · Pull Request #98143 · python/cpython

X Title: gh-96151: Use a private name for passing builtins to dataclass by hauntsaninja · Pull Request #98143 · python/cpython

Description: There's no indication that BUILTINS is a special name. Other names that are special to dataclass are all prefixed by an underscore. As mentioned in the issue, we can also avoid this locals dance altogether by using ().__class__.__base__ instead of BUILTINS.object. Issue: gh-96151

Open Graph Description: There's no indication that BUILTINS is a special name. Other names that are special to dataclass are all prefixed by an underscore. As mentioned in the issue, we can also avoid this locals danc...

X Description: There's no indication that BUILTINS is a special name. Other names that are special to dataclass are all prefixed by an underscore. As mentioned in the issue, we can also avoid this locals ...

Opengraph URL: https://github.com/python/cpython/pull/98143

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dede7889-6b5e-44f1-9e85-116d2f3bb604
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1E6:1F19:1947BAF:2400F53:6A4F5C6A
html-safe-noncec81e6739791f14525017b8caed1335945e601552607694945458d8ed40849ed3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUU2OjFGMTk6MTk0N0JBRjoyNDAwRjUzOjZBNEY1QzZBIiwidmlzaXRvcl9pZCI6IjE5NzA0NjgzMDc4NDU3MzM0ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac19651810b449f16a07dc5d29966086024cdc7fe300c5944aa1e586470061868a
hovercard-subject-tagpull_request:1081624989
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/98143/files
twitter:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
og:image:altThere's no indication that BUILTINS is a special name. Other names that are special to dataclass are all prefixed by an underscore. As mentioned in the issue, we can also avoid this locals danc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98143/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98143%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98143%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98143/files
Reloadhttps://github.com/python/cpython/pull/98143/files
Reloadhttps://github.com/python/cpython/pull/98143/files
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericvsmithhttps://github.com/ericvsmith
python:mainhttps://github.com/python/cpython/tree/main
hauntsaninja:gh-96151https://github.com/hauntsaninja/cpython/tree/gh-96151
Conversation 18 https://github.com/python/cpython/pull/98143
Commits 8 https://github.com/python/cpython/pull/98143/commits
Checks 0 https://github.com/python/cpython/pull/98143/checks
Files changed https://github.com/python/cpython/pull/98143/files
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
gh-96151: Use a private name for passing builtins to dataclass https://github.com/python/cpython/pull/98143/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/98143/files
3e03d52 gh-96151: Use a private name for passing builtins to dataclass hauntsaninja Oct 10, 2022 https://github.com/python/cpython/pull/98143/commits/3e03d5292ec78548ef4fa0bcefd918c912f62577
7f9f91e 📜🤖 Added by blurb_it. blurb-it[bot] Oct 10, 2022 https://github.com/python/cpython/pull/98143/commits/7f9f91e89a13b38eaa6d482602379614ba38142d
2d5f290 add a test case hauntsaninja Oct 11, 2022 https://github.com/python/cpython/pull/98143/commits/2d5f29026e2a0376edc5ac9563966dbbf5e27c64
d7e8782 separate out test hauntsaninja Oct 11, 2022 https://github.com/python/cpython/pull/98143/commits/d7e87821382a78cf7a3111f692a0a6553f1298db
96cc82b use dunder builtins hauntsaninja Oct 17, 2022 https://github.com/python/cpython/pull/98143/commits/96cc82b8e87a7e973988d7717ea7ed4270aa6aac
e7456f8 actually, prefix with __dataclass hauntsaninja Oct 30, 2022 https://github.com/python/cpython/pull/98143/commits/e7456f899cae698b791b999d1cfb76d88cddf5ad
8f6e968 Remove builtins logic from _create_fn hauntsaninja Oct 31, 2022 https://github.com/python/cpython/pull/98143/commits/8f6e96850f59271a1824ee64bc16ab104bcf24e9
9d44429 also update comment hauntsaninja Oct 31, 2022 https://github.com/python/cpython/pull/98143/commits/9d44429b8dca59ad0af3486db4f79586aad72926
Clear filters https://github.com/python/cpython/pull/98143/files
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
dataclasses.py https://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
test_dataclasses.py https://github.com/python/cpython/pull/98143/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
2022-10-10-07-07-31.gh-issue-96151.K9fwoq.rst https://github.com/python/cpython/pull/98143/files#diff-6c50e10e4a9eda6fb8697148c0fd3f99c011862e435664340abfcf5b04b89d56
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L425
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
View file https://github.com/hauntsaninja/cpython/blob/9d44429b8dca59ad0af3486db4f79586aad72926/Lib/dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98143/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
JelleZijlstrahttps://github.com/JelleZijlstra
Oct 15, 2022https://github.com/python/cpython/pull/98143/files#r996343758
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
ericvsmithhttps://github.com/ericvsmith
Oct 30, 2022https://github.com/python/cpython/pull/98143/files#r1008944907
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
hauntsaninjahttps://github.com/hauntsaninja
Oct 30, 2022https://github.com/python/cpython/pull/98143/files#r1008948859
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/pull/9518/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5L371-L375https://github.com/python/cpython/pull/9518/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5L371-L375
bpo-34213: frozen dataclass with "object" attr bug #8452https://github.com/python/cpython/pull/8452
#9518https://github.com/python/cpython/pull/9518
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
hauntsaninjahttps://github.com/hauntsaninja
Oct 30, 2022https://github.com/python/cpython/pull/98143/files#r1008949141
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
hauntsaninjahttps://github.com/hauntsaninja
Oct 31, 2022https://github.com/python/cpython/pull/98143/files#r1008951060
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cpython/Lib/dataclasses.pyhttps://github.com/python/cpython/blob/87b5fd9d9de11c68b9940d3a1dba902138129109/Lib/dataclasses.py#L619
87b5fd9https://github.com/python/cpython/commit/87b5fd9d9de11c68b9940d3a1dba902138129109
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
https://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/98143/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Lib/test/test_dataclasses.pyhttps://github.com/python/cpython/pull/98143/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
View file https://github.com/hauntsaninja/cpython/blob/9d44429b8dca59ad0af3486db4f79586aad72926/Lib/test/test_dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98143/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98143/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
ericvsmithhttps://github.com/ericvsmith
Oct 11, 2022https://github.com/python/cpython/pull/98143/files#r992804094
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
hauntsaninjahttps://github.com/hauntsaninja
Oct 11, 2022https://github.com/python/cpython/pull/98143/files#r992807587
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/98143/files
https://github.com/python/cpython/pull/98143/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
Misc/NEWS.d/next/Library/2022-10-10-07-07-31.gh-issue-96151.K9fwoq.rsthttps://github.com/python/cpython/pull/98143/files#diff-6c50e10e4a9eda6fb8697148c0fd3f99c011862e435664340abfcf5b04b89d56
View file https://github.com/hauntsaninja/cpython/blob/9d44429b8dca59ad0af3486db4f79586aad72926/Misc/NEWS.d/next/Library/2022-10-10-07-07-31.gh-issue-96151.K9fwoq.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98143/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.