René's URL Explorer Experiment


Title: gh-97982: Reuse `PyUnicode_Count` in `unicode_count` by sobolevn · Pull Request #98025 · python/cpython · GitHub

Open Graph Title: gh-97982: Reuse `PyUnicode_Count` in `unicode_count` by sobolevn · Pull Request #98025 · python/cpython

X Title: gh-97982: Reuse `PyUnicode_Count` in `unicode_count` by sobolevn · Pull Request #98025 · python/cpython

Description: This now makes unicode_count as optimized as PyUnicode_Count. There was a missing optimization, see c3cec78 However, I've decided not to touch anylib_count, because of (const Py_UCS1*)buf1 (and similar) casts and function ordering. We cannot directly call anylib_count from PyUnicode_Count. I don't think it is worth creating forward declarations / moving things just for that. Issue: gh-97982

Open Graph Description: This now makes unicode_count as optimized as PyUnicode_Count. There was a missing optimization, see c3cec78 However, I've decided not to touch anylib_count, because of (const Py_UCS1*)buf1 (and...

X Description: This now makes unicode_count as optimized as PyUnicode_Count. There was a missing optimization, see c3cec78 However, I've decided not to touch anylib_count, because of (const Py_UCS1*)buf1 ...

Opengraph URL: https://github.com/python/cpython/pull/98025

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ee3c2eb-4b1b-2326-b74a-3b9974749cdd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3B6:33E3E9:FFE8D:14F678:696AFD66
html-safe-nonce6377c176f10f5327562eb4344c21d9504687258ccbae34dcd8927f1b14f84cc7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0I2OjMzRTNFOTpGRkU4RDoxNEY2Nzg6Njk2QUZENjYiLCJ2aXNpdG9yX2lkIjoiOTEyMDY3MjQzODQ5ODgxOTQzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0ecdeb5cbe5a199ea7a994390d1e8de63214e155929d5ff704e747c61a4afdf5
hovercard-subject-tagpull_request:1080157147
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/98025/files
twitter:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
og:image:altThis now makes unicode_count as optimized as PyUnicode_Count. There was a missing optimization, see c3cec78 However, I've decided not to touch anylib_count, because of (const Py_UCS1*)buf1 (and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98025/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98025%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98025%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98025/files
Reloadhttps://github.com/python/cpython/pull/98025/files
Reloadhttps://github.com/python/cpython/pull/98025/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98025/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/98025/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-97982https://github.com/sobolevn/cpython/tree/issue-97982
Conversation 32 https://github.com/python/cpython/pull/98025
Commits 10 https://github.com/python/cpython/pull/98025/commits
Checks 0 https://github.com/python/cpython/pull/98025/checks
Files changed https://github.com/python/cpython/pull/98025/files
Please reload this pagehttps://github.com/python/cpython/pull/98025/files
gh-97982: Reuse PyUnicode_Count in unicode_count https://github.com/python/cpython/pull/98025/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/98025/files
b239ae5 gh-97982: Reuse `PyUnicode_Count` in `unicode_count` sobolevn Oct 7, 2022 https://github.com/python/cpython/pull/98025/commits/b239ae5762604f77fcaac7cb81263a31dac560d0
e9d6358 Address review sobolevn Oct 7, 2022 https://github.com/python/cpython/pull/98025/commits/e9d63589165daee34efaf76b33d31b297fdaa484
886d6e3 Update 2022-10-07-13-09-57.gh-issue-97982.6qR7Qm.rst sobolevn Oct 7, 2022 https://github.com/python/cpython/pull/98025/commits/886d6e388127c7d33b7b4e2027571c573ed35e28
482010a Update 2022-10-07-13-09-57.gh-issue-97982.6qR7Qm.rst sobolevn Oct 7, 2022 https://github.com/python/cpython/pull/98025/commits/482010ac48f42a89619f585fb69c589be47a005a
4b2447e Use `assert()` for unicode objects sobolevn Oct 7, 2022 https://github.com/python/cpython/pull/98025/commits/4b2447e7233d714b0462cf7944aee349a27b6059
35ecc77 Address review sobolevn Oct 8, 2022 https://github.com/python/cpython/pull/98025/commits/35ecc77deb4c38f082842ff777f1af67730236a7
8270d4b Merge branch 'main' into issue-97982 sobolevn Oct 12, 2022 https://github.com/python/cpython/pull/98025/commits/8270d4bc78106d5173fca0da3086844ff847a1cf
2dabc73 Use `anylib_count` in `unicode_count_impl` sobolevn Oct 12, 2022 https://github.com/python/cpython/pull/98025/commits/2dabc73cc3df589be13c827269f9ef66924ce569
74f8c1c Revert "Use `anylib_count` in `unicode_count_impl`" sobolevn Oct 12, 2022 https://github.com/python/cpython/pull/98025/commits/74f8c1c564bd3d3ac28dd05faa6053980b8e4f95
69a94e2 Add a comment about `anylib_count` sobolevn Oct 12, 2022 https://github.com/python/cpython/pull/98025/commits/69a94e2cc0d0a13de01e9acd2de69d49c7222d58
Clear filters https://github.com/python/cpython/pull/98025/files
Please reload this pagehttps://github.com/python/cpython/pull/98025/files
Please reload this pagehttps://github.com/python/cpython/pull/98025/files
test_unicode.py https://github.com/python/cpython/pull/98025/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
unicodeobject.c https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
Lib/test/test_unicode.pyhttps://github.com/python/cpython/pull/98025/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
View file https://github.com/sobolevn/cpython/blob/69a94e2cc0d0a13de01e9acd2de69d49c7222d58/Lib/test/test_unicode.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98025/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98025/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
https://github.com/python/cpython/pull/98025/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
https://github.com/python/cpython/pull/98025/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
https://github.com/python/cpython/pull/98025/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
Objects/unicodeobject.chttps://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
View file https://github.com/sobolevn/cpython/blob/69a94e2cc0d0a13de01e9acd2de69d49c7222d58/Objects/unicodeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/98025/{{ revealButtonHref }}
https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
Please reload this pagehttps://github.com/python/cpython/pull/98025/files
https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com/python/cpython/pull/98025/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.