René's URL Explorer Experiment


Title: GH-88968: Reject socket that is already used as a transport by gvanrossum · Pull Request #98010 · python/cpython · GitHub

Open Graph Title: GH-88968: Reject socket that is already used as a transport by gvanrossum · Pull Request #98010 · python/cpython

X Title: GH-88968: Reject socket that is already used as a transport by gvanrossum · Pull Request #98010 · python/cpython

Description: Add a check to _make_socket_transport() that a socket passed in isn't already in use by a transport. If it was, this would indicate that someone had closed the socket but not the transport (or the ...

Open Graph Description: Add a check to _make_socket_transport() that a socket passed in isn't already in use by a transport. If it was, this would indicate that someone had closed the socket but not the transport (or ...

X Description: Add a check to _make_socket_transport() that a socket passed in isn't already in use by a transport. If it was, this would indicate that someone had closed the socket but not the transport ...

Opengraph URL: https://github.com/python/cpython/pull/98010

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e53b588c-a1b4-3258-47a7-9a3c53c708b9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADF0:21FAD6:143C9B0:1B94573:69694C1E
html-safe-nonce8a1df605f74892c1e92a60b41d7a650521a8b082cc99cc79fe1a5f642cc27990
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREYwOjIxRkFENjoxNDNDOUIwOjFCOTQ1NzM6Njk2OTRDMUUiLCJ2aXNpdG9yX2lkIjoiMzc5ODQ3MDc1MzM4ODE1Mzg4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacac196e969c815e14dc1393bf6ebded8784f07c6b6be863235b2989f183b3d3b6
hovercard-subject-tagpull_request:1079756280
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/98010/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8228daa5f989f4c27e5ff888aa0f67fbbbc2616ed98104a8d2f1c7f8d03b2407/python/cpython/pull/98010
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8228daa5f989f4c27e5ff888aa0f67fbbbc2616ed98104a8d2f1c7f8d03b2407/python/cpython/pull/98010
og:image:altAdd a check to _make_socket_transport() that a socket passed in isn't already in use by a transport. If it was, this would indicate that someone had closed the socket but not the transport (or ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegvanrossum
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98010#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98010
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98010
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98010
Reloadhttps://github.com/python/cpython/pull/98010
Reloadhttps://github.com/python/cpython/pull/98010
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98010
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/98010
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/98010#issue-comment-box
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
gvanrossum:reject-sock-reusehttps://github.com/gvanrossum/cpython/tree/reject-sock-reuse
GH-88968: Reject socket that is already used as a transport https://github.com/python/cpython/pull/98010#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
gvanrossum:reject-sock-reusehttps://github.com/gvanrossum/cpython/tree/reject-sock-reuse
Conversation 3 https://github.com/python/cpython/pull/98010
Commits 4 https://github.com/python/cpython/pull/98010/commits
Checks 0 https://github.com/python/cpython/pull/98010/checks
Files changed https://github.com/python/cpython/pull/98010/files
Please reload this pagehttps://github.com/python/cpython/pull/98010
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 7, 2022https://github.com/python/cpython/pull/98010#issue-1400478693
Please reload this pagehttps://github.com/python/cpython/pull/98010
asyncio.StreamReader.read hangs for reused socket file descriptors when asyncio.StreamWriter.close() is not called #88968https://github.com/python/cpython/issues/88968
Please reload this pagehttps://github.com/python/cpython/pull/98010
gvanrossumhttps://github.com/gvanrossum
October 6, 2022 17:49https://github.com/python/cpython/pull/98010#commits-pushed-6783dda
https://github.com/gvanrossum
In _make_socket_transport, ensure the fd isn't already used by a tran…https://github.com/python/cpython/pull/98010/commits/6783ddaf0384cdbeb0b29cba0418755c4a811c9a
6783ddahttps://github.com/python/cpython/pull/98010/commits/6783ddaf0384cdbeb0b29cba0418755c4a811c9a
https://github.com/gvanrossum
Make existing tests passhttps://github.com/python/cpython/pull/98010/commits/fda211169d254f6a3baab33684260f19141f1aa5
fda2111https://github.com/python/cpython/pull/98010/commits/fda211169d254f6a3baab33684260f19141f1aa5
https://github.com/gvanrossum
Test that _ensure_fd_no_transport is calledhttps://github.com/python/cpython/pull/98010/commits/6224b183dda2d4a845933a1c6aa5d614acab290c
6224b18https://github.com/python/cpython/pull/98010/commits/6224b183dda2d4a845933a1c6aa5d614acab290c
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/27025e158c70331d0a8fb42fe234a2a6770850d1/.github/CODEOWNERS#L8
October 7, 2022 00:57https://github.com/python/cpython/pull/98010#event-7539635057
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 7, 2022https://github.com/python/cpython/pull/98010#event-7539635193
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
October 7, 2022 00:57https://github.com/python/cpython/pull/98010#event-7539635666
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Oct 7, 2022https://github.com/python/cpython/pull/98010#issuecomment-1271065365
Please reload this pagehttps://github.com/python/cpython/pull/98010
https://github.com/gvanrossum
Same check for _make_ssl_transport and _make_datagram_transporthttps://github.com/python/cpython/pull/98010/commits/1c348f1b430bbad6b1f858f087f82888e00564b5
1c348f1https://github.com/python/cpython/pull/98010/commits/1c348f1b430bbad6b1f858f087f82888e00564b5
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 7, 2022https://github.com/python/cpython/pull/98010#issuecomment-1271754823
Please reload this pagehttps://github.com/python/cpython/pull/98010
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Oct 7, 2022 https://github.com/python/cpython/pull/98010#pullrequestreview-1134812508
View reviewed changes https://github.com/python/cpython/pull/98010/files/1c348f1b430bbad6b1f858f087f82888e00564b5
kumaraditya303https://github.com/kumaraditya303
https://github.com/python/cpython/pull/98010#pullrequestreview-1134812508
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/98010
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Oct 7, 2022https://github.com/python/cpython/pull/98010#event-7545134849
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Oct 7, 2022https://github.com/python/cpython/pull/98010#event-7546178145
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
c062764https://github.com/python/cpython/commit/c06276402b5f23d49a39dfcaf45ed81b5c88efe7
Oct 7, 2022https://github.com/python/cpython/pull/98010#event-7546183726
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 7, 2022https://github.com/python/cpython/pull/98010#event-7546183999
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
October 7, 2022 19:57https://github.com/python/cpython/pull/98010#event-7546185427
carljmhttps://github.com/carljm
Oct 8, 2022 https://github.com/python/cpython/pull/98010#ref-commit-27a4980
https://github.com/carljm
Merge branch 'main' into typewatchhttps://github.com/carljm/cpython/commit/27a498096c921dec2377154cf6ae9bb5e5a8924c
27a4980https://github.com/carljm/cpython/commit/27a498096c921dec2377154cf6ae9bb5e5a8924c
pythongh-92886https://github.com/python/cpython/issues/92886
pythonGH-98058https://github.com/python/cpython/pull/98058
pythongh-92886https://github.com/python/cpython/issues/92886
pythonGH-98060https://github.com/python/cpython/pull/98060
pythongh-57179https://github.com/python/cpython/issues/57179
python#94799https://github.com/python/cpython/pull/94799
pythongh-94808https://github.com/python/cpython/issues/94808
python#98036https://github.com/python/cpython/pull/98036
pythongh-90085https://github.com/python/cpython/issues/90085
python#94941https://github.com/python/cpython/pull/94941
pythonGH-83901https://github.com/python/cpython/issues/83901
python#95347https://github.com/python/cpython/pull/95347
pythongh-61105https://github.com/python/cpython/issues/61105
python#95427https://github.com/python/cpython/pull/95427
pythongh-96288https://github.com/python/cpython/issues/96288
python#96271https://github.com/python/cpython/pull/96271
pythongh-96073https://github.com/python/cpython/issues/96073
pythonGH-98056https://github.com/python/cpython/pull/98056
pythongh-92886https://github.com/python/cpython/issues/92886
pythonGH-98051https://github.com/python/cpython/pull/98051
pythongh-97997https://github.com/python/cpython/issues/97997
python#98000https://github.com/python/cpython/pull/98000
pythonGH-88968https://github.com/python/cpython/issues/88968
python#98010https://github.com/python/cpython/pull/98010
pythongh-96346https://github.com/python/cpython/issues/96346
python#96347https://github.com/python/cpython/pull/96347
pythongh-91708https://github.com/python/cpython/issues/91708
python#96699https://github.com/python/cpython/pull/96699
pythongh-96265https://github.com/python/cpython/issues/96265
python#96924https://github.com/python/cpython/pull/96924
pythongh-73196https://github.com/python/cpython/issues/73196
python#92840https://github.com/python/cpython/pull/92840
pythongh-97646https://github.com/python/cpython/issues/97646
python#97934https://github.com/python/cpython/pull/97934
pythongh-97923https://github.com/python/cpython/issues/97923
python#97940https://github.com/python/cpython/pull/97940
pythongh-97956https://github.com/python/cpython/issues/97956
python#97957https://github.com/python/cpython/pull/97957
pythongh-96959https://github.com/python/cpython/issues/96959
python#98039https://github.com/python/cpython/pull/98039
mpagehttps://github.com/mpage
Oct 11, 2022 https://github.com/python/cpython/pull/98010#ref-commit-8cb415b
https://github.com/gvanrossum
https://github.com/mpage
pythonGH-88968https://github.com/python/cpython/issues/88968
: Reject socket that is already used as a transport (https://github.com/mpage/cpython/commit/8cb415b1fe6d9dcaeb99b2f8b147d70f6da0c1e8
py…https://github.com/python/cpython/pull/98010
8cb415bhttps://github.com/mpage/cpython/commit/8cb415b1fe6d9dcaeb99b2f8b147d70f6da0c1e8
…thon#98010https://github.com/python/cpython/pull/98010
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98010
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/98010/files/1c348f1b430bbad6b1f858f087f82888e00564b5
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/98010
https://github.com/gvanrossum
https://github.com/kumaraditya303
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.