René's URL Explorer Experiment


Title: gh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state by iritkatriel · Pull Request #98001 · python/cpython · GitHub

Open Graph Title: gh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state by iritkatriel · Pull Request #98001 · python/cpython

X Title: gh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state by iritkatriel · Pull Request #98001 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This implements #93691 (comment). The line numbers are almost identical to those we calculated before (see the individual commits if you're interested in the process I followed). There were a...

X Description: This implements #93691 (comment). The line numbers are almost identical to those we calculated before (see the individual commits if you're interested in the process I followed). There we...

Opengraph URL: https://github.com/python/cpython/pull/98001

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:21900a42-3656-dbee-6d5d-2dea79f8d363
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8534:65407:6D3663:92A2E6:6969B78E
html-safe-nonceb334bcdfb5195b24b7bc34e49ea1b286cd8826cea42f10acaba0e6ec1e15e963
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTM0OjY1NDA3OjZEMzY2Mzo5MkEyRTY6Njk2OUI3OEUiLCJ2aXNpdG9yX2lkIjoiMjM1MDIyNDMwMzkxNjE2OTEwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3600cb3a27ee78cae269f0afeb7047bb18033df1f0b701f4a4ccc319b1ea0437
hovercard-subject-tagpull_request:1079695479
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/98001/commits
twitter:imagehttps://opengraph.githubassets.com/3f75243213d0b513e5c70cee12b9f3c1e23af3c5b1e2041ba646ffe3511cf2d4/python/cpython/pull/98001
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3f75243213d0b513e5c70cee12b9f3c1e23af3c5b1e2041ba646ffe3511cf2d4/python/cpython/pull/98001
og:image:altThis implements #93691 (comment). The line numbers are almost identical to those we calculated before (see the individual commits if you're interested in the process I followed). There were a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiritkatriel
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/98001/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98001%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F98001%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/98001/commits
Reloadhttps://github.com/python/cpython/pull/98001/commits
Reloadhttps://github.com/python/cpython/pull/98001/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/98001/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/98001/commits
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:linenoshttps://github.com/iritkatriel/cpython/tree/linenos
Conversationhttps://github.com/python/cpython/pull/98001
Commits13 (13)https://github.com/python/cpython/pull/98001/commits
Checkshttps://github.com/python/cpython/pull/98001/checks
Files changedhttps://github.com/python/cpython/pull/98001/files
gh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler statehttps://github.com/python/cpython/pull/98001/commits#top
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:linenoshttps://github.com/iritkatriel/cpython/tree/linenos
pass location into the various ADDOPshttps://github.com/python/cpython/pull/98001/commits/ecfa12e61f669723f065f1631983c28f9b85ea3b
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
ecfa12ehttps://github.com/python/cpython/pull/98001/commits/ecfa12e61f669723f065f1631983c28f9b85ea3b
https://github.com/python/cpython/tree/ecfa12e61f669723f065f1631983c28f9b85ea3b
Pass locations around instead of using the one on the compiler state. Assert they are the same as on the compiler state, except a few places where the location is currently wrong/random.https://github.com/python/cpython/pull/98001/commits/082625cafdbd6ae0bddb5054e0405a7e4530e67b
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
082625chttps://github.com/python/cpython/pull/98001/commits/082625cafdbd6ae0bddb5054e0405a7e4530e67b
https://github.com/python/cpython/tree/082625cafdbd6ae0bddb5054e0405a7e4530e67b
find last loc in finally bodyhttps://github.com/python/cpython/pull/98001/commits/c50ff3632f2967865c2070f60c00c466b8c75bd7
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
c50ff36https://github.com/python/cpython/pull/98001/commits/c50ff3632f2967865c2070f60c00c466b8c75bd7
https://github.com/python/cpython/tree/c50ff3632f2967865c2070f60c00c466b8c75bd7
remove scaffoldhttps://github.com/python/cpython/pull/98001/commits/091266fde3010ba3394ec46fb0d0c6e67dba1e06
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
091266fhttps://github.com/python/cpython/pull/98001/commits/091266fde3010ba3394ec46fb0d0c6e67dba1e06
https://github.com/python/cpython/tree/091266fde3010ba3394ec46fb0d0c6e67dba1e06
remove u_loc from compiler_unithttps://github.com/python/cpython/pull/98001/commits/8fd667dc07da435f67b0571074766a91eb9042ba
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
8fd667dhttps://github.com/python/cpython/pull/98001/commits/8fd667dc07da435f67b0571074766a91eb9042ba
https://github.com/python/cpython/tree/8fd667dc07da435f67b0571074766a91eb9042ba
Merge remote-tracking branch 'upstream/main' into linenoshttps://github.com/python/cpython/pull/98001/commits/c7764cedcfa8964290651d97d68f9145c458dd5b
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
c7764cehttps://github.com/python/cpython/pull/98001/commits/c7764cedcfa8964290651d97d68f9145c458dd5b
https://github.com/python/cpython/tree/c7764cedcfa8964290651d97d68f9145c458dd5b
Merge remote-tracking branch 'upstream/main' into linenoshttps://github.com/python/cpython/pull/98001/commits/498e98bc69da0f60820269fa930284c1e7440dfe
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
498e98bhttps://github.com/python/cpython/pull/98001/commits/498e98bc69da0f60820269fa930284c1e7440dfe
https://github.com/python/cpython/tree/498e98bc69da0f60820269fa930284c1e7440dfe
Merge branch 'main' into linenoshttps://github.com/python/cpython/pull/98001/commits/f8d061b373f3b84397467a4595e98697693a00ab
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/python/cpython/commits?author=JelleZijlstra
f8d061bhttps://github.com/python/cpython/pull/98001/commits/f8d061b373f3b84397467a4595e98697693a00ab
https://github.com/python/cpython/tree/f8d061b373f3b84397467a4595e98697693a00ab
typedef of the location structhttps://github.com/python/cpython/pull/98001/commits/0df1e0cd31b1a481ff5211e2dc04eb21a7eaaa7a
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
0df1e0chttps://github.com/python/cpython/pull/98001/commits/0df1e0cd31b1a481ff5211e2dc04eb21a7eaaa7a
https://github.com/python/cpython/tree/0df1e0cd31b1a481ff5211e2dc04eb21a7eaaa7a
Merge branch 'main' into linenoshttps://github.com/python/cpython/pull/98001/commits/e09f741167d997ef9433136adb7c7d3261e47e43
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
e09f741https://github.com/python/cpython/pull/98001/commits/e09f741167d997ef9433136adb7c7d3261e47e43
https://github.com/python/cpython/tree/e09f741167d997ef9433136adb7c7d3261e47e43
Merge branch 'main' into linenoshttps://github.com/python/cpython/pull/98001/commits/80393a395b31e4f66444a398de6e0ecef7423826
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
80393a3https://github.com/python/cpython/pull/98001/commits/80393a395b31e4f66444a398de6e0ecef7423826
https://github.com/python/cpython/tree/80393a395b31e4f66444a398de6e0ecef7423826
int --> Py_ssize_t. renamed last_location_in_body --> location_of_last_executing_statementhttps://github.com/python/cpython/pull/98001/commits/8e7acf65999539a9a190e72ca4afb9b0afa0e559
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
8e7acf6https://github.com/python/cpython/pull/98001/commits/8e7acf65999539a9a190e72ca4afb9b0afa0e559
https://github.com/python/cpython/tree/8e7acf65999539a9a190e72ca4afb9b0afa0e559
removed CHANGED comment indicating where line numbers were not perfectly preservedhttps://github.com/python/cpython/pull/98001/commits/5418bb535fa0b28e966ca38bb2d0b48d0c132ccb
https://github.com/iritkatriel
iritkatrielhttps://github.com/python/cpython/commits?author=iritkatriel
5418bb5https://github.com/python/cpython/pull/98001/commits/5418bb535fa0b28e966ca38bb2d0b48d0c132ccb
https://github.com/python/cpython/tree/5418bb535fa0b28e966ca38bb2d0b48d0c132ccb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.