| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:513a9812-c37c-ffb3-31f4-e3ea7c65723a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A21C:33C049:4E799E:695DA3:6969D537 |
| html-safe-nonce | 3b22919fd7b76e29cc5020aece73499d7e89bf9d6ca928340c4241c3e87bfbc6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjFDOjMzQzA0OTo0RTc5OUU6Njk1REEzOjY5NjlENTM3IiwidmlzaXRvcl9pZCI6IjMxOTU1NTAyMjc5OTI1MzIyODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 63fa5b1cf11a25542c9888bb7610bd53a8ae4cb85cb2d8c82d814d3b4bb6539d |
| hovercard-subject-tag | pull_request:1079460276 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/97984/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f90ec7e226a2056c5e241bd770ebac6d1ea04b907a1dfc9fe2c865aac2087a9f/python/cpython/pull/97984 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f90ec7e226a2056c5e241bd770ebac6d1ea04b907a1dfc9fe2c865aac2087a9f/python/cpython/pull/97984 |
| og:image:alt | Right now, the tokenizer only returns type and two pointers to the start and end of the token. This PR modifies the tokenizer to return the type and set all of the necessary information, so that th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lysnikolaou |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/97984#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97984 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97984 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/97984 |
| Reload | https://github.com/python/cpython/pull/97984 |
| Reload | https://github.com/python/cpython/pull/97984 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/97984 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/97984 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/97984#issue-comment-box |
| lysnikolaou | https://github.com/lysnikolaou |
| python:main | https://github.com/python/cpython/tree/main |
| lysnikolaou:tokenizer-return-token-2 | https://github.com/lysnikolaou/cpython/tree/tokenizer-return-token-2 |
|
gh-97973: Return all necessary information from the tokenizer
| https://github.com/python/cpython/pull/97984#top |
| lysnikolaou | https://github.com/lysnikolaou |
| python:main | https://github.com/python/cpython/tree/main |
| lysnikolaou:tokenizer-return-token-2 | https://github.com/lysnikolaou/cpython/tree/tokenizer-return-token-2 |
|
Conversation
1
| https://github.com/python/cpython/pull/97984 |
|
Commits
7
| https://github.com/python/cpython/pull/97984/commits |
|
Checks
0
| https://github.com/python/cpython/pull/97984/checks |
|
Files changed
| https://github.com/python/cpython/pull/97984/files |
| Please reload this page | https://github.com/python/cpython/pull/97984 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| Oct 6, 2022 | https://github.com/python/cpython/pull/97984#issue-1400146951 |
| Please reload this page | https://github.com/python/cpython/pull/97984 |
| Tokenizer returnings pointers make calculation of position info more complicated #97973 | https://github.com/python/cpython/issues/97973 |
| Please reload this page | https://github.com/python/cpython/pull/97984 |
|
| https://github.com/lysnikolaou |
| pythongh-97973 | https://github.com/python/cpython/issues/97973 |
| : Return all necessary information from the tokenizer | https://github.com/python/cpython/pull/97984/commits/0a7d0f639cfc3681a96da74dc2ec4831533471d5 |
| 0a7d0f6 | https://github.com/python/cpython/pull/97984/commits/0a7d0f639cfc3681a96da74dc2ec4831533471d5 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| pablogsal | https://github.com/pablogsal |
| code owner | https://github.com/python/cpython/blob/23e83a84651bbcf1f3778baf3ab0b4cbfead75e3/.github/CODEOWNERS#L87 |
| October 6, 2022 18:44 | https://github.com/python/cpython/pull/97984#event-7537799490 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 6, 2022 | https://github.com/python/cpython/pull/97984#event-7537799714 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| Oct 6, 2022 | https://github.com/python/cpython/pull/97984#event-7537802775 |
|
Tokenizer returnings pointers make calculation of position info more complicated
#97973
| https://github.com/python/cpython/issues/97973 |
| lysnikolaou | https://github.com/lysnikolaou |
| October 6, 2022 12:35 | https://github.com/python/cpython/pull/97984#commits-pushed-c2320ba |
|
| https://github.com/lysnikolaou |
| Pass pointers so that struct does not get copied | https://github.com/python/cpython/pull/97984/commits/c2320ba5672eaaad1463c8138ed94a07380a7aec |
| c2320ba | https://github.com/python/cpython/pull/97984/commits/c2320ba5672eaaad1463c8138ed94a07380a7aec |
|
| https://github.com/lysnikolaou |
| Merge branch 'main' into tokenizer-return-token-2 | https://github.com/python/cpython/pull/97984/commits/dee33594de0c00a95e472edbd7abf96bae7f9de7 |
| dee3359 | https://github.com/python/cpython/pull/97984/commits/dee33594de0c00a95e472edbd7abf96bae7f9de7 |
|
| https://github.com/lysnikolaou |
| Remove news blurb for now | https://github.com/python/cpython/pull/97984/commits/b28afeda709b8f0eb3edca7c3e1daceac0798e40 |
| b28afed | https://github.com/python/cpython/pull/97984/commits/b28afeda709b8f0eb3edca7c3e1daceac0798e40 |
|
| https://github.com/apps/blurb-it |
| 📜🤖 Added by blurb_it. | https://github.com/python/cpython/pull/97984/commits/1e52242ba712aeaa695b4f0c112c77d631392443 |
| 1e52242 | https://github.com/python/cpython/pull/97984/commits/1e52242ba712aeaa695b4f0c112c77d631392443 |
|
| https://github.com/lysnikolaou |
| Merge branch 'main' into tokenizer-return-token-2 | https://github.com/python/cpython/pull/97984/commits/0aea48d5bb31e374d1dbc9799a22a82db86d9d46 |
| 0aea48d | https://github.com/python/cpython/pull/97984/commits/0aea48d5bb31e374d1dbc9799a22a82db86d9d46 |
|
| https://github.com/lysnikolaou |
| Add assertion | https://github.com/python/cpython/pull/97984/commits/689c670ae876baba229ee4bdd85ab02872600e8c |
| 689c670 | https://github.com/python/cpython/pull/97984/commits/689c670ae876baba229ee4bdd85ab02872600e8c |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
Oct 6, 2022
| https://github.com/python/cpython/pull/97984#pullrequestreview-1133690255 |
|
View reviewed changes
| https://github.com/python/cpython/pull/97984/files/689c670ae876baba229ee4bdd85ab02872600e8c |
| pablogsal | https://github.com/pablogsal |
| https://github.com/python/cpython/pull/97984#pullrequestreview-1133690255 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/97984 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 6, 2022 | https://github.com/python/cpython/pull/97984#event-7538993524 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
| cbf0afd | https://github.com/python/cpython/commit/cbf0afd8a1474d68310331af9218606959d4cc22 |
| Oct 6, 2022 | https://github.com/python/cpython/pull/97984#event-7539246683 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Oct 6, 2022 | https://github.com/python/cpython/pull/97984#event-7539246852 |
| https://github.com/lysnikolaou |
| lysnikolaou | https://github.com/lysnikolaou |
|
Oct 7, 2022
| https://github.com/python/cpython/pull/97984#ref-pullrequest-1401750374 |
|
Use new tokenizer column offset to fix fstring ast locations
we-like-parsers/cpython#195
| https://github.com/we-like-parsers/cpython/pull/195 |
| carljm | https://github.com/carljm |
|
Oct 8, 2022
| https://github.com/python/cpython/pull/97984#ref-commit-415ed49 |
|
| https://github.com/carljm |
| Merge branch 'main' into typewatch | https://github.com/carljm/cpython/commit/415ed492de0dc27707962eb1756cf183dadd0885 |
| 415ed49 | https://github.com/carljm/cpython/commit/415ed492de0dc27707962eb1756cf183dadd0885 |
| pythonGH-97002 | https://github.com/python/cpython/issues/97002 |
| pythonGH-97996 | https://github.com/python/cpython/pull/97996 |
| pythongh-97973 | https://github.com/python/cpython/issues/97973 |
| pythonGH-97984 | https://github.com/python/cpython/pull/97984 |
| pythongh-96078 | https://github.com/python/cpython/issues/96078 |
| pythongh-97965 | https://github.com/python/cpython/pull/97965 |
| pythongh-65961 | https://github.com/python/cpython/issues/65961 |
| pythonGH-97990 | https://github.com/python/cpython/pull/97990 |
| pythongh-97850 | https://github.com/python/cpython/issues/97850 |
| python#97935 | https://github.com/python/cpython/pull/97935 |
| pythonGH-97992 | https://github.com/python/cpython/pull/97992 |
| pythongh-94590 | https://github.com/python/cpython/issues/94590 |
| python#94591 | https://github.com/python/cpython/pull/94591 |
| python#97974 | https://github.com/python/cpython/pull/97974 |
| pythongh-97781 | https://github.com/python/cpython/issues/97781 |
| pythonGH-97785 | https://github.com/python/cpython/pull/97785 |
| pythongh-86482 | https://github.com/python/cpython/issues/86482 |
| python#23291 | https://github.com/python/cpython/pull/23291 |
| pythongh-97943 | https://github.com/python/cpython/issues/97943 |
| python#97949 | https://github.com/python/cpython/pull/97949 |
| mpage | https://github.com/mpage |
|
Oct 11, 2022
| https://github.com/python/cpython/pull/97984#ref-commit-078e3ed |
|
| https://github.com/lysnikolaou |
|
| https://github.com/mpage |
| pythongh-97973 | https://github.com/python/cpython/issues/97973 |
| : Return all necessary information from the tokenizer ( | https://github.com/mpage/cpython/commit/078e3eddac3f46469962f8205580cdc6348e631d |
| p… | https://github.com/python/cpython/pull/97984 |
| 078e3ed | https://github.com/mpage/cpython/commit/078e3eddac3f46469962f8205580cdc6348e631d |
| …ythonGH-97984 | https://github.com/python/cpython/pull/97984 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97984 |
|
| https://github.com/pablogsal |
|
pablogsal
| https://github.com/pablogsal |
|
| https://github.com/python/cpython/pull/97984/files/689c670ae876baba229ee4bdd85ab02872600e8c |
|
Tokenizer returnings pointers make calculation of position info more complicated
| https://github.com/python/cpython/issues/97973 |
| Please reload this page | https://github.com/python/cpython/pull/97984 |
|
| https://github.com/lysnikolaou |
|
| https://github.com/pablogsal |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |