René's URL Explorer Experiment


Title: gh-96078: os.sched_yield release the GIL while calling sched_yield(2). by corona10 · Pull Request #97965 · python/cpython · GitHub

Open Graph Title: gh-96078: os.sched_yield release the GIL while calling sched_yield(2). by corona10 · Pull Request #97965 · python/cpython

X Title: gh-96078: os.sched_yield release the GIL while calling sched_yield(2). by corona10 · Pull Request #97965 · python/cpython

Description: Issue: The os.sched_yield() implementation in posixmodule.c doesn't release the GIL #96078

Open Graph Description: Issue: The os.sched_yield() implementation in posixmodule.c doesn't release the GIL #96078

X Description: Issue: The os.sched_yield() implementation in posixmodule.c doesn't release the GIL #96078

Opengraph URL: https://github.com/python/cpython/pull/97965

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76719216-050d-1894-b425-78694ef41b0f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD6C:280F84:3D41D3:55062E:696A2079
html-safe-nonce83947f1eab06e214d60023a54ee1941d38c88a31147136e371c373b9a310df0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDZDOjI4MEY4NDozRDQxRDM6NTUwNjJFOjY5NkEyMDc5IiwidmlzaXRvcl9pZCI6IjExNDE1MzQ3NjUxMjY4NjIwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8cdb6e84be1b996bbb7ad0a25bda8f76c22655ea890857654c7ba3e0e26ee650
hovercard-subject-tagpull_request:1079241728
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/97965/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bfe7dcdb72c5f32fd3b9090da91a76af4005ce80cd65df375fc01c54d5f322a6/python/cpython/pull/97965
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bfe7dcdb72c5f32fd3b9090da91a76af4005ce80cd65df375fc01c54d5f322a6/python/cpython/pull/97965
og:image:altIssue: The os.sched_yield() implementation in posixmodule.c doesn't release the GIL #96078
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecorona10
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/97965#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97965
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97965
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/97965
Reloadhttps://github.com/python/cpython/pull/97965
Reloadhttps://github.com/python/cpython/pull/97965
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/97965
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/97965
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/97965#issue-comment-box
benjaminphttps://github.com/benjaminp
python:mainhttps://github.com/python/cpython/tree/main
corona10:gh-96078https://github.com/corona10/cpython/tree/gh-96078
gh-96078: os.sched_yield release the GIL while calling sched_yield(2). https://github.com/python/cpython/pull/97965#top
benjaminphttps://github.com/benjaminp
python:mainhttps://github.com/python/cpython/tree/main
corona10:gh-96078https://github.com/corona10/cpython/tree/gh-96078
Conversation 6 https://github.com/python/cpython/pull/97965
Commits 1 https://github.com/python/cpython/pull/97965/commits
Checks 0 https://github.com/python/cpython/pull/97965/checks
Files changed https://github.com/python/cpython/pull/97965/files
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/corona10
corona10https://github.com/corona10
Oct 6, 2022https://github.com/python/cpython/pull/97965#issue-1399904133
Please reload this pagehttps://github.com/python/cpython/pull/97965
The os.sched_yield() implementation in posixmodule.c doesn't release the GIL #96078https://github.com/python/cpython/issues/96078
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.com/corona10
corona10https://github.com/corona10
vstinnerhttps://github.com/vstinner
October 6, 2022 15:47https://github.com/python/cpython/pull/97965#event-7536401501
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 6, 2022https://github.com/python/cpython/pull/97965#event-7536401834
https://github.com/corona10
corona10https://github.com/corona10
Oct 6, 2022https://github.com/python/cpython/pull/97965#issuecomment-1270304628
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Oct 6, 2022 https://github.com/python/cpython/pull/97965#pullrequestreview-1133336743
View reviewed changes https://github.com/python/cpython/pull/97965/files
kumaraditya303https://github.com/kumaraditya303
https://github.com/python/cpython/pull/97965#pullrequestreview-1133336743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.com/corona10
pythongh-96078https://github.com/python/cpython/issues/96078
: os.sched_yield release the GIL while calling sched_yi…https://github.com/python/cpython/pull/97965/commits/40c572550256d756e5e6d52d6b61573afe932e32
40c5725https://github.com/python/cpython/pull/97965/commits/40c572550256d756e5e6d52d6b61573afe932e32
https://github.com/corona10
corona10https://github.com/corona10
force-pushedhttps://github.com/python/cpython/compare/5f150a8978ffa585c90ceae1840fb14eb79c31c9..40c572550256d756e5e6d52d6b61573afe932e32
5f150a8https://github.com/python/cpython/commit/5f150a8978ffa585c90ceae1840fb14eb79c31c9
40c5725https://github.com/python/cpython/commit/40c572550256d756e5e6d52d6b61573afe932e32
Compare https://github.com/python/cpython/compare/5f150a8978ffa585c90ceae1840fb14eb79c31c9..40c572550256d756e5e6d52d6b61573afe932e32
October 6, 2022 22:03https://github.com/python/cpython/pull/97965#event-7538973147
https://github.com/benjaminp
benjaminphttps://github.com/benjaminp
b9d2e81https://github.com/python/cpython/commit/b9d2e8171696514e9226164005f7bf24bf69e66d
Oct 6, 2022https://github.com/python/cpython/pull/97965#event-7539208423
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 6, 2022https://github.com/python/cpython/pull/97965#event-7539208557
carljmhttps://github.com/carljm
Oct 6, 2022 https://github.com/python/cpython/pull/97965#ref-commit-e5d2169
https://github.com/carljm
Merge branch 'main' into dictwatchhttps://github.com/carljm/cpython/commit/e5d21693de54c37116e644af52fa5fa638b0c583
e5d2169https://github.com/carljm/cpython/commit/e5d21693de54c37116e644af52fa5fa638b0c583
pythongh-96078https://github.com/python/cpython/issues/96078
pythongh-97965https://github.com/python/cpython/pull/97965
pythongh-65961https://github.com/python/cpython/issues/65961
pythonGH-97990https://github.com/python/cpython/pull/97990
pythongh-97850https://github.com/python/cpython/issues/97850
python#97935https://github.com/python/cpython/pull/97935
pythonGH-97992https://github.com/python/cpython/pull/97992
pythongh-94590https://github.com/python/cpython/issues/94590
python#94591https://github.com/python/cpython/pull/94591
python#97974https://github.com/python/cpython/pull/97974
pythongh-97781https://github.com/python/cpython/issues/97781
pythonGH-97785https://github.com/python/cpython/pull/97785
pythongh-86482https://github.com/python/cpython/issues/86482
python#23291https://github.com/python/cpython/pull/23291
pythongh-97943https://github.com/python/cpython/issues/97943
python#97949https://github.com/python/cpython/pull/97949
pythongh-94808https://github.com/python/cpython/issues/94808
python#95926https://github.com/python/cpython/pull/95926
https://github.com/corona10
corona10https://github.com/corona10
October 7, 2022 00:34https://github.com/python/cpython/pull/97965#event-7539553086
https://github.com/corona10
corona10https://github.com/corona10
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Oct 7, 2022https://github.com/python/cpython/pull/97965#event-7540222146
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2022https://github.com/python/cpython/pull/97965#issuecomment-1271078064
@corona10https://github.com/corona10
@benjaminphttps://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2022https://github.com/python/cpython/pull/97965#issuecomment-1271078065
@corona10https://github.com/corona10
@benjaminphttps://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 7, 2022https://github.com/python/cpython/pull/97965#issuecomment-1271078184
GH-98013https://github.com/python/cpython/pull/98013
3.10 branchhttps://github.com/python/cpython/tree/3.10
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Oct 7, 2022https://github.com/python/cpython/pull/97965#event-7540223190
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 7, 2022https://github.com/python/cpython/pull/97965#issuecomment-1271078222
GH-98014https://github.com/python/cpython/pull/98014
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/97965
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2022 https://github.com/python/cpython/pull/97965#ref-commit-920e025
https://github.com/corona10
https://github.com/miss-islington
fixeshttps://github.com/miss-islington/cpython/commit/920e025c8b515527d16eba3ffd0568bacfe7212e
pythongh-96078https://github.com/python/cpython/issues/96078
: os.sched_yield release the GIL while calling sc…https://github.com/miss-islington/cpython/commit/920e025c8b515527d16eba3ffd0568bacfe7212e
920e025https://github.com/miss-islington/cpython/commit/920e025c8b515527d16eba3ffd0568bacfe7212e
pythongh-97965https://github.com/python/cpython/pull/97965
b9d2e81https://github.com/miss-islington/cpython/commit/b9d2e8171696514e9226164005f7bf24bf69e66d
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2022 https://github.com/python/cpython/pull/97965#ref-commit-4a38944
https://github.com/corona10
https://github.com/miss-islington
fixeshttps://github.com/miss-islington/cpython/commit/4a38944ef5f78408692bc95431b676e10f91d788
pythongh-96078https://github.com/python/cpython/issues/96078
: os.sched_yield release the GIL while calling sc…https://github.com/miss-islington/cpython/commit/4a38944ef5f78408692bc95431b676e10f91d788
4a38944https://github.com/miss-islington/cpython/commit/4a38944ef5f78408692bc95431b676e10f91d788
pythongh-97965https://github.com/python/cpython/pull/97965
b9d2e81https://github.com/miss-islington/cpython/commit/b9d2e8171696514e9226164005f7bf24bf69e66d
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2022 https://github.com/python/cpython/pull/97965#ref-commit-e39b511
https://github.com/miss-islington
https://github.com/corona10
fixeshttps://github.com/python/cpython/commit/e39b511c2bfa98935e6ff81046d64d342fcff298
gh-96078https://github.com/python/cpython/issues/96078
: os.sched_yield release the GIL while calling sched_yi…https://github.com/python/cpython/commit/e39b511c2bfa98935e6ff81046d64d342fcff298
e39b511https://github.com/python/cpython/commit/e39b511c2bfa98935e6ff81046d64d342fcff298
gh-97965https://github.com/python/cpython/pull/97965
b9d2e81https://github.com/python/cpython/commit/b9d2e8171696514e9226164005f7bf24bf69e66d
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2022 https://github.com/python/cpython/pull/97965#ref-commit-11945f2
https://github.com/miss-islington
https://github.com/corona10
fixeshttps://github.com/python/cpython/commit/11945f2cf6ae4aeb8202f481e8881ec0fbfabe89
gh-96078https://github.com/python/cpython/issues/96078
: os.sched_yield release the GIL while calling sched_yi…https://github.com/python/cpython/commit/11945f2cf6ae4aeb8202f481e8881ec0fbfabe89
11945f2https://github.com/python/cpython/commit/11945f2cf6ae4aeb8202f481e8881ec0fbfabe89
gh-97965https://github.com/python/cpython/pull/97965
b9d2e81https://github.com/python/cpython/commit/b9d2e8171696514e9226164005f7bf24bf69e66d
carljmhttps://github.com/carljm
Oct 8, 2022 https://github.com/python/cpython/pull/97965#ref-commit-415ed49
https://github.com/carljm
Merge branch 'main' into typewatchhttps://github.com/carljm/cpython/commit/415ed492de0dc27707962eb1756cf183dadd0885
415ed49https://github.com/carljm/cpython/commit/415ed492de0dc27707962eb1756cf183dadd0885
pythonGH-97002https://github.com/python/cpython/issues/97002
pythonGH-97996https://github.com/python/cpython/pull/97996
pythongh-97973https://github.com/python/cpython/issues/97973
pythonGH-97984https://github.com/python/cpython/pull/97984
pythongh-96078https://github.com/python/cpython/issues/96078
pythongh-97965https://github.com/python/cpython/pull/97965
pythongh-65961https://github.com/python/cpython/issues/65961
pythonGH-97990https://github.com/python/cpython/pull/97990
pythongh-97850https://github.com/python/cpython/issues/97850
python#97935https://github.com/python/cpython/pull/97935
pythonGH-97992https://github.com/python/cpython/pull/97992
pythongh-94590https://github.com/python/cpython/issues/94590
python#94591https://github.com/python/cpython/pull/94591
python#97974https://github.com/python/cpython/pull/97974
pythongh-97781https://github.com/python/cpython/issues/97781
pythonGH-97785https://github.com/python/cpython/pull/97785
pythongh-86482https://github.com/python/cpython/issues/86482
python#23291https://github.com/python/cpython/pull/23291
pythongh-97943https://github.com/python/cpython/issues/97943
python#97949https://github.com/python/cpython/pull/97949
mpagehttps://github.com/mpage
Oct 11, 2022 https://github.com/python/cpython/pull/97965#ref-commit-0c970bd
https://github.com/corona10
https://github.com/mpage
fixeshttps://github.com/mpage/cpython/commit/0c970bdae97f29c098272170b4564b0d16a5c22c
pythongh-96078https://github.com/python/cpython/issues/96078
: os.sched_yield release the GIL while calling sc…https://github.com/mpage/cpython/commit/0c970bdae97f29c098272170b4564b0d16a5c22c
0c970bdhttps://github.com/mpage/cpython/commit/0c970bdae97f29c098272170b4564b0d16a5c22c
pythongh-97965https://github.com/python/cpython/pull/97965
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97965
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/97965/files/5f150a8978ffa585c90ceae1840fb14eb79c31c9
https://github.com/vstinner
vstinner https://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/97965
https://github.com/corona10
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/kumaraditya303
https://github.com/benjaminp
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.