René's URL Explorer Experiment


Title: gh-97591: In `Exception.__setstate__()`, acquire strong reference before calling `tp_hash` slot. by ofey404 · Pull Request #97700 · python/cpython · GitHub

Open Graph Title: gh-97591: In `Exception.__setstate__()`, acquire strong reference before calling `tp_hash` slot. by ofey404 · Pull Request #97700 · python/cpython

X Title: gh-97591: In `Exception.__setstate__()`, acquire strong reference before calling `tp_hash` slot. by ofey404 · Pull Request #97700 · python/cpython

Description: Added an Py_INCREF / Py_DECREF pair around the call of tp_hash slot in Exception.__setstate__(). If the last reference of dict value is cleared (by dict.clear()), during the __setstate__ method call, it would cause gc crash. A script to reproduce this is in #97591 : import gc class Key(str): def __hash__(self): d.clear() return 0 class Value(str): pass d = {} d[Key()] = Value() e = Exception() e.__setstate__(d) gc.collect() # Segfault happens here Similiar issue: #92930 Issue: gh-97591

Open Graph Description: Added an Py_INCREF / Py_DECREF pair around the call of tp_hash slot in Exception.__setstate__(). If the last reference of dict value is cleared (by dict.clear()), during the __setstate__ method cal...

X Description: Added an Py_INCREF / Py_DECREF pair around the call of tp_hash slot in Exception.__setstate__(). If the last reference of dict value is cleared (by dict.clear()), during the __setstate__ method cal...

Opengraph URL: https://github.com/python/cpython/pull/97700

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:822d0d9e-0ac4-f961-c8c0-787f3e856c27
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA62E:337CEB:8CFFFB:BD43B6:69697B59
html-safe-nonce7c1187bde822e9cdda3b4021559aee68a10cce8a1a20b9717762a2e6b9f3f49b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjJFOjMzN0NFQjo4Q0ZGRkI6QkQ0M0I2OjY5Njk3QjU5IiwidmlzaXRvcl9pZCI6IjM3NjM3ODc0Mjc4ODkxMTgwNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5c2dfddcb5deb3b0f04468731e5942f11898b1aac61bbe0785ca897a458d42f
hovercard-subject-tagpull_request:1073477646
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/97700/files
twitter:imagehttps://avatars.githubusercontent.com/u/35857538?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35857538?s=400&v=4
og:image:altAdded an Py_INCREF / Py_DECREF pair around the call of tp_hash slot in Exception.__setstate__(). If the last reference of dict value is cleared (by dict.clear()), during the __setstate__ method cal...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/97700/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97700%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97700%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/97700/files
Reloadhttps://github.com/python/cpython/pull/97700/files
Reloadhttps://github.com/python/cpython/pull/97700/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/97700/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/97700/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
ofey404:ofey404/gh-97591-exception-setstate-strong-referencehttps://github.com/ofey404/cpython/tree/ofey404/gh-97591-exception-setstate-strong-reference
Conversation 8 https://github.com/python/cpython/pull/97700
Commits 4 https://github.com/python/cpython/pull/97700/commits
Checks 0 https://github.com/python/cpython/pull/97700/checks
Files changed https://github.com/python/cpython/pull/97700/files
Please reload this pagehttps://github.com/python/cpython/pull/97700/files
gh-97591: In Exception.__setstate__(), acquire strong reference before calling tp_hash slot. https://github.com/python/cpython/pull/97700/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/97700/files
859e993 patch BaseException_setstate and its test. ofey404 Oct 1, 2022 https://github.com/python/cpython/pull/97700/commits/859e99374ddd9496cc3acd4705ad6c16cdd87feb
d86ff33 📜🤖 Added by blurb_it. blurb-it[bot] Oct 1, 2022 https://github.com/python/cpython/pull/97700/commits/d86ff33a0f380c0a87704d05b0d7ff2259bf99d9
0028446 Patchcheck. ofey404 Oct 1, 2022 https://github.com/python/cpython/pull/97700/commits/002844648d3fdff0bd04f776a02f357a71c0e326
b5dfd41 Update Misc/NEWS.d/next/Core and Builtins/2022-10-01-08-55-09.gh-issu… ofey404 Oct 2, 2022 https://github.com/python/cpython/pull/97700/commits/b5dfd41a699a7f13f5ea7963ac696bfdf807dee4
Clear filters https://github.com/python/cpython/pull/97700/files
Please reload this pagehttps://github.com/python/cpython/pull/97700/files
Please reload this pagehttps://github.com/python/cpython/pull/97700/files
test_baseexception.py https://github.com/python/cpython/pull/97700/files#diff-4a522bdd2ce8793e9957983249a398ff5ac40eefe4497a21db3f42fc6f5bb063
2022-10-01-08-55-09.gh-issue-97591.pw6kkH.rst https://github.com/python/cpython/pull/97700/files#diff-79f5f7644a5b28c22a20c0fd0c366ae7764bc66a092030205212f29c5825eb79
exceptions.c https://github.com/python/cpython/pull/97700/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
Lib/test/test_baseexception.pyhttps://github.com/python/cpython/pull/97700/files#diff-4a522bdd2ce8793e9957983249a398ff5ac40eefe4497a21db3f42fc6f5bb063
View file https://github.com/ofey404/cpython/blob/b5dfd41a699a7f13f5ea7963ac696bfdf807dee4/Lib/test/test_baseexception.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/97700/{{ revealButtonHref }}
https://github.com/python/cpython/pull/97700/files#diff-4a522bdd2ce8793e9957983249a398ff5ac40eefe4497a21db3f42fc6f5bb063
https://github.com/python/cpython/pull/97700/files#diff-4a522bdd2ce8793e9957983249a398ff5ac40eefe4497a21db3f42fc6f5bb063
Misc/NEWS.d/next/Core and Builtins/2022-10-01-08-55-09.gh-issue-97591.pw6kkH.rsthttps://github.com/python/cpython/pull/97700/files#diff-79f5f7644a5b28c22a20c0fd0c366ae7764bc66a092030205212f29c5825eb79
View file https://github.com/ofey404/cpython/blob/b5dfd41a699a7f13f5ea7963ac696bfdf807dee4/Misc/NEWS.d/next/Core%20and%20Builtins/2022-10-01-08-55-09.gh-issue-97591.pw6kkH.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/97700/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L247
Objects/exceptions.chttps://github.com/python/cpython/pull/97700/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
View file https://github.com/ofey404/cpython/blob/b5dfd41a699a7f13f5ea7963ac696bfdf807dee4/Objects/exceptions.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/97700/{{ revealButtonHref }}
https://github.com/python/cpython/pull/97700/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/pull/97700/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.