René's URL Explorer Experiment


Title: bpo-34936: Fix TclError in tkinter.Spinbox.selection_element() by j4321 · Pull Request #9760 · python/cpython · GitHub

Open Graph Title: bpo-34936: Fix TclError in tkinter.Spinbox.selection_element() by j4321 · Pull Request #9760 · python/cpython

X Title: bpo-34936: Fix TclError in tkinter.Spinbox.selection_element() by j4321 · Pull Request #9760 · python/cpython

Description: Spinbox.selection_element() raises TclError: expected integer but got "none" while it should return the currently selected element according to the docstring. I removed the call to self._getints in Spinbox.selection since the result is never a string of integers. For consistency with the previous behavior, Spinbox.selection still returns () when the result of self.tk.call((self._w, 'selection') + args) is an empty string. I added tests for the Spinbox.selection_element method. https://bugs.python.org/issue34936

Open Graph Description: Spinbox.selection_element() raises TclError: expected integer but got "none" while it should return the currently selected element according to the docstring. I removed the call to self....

X Description: Spinbox.selection_element() raises TclError: expected integer but got "none" while it should return the currently selected element according to the docstring. I removed the call ...

Opengraph URL: https://github.com/python/cpython/pull/9760

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ed97a6c0-500f-da9f-8bab-8d2114eb14de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE64E:29B748:CF34F6:11F58AA:6A53AB3C
html-safe-nonce9a61bee74560c6564deef6ce535533421cb1877b457b90897071ff4fefce9fb5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjRFOjI5Qjc0ODpDRjM0RjY6MTFGNThBQTo2QTUzQUIzQyIsInZpc2l0b3JfaWQiOiI3NjM0MTc2MDYyNTcwODY3NTE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac00441a452b8d6d2a65f81fc09cd8996497e9b2a9830ac564a3f04c97fdbeedab
hovercard-subject-tagpull_request:221220844
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/9760/files
twitter:imagehttps://avatars.githubusercontent.com/u/18469869?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18469869?s=400&v=4
og:image:altSpinbox.selection_element() raises TclError: expected integer but got "none" while it should return the currently selected element according to the docstring. I removed the call to self....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9760/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9760%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9760%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9760/files
Reloadhttps://github.com/python/cpython/pull/9760/files
Reloadhttps://github.com/python/cpython/pull/9760/files
Please reload this pagehttps://github.com/python/cpython/pull/9760/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9760/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
j4321:fix-issue-34936https://github.com/j4321/cpython/tree/fix-issue-34936
Conversation 16 https://github.com/python/cpython/pull/9760
Commits 7 https://github.com/python/cpython/pull/9760/commits
Checks 0 https://github.com/python/cpython/pull/9760/checks
Files changed https://github.com/python/cpython/pull/9760/files
Please reload this pagehttps://github.com/python/cpython/pull/9760/files
bpo-34936: Fix TclError in tkinter.Spinbox.selection_element() https://github.com/python/cpython/pull/9760/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/9760/files
1c8752f Fix TclError in tkinter.Spinbox.selection_element() j4321 Oct 8, 2018 https://github.com/python/cpython/pull/9760/commits/1c8752f4bdad9611a727e0487168695e5a5f0fb5
8e26a49 Revert tkinter.Spinbox.selection() modifications j4321 Oct 18, 2018 https://github.com/python/cpython/pull/9760/commits/8e26a49d2ecd87594756e9438c9df93f767ebf52
e3f2649 Fix tkinter.Spinbox.selection_ methods docstrings j4321 Oct 18, 2018 https://github.com/python/cpython/pull/9760/commits/e3f264989032d043e13ad9690258aca8441f2482
d1533e9 Fix tkinter.Spinbox.selection_element() j4321 Oct 18, 2018 https://github.com/python/cpython/pull/9760/commits/d1533e9dfb1f4f798d64012155713a5cd602584b
a6014f3 Remove useless part in tkinter.Spinbox.selection_ methods docstrings j4321 Oct 18, 2018 https://github.com/python/cpython/pull/9760/commits/a6014f3da56667b55b55bad19a1d1c85945cf4cd
11182f1 Put tkinter.Spinbox.selection_element() tests in a separate method j4321 Oct 18, 2018 https://github.com/python/cpython/pull/9760/commits/11182f19dffc5445200b3f3ce90e26fb811c2456
07e5acd Rename tkinter.Spinbox.selection_element() test method j4321 Oct 18, 2018 https://github.com/python/cpython/pull/9760/commits/07e5acd8d6898e3150d8735a5a484169ae6881a9
Clear filters https://github.com/python/cpython/pull/9760/files
Please reload this pagehttps://github.com/python/cpython/pull/9760/files
Please reload this pagehttps://github.com/python/cpython/pull/9760/files
__init__.py https://github.com/python/cpython/pull/9760/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
test_widgets.py https://github.com/python/cpython/pull/9760/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
2018-10-08-21-05-11.bpo-34936.3tRqdq.rst https://github.com/python/cpython/pull/9760/files#diff-3191b7bab99767d999881ae61f8f62c72693a3f8288f3cd78ed60379a5d3e485
Lib/tkinter/__init__.pyhttps://github.com/python/cpython/pull/9760/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
View file https://github.com/j4321/cpython/blob/07e5acd8d6898e3150d8735a5a484169ae6881a9/Lib/tkinter/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9760/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9760/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
https://github.com/python/cpython/pull/9760/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
Lib/tkinter/test/test_tkinter/test_widgets.pyhttps://github.com/python/cpython/pull/9760/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
View file https://github.com/j4321/cpython/blob/07e5acd8d6898e3150d8735a5a484169ae6881a9/Lib/tkinter/test/test_tkinter/test_widgets.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9760/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9760/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
Please reload this pagehttps://github.com/python/cpython/pull/9760/files
https://github.com/python/cpython/pull/9760/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
Misc/NEWS.d/next/Library/2018-10-08-21-05-11.bpo-34936.3tRqdq.rsthttps://github.com/python/cpython/pull/9760/files#diff-3191b7bab99767d999881ae61f8f62c72693a3f8288f3cd78ed60379a5d3e485
View file https://github.com/j4321/cpython/blob/07e5acd8d6898e3150d8735a5a484169ae6881a9/Misc/NEWS.d/next/Library/2018-10-08-21-05-11.bpo-34936.3tRqdq.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9760/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.