René's URL Explorer Experiment


Title: bpo-34844: logging.Formatter enhancement - Ensure styles and fmt matches in logging.Formatter by BNMetrics · Pull Request #9703 · python/cpython · GitHub

Open Graph Title: bpo-34844: logging.Formatter enhancement - Ensure styles and fmt matches in logging.Formatter by BNMetrics · Pull Request #9703 · python/cpython

X Title: bpo-34844: logging.Formatter enhancement - Ensure styles and fmt matches in logging.Formatter by BNMetrics · Pull Request #9703 · python/cpython

Description: As discussed with @vsajip, I have made the following changes: Added validate method in each format style class: StrFormatStyle, PercentStyle, StringTemplateStyle. This method is called in the constructor of logging.Formatter class Also re-raise the KeyError in the format method of each style class, so it would a bit clear that it's an error with the invalid format fields. https://bugs.python.org/issue34844

Open Graph Description: As discussed with @vsajip, I have made the following changes: Added validate method in each format style class: StrFormatStyle, PercentStyle, StringTemplateStyle. This method is called in the cons...

X Description: As discussed with @vsajip, I have made the following changes: Added validate method in each format style class: StrFormatStyle, PercentStyle, StringTemplateStyle. This method is called in the cons...

Opengraph URL: https://github.com/python/cpython/pull/9703

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0e40af34-7749-7927-bfa0-3ca685577aee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A9C:1A6FEB:1A666D3:2429DC9:6A53FB6B
html-safe-nonceeaaa218b92108c8510e99d96ca79e95c6b79062845d23209d87bc6191b5e9d15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTlDOjFBNkZFQjoxQTY2NkQzOjI0MjlEQzk6NkE1M0ZCNkIiLCJ2aXNpdG9yX2lkIjoiNjIyNTI2Njk5MDkyOTY3MzA2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacccabbaa901587824ae20fb50dfb3c030c8847a0165b33162abfac985099a5b87
hovercard-subject-tagpull_request:220492813
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/9703/files
twitter:imagehttps://avatars.githubusercontent.com/u/24975007?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24975007?s=400&v=4
og:image:altAs discussed with @vsajip, I have made the following changes: Added validate method in each format style class: StrFormatStyle, PercentStyle, StringTemplateStyle. This method is called in the cons...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9703/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9703%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9703%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9703/files
Reloadhttps://github.com/python/cpython/pull/9703/files
Reloadhttps://github.com/python/cpython/pull/9703/files
Please reload this pagehttps://github.com/python/cpython/pull/9703/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9703/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vsajiphttps://github.com/vsajip
python:masterhttps://github.com/python/cpython/tree/master
Conversation 51 https://github.com/python/cpython/pull/9703
Commits 21 https://github.com/python/cpython/pull/9703/commits
Checks 0 https://github.com/python/cpython/pull/9703/checks
Files changed https://github.com/python/cpython/pull/9703/files
Please reload this pagehttps://github.com/python/cpython/pull/9703/files
bpo-34844: logging.Formatter enhancement - Ensure styles and fmt matches in logging.Formatter https://github.com/python/cpython/pull/9703/files#top
Show all changes 21 commits https://github.com/python/cpython/pull/9703/files
66bbddf bpo-34844 BNMetrics Oct 4, 2018 https://github.com/python/cpython/pull/9703/commits/66bbddfd08ef9d052eb8e43ee550feea62616c5b
0eaaf25 added news entry BNMetrics Oct 4, 2018 https://github.com/python/cpython/pull/9703/commits/0eaaf25557a87a19595c50a43b79395dad3a1b2c
f4f6a60 suggested changed before regex fix BNMetrics Oct 5, 2018 https://github.com/python/cpython/pull/9703/commits/f4f6a60804b66c0b9ffc0547efb0072c4d30e41e
d51e186 regex changes BNMetrics Oct 6, 2018 https://github.com/python/cpython/pull/9703/commits/d51e1867976f51b100903747daee75615a37ad02
cc2cfbd commit BNMetrics Oct 6, 2018 https://github.com/python/cpython/pull/9703/commits/cc2cfbda4b47c85b5a9a254dcde13cdbb9a8af88
7c24e46 rewrote regex BNMetrics Oct 6, 2018 https://github.com/python/cpython/pull/9703/commits/7c24e469a95d943936ccf6975606c8d53a3c6a83
abd868d changes as requested BNMetrics Oct 7, 2018 https://github.com/python/cpython/pull/9703/commits/abd868d0cf89d69814355c9ca51ac55a761cec27
c1359bb changes as requested BNMetrics Oct 7, 2018 https://github.com/python/cpython/pull/9703/commits/c1359bb69c517fbda011b3f01d1aee3b2bece867
921ba33 added doc and docstring, added some of the original tests back for $ … BNMetrics Oct 8, 2018 https://github.com/python/cpython/pull/9703/commits/921ba331d8dddffb373105f752c39a42a5629a1a
8484f29 changed validate method for StrFormatStyle BNMetrics Oct 9, 2018 https://github.com/python/cpython/pull/9703/commits/8484f296872c1e87ad41e562f09af44e70de484b
4c35216 changed on StrFormatStyle class BNMetrics Oct 10, 2018 https://github.com/python/cpython/pull/9703/commits/4c35216c40ba42d9f52486f1bba1b60b6b27dabe
6eee298 commit BNMetrics Oct 12, 2018 https://github.com/python/cpython/pull/9703/commits/6eee29811da339dd741fd3eef1b01a1fbd1ee2e6
aab0c46 removed redundant debugging print BNMetrics Oct 13, 2018 https://github.com/python/cpython/pull/9703/commits/aab0c4622eb2be3866bd4409a563c58f13d58071
59879e9 added options to logging.config.dictConfig to allow passing in valida… BNMetrics Oct 13, 2018 https://github.com/python/cpython/pull/9703/commits/59879e92bb00e5a5d6b599489a733383e7a0fcb0
43c0b34 added in documentation for the validate key in logging.config.dictConfig BNMetrics Oct 13, 2018 https://github.com/python/cpython/pull/9703/commits/43c0b344237f9f83d9504fdbdf2afca02f0f6564
908c3ec removing blank space BNMetrics Oct 14, 2018 https://github.com/python/cpython/pull/9703/commits/908c3ec74a73b45c9721552a6d32c6cabfc7880c
d73ab3a rewrote logging.config.DictConfigurator.configure_formatter logic, si… BNMetrics Oct 14, 2018 https://github.com/python/cpython/pull/9703/commits/d73ab3adcd5a04cfa7c42c04169e296b0241ef1a
ff05742 document typo change on logging.rst BNMetrics Oct 14, 2018 https://github.com/python/cpython/pull/9703/commits/ff05742c5ba05d062c4ff14ee7790d7f969b2eee
2664f85 reformatted logging.config.rst BNMetrics Oct 14, 2018 https://github.com/python/cpython/pull/9703/commits/2664f85ea4f8336ac620136cbf814021a2fb5e72
74ca6a2 simplified the logic in logging.config.DictConfig.configure_formatter BNMetrics Oct 15, 2018 https://github.com/python/cpython/pull/9703/commits/74ca6a26a288428ec4dd5e616624f36b4d00c396
de1243f fixed document due to failure BNMetrics Oct 15, 2018 https://github.com/python/cpython/pull/9703/commits/de1243f4d03074a8712c89fc45508150fd677176
Clear filters https://github.com/python/cpython/pull/9703/files
Please reload this pagehttps://github.com/python/cpython/pull/9703/files
Please reload this pagehttps://github.com/python/cpython/pull/9703/files
logging.config.rst https://github.com/python/cpython/pull/9703/files#diff-74c0068c89bb9c9fbe3c81b27e9f630afc6973fbc8a258aee0e6b469651164d2
logging.rst https://github.com/python/cpython/pull/9703/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb
__init__.py https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
config.py https://github.com/python/cpython/pull/9703/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
test_logging.py https://github.com/python/cpython/pull/9703/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
2018-10-04-20-44-45.bpo-34844.Hnuxav.rst https://github.com/python/cpython/pull/9703/files#diff-03b8d8f537b86d6f47f31ab08dc3ad0cc9c5870c85a2488c7a747aebacd8e431
Doc/library/logging.config.rsthttps://github.com/python/cpython/pull/9703/files#diff-74c0068c89bb9c9fbe3c81b27e9f630afc6973fbc8a258aee0e6b469651164d2
View file https://github.com/python/cpython/blob/de1243f4d03074a8712c89fc45508150fd677176/Doc/library/logging.config.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9703/files#diff-74c0068c89bb9c9fbe3c81b27e9f630afc6973fbc8a258aee0e6b469651164d2
https://github.com/python/cpython/pull/9703/files#diff-74c0068c89bb9c9fbe3c81b27e9f630afc6973fbc8a258aee0e6b469651164d2
Doc/library/logging.rsthttps://github.com/python/cpython/pull/9703/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb
View file https://github.com/python/cpython/blob/de1243f4d03074a8712c89fc45508150fd677176/Doc/library/logging.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9703/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb
https://github.com/python/cpython/pull/9703/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb
Lib/logging/__init__.pyhttps://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
View file https://github.com/python/cpython/blob/de1243f4d03074a8712c89fc45508150fd677176/Lib/logging/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
Please reload this pagehttps://github.com/python/cpython/pull/9703/files
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
https://github.com/python/cpython/pull/9703/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98
Lib/logging/config.pyhttps://github.com/python/cpython/pull/9703/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
View file https://github.com/python/cpython/blob/de1243f4d03074a8712c89fc45508150fd677176/Lib/logging/config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9703/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
https://github.com/python/cpython/pull/9703/files#diff-6b781e2294c88b6a18e9be5d536be2afb74f22593ec5be3de3bc3b507d955755
Please reload this pagehttps://github.com/python/cpython/pull/9703/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.