| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:87b7a7bc-616e-79d1-d518-a66bc8608847 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D8B0:310BDB:3F780AA:587145A:6A4F5FF9 |
| html-safe-nonce | 894606f655c76ebac6efec33400f530e04708ff5575f54eebe321f7f14f642e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEIwOjMxMEJEQjozRjc4MEFBOjU4NzE0NUE6NkE0RjVGRjkiLCJ2aXNpdG9yX2lkIjoiNjY3NTgzNjc3OTk5ODY5OTUxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c2500ff151e06f1fd6d84a49234b13834246118a411a53db5690ce3e15e30386 |
| hovercard-subject-tag | pull_request:1064314862 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/97015/files |
| twitter:image | https://avatars.githubusercontent.com/u/59611075?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/59611075?s=400&v=4 |
| og:image:alt | This is a reincarnation of the already marked as awaiting merge PR 22431, which was subsequently closed due to some git mistake.
This PR fixes issue 58451: tempfile.NamedTemporaryFile not particul... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/97015/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97015%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F97015%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/97015/files |
| Reload | https://github.com/python/cpython/pull/97015/files |
| Reload | https://github.com/python/cpython/pull/97015/files |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| zooba | https://github.com/zooba |
| python:main | https://github.com/python/cpython/tree/main |
| Ev2geny:fix-issue-14243 | https://github.com/Ev2geny/cpython/tree/fix-issue-14243 |
|
Conversation
73
| https://github.com/python/cpython/pull/97015 |
|
Commits
26
| https://github.com/python/cpython/pull/97015/commits |
|
Checks
0
| https://github.com/python/cpython/pull/97015/checks |
|
Files changed
| https://github.com/python/cpython/pull/97015/files |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
|
gh-58451: Add optional delete_on_close parameter to NamedTemporaryFile
| https://github.com/python/cpython/pull/97015/files#top |
|
Show all changes
26 commits
| https://github.com/python/cpython/pull/97015/files |
|
3df957c
Brought the same changes as in now closed PR 22431, but to the latest…
Ev2geny Sep 21, 2022
| https://github.com/python/cpython/pull/97015/commits/3df957c5d7c85abefb905886ef600fdcc4d7ef00 |
|
c4cf39f
Based on the review from @eryksun the code and the documentation is u…
Ev2geny Sep 22, 2022
| https://github.com/python/cpython/pull/97015/commits/c4cf39f916abd84779e5f59363759308299ed09e |
|
ac0b241
documentation is slightly corrected
Ev2geny Sep 22, 2022
| https://github.com/python/cpython/pull/97015/commits/ac0b241572cae7527a5c4fdc19e9a8f16287aad2 |
|
384614f
minor documentation update
Ev2geny Sep 22, 2022
| https://github.com/python/cpython/pull/97015/commits/384614fd09f9dedaf995a35b348710b755916505 |
|
0e0b6ba
Update Doc/whatsnew/3.12.rst
Ev2geny Sep 22, 2022
| https://github.com/python/cpython/pull/97015/commits/0e0b6ba04d62ae6be33abbbc3ed042584908bd4c |
|
cc81ab5
Deletion of file upon finalization is moved from _TemporaryFileWrappe…
Ev2geny Sep 23, 2022
| https://github.com/python/cpython/pull/97015/commits/cc81ab5478d9cc17620a17906c0612bee74339b8 |
|
5af6150
Some additions to Lib/test/test_tempfile.py
Ev2geny Sep 24, 2022
| https://github.com/python/cpython/pull/97015/commits/5af6150aef9911bd4fe2a03b19e25f60ad794f5c |
|
239354e
clearing of the files in the situation when delete and not delete_on_…
Ev2geny Sep 24, 2022
| https://github.com/python/cpython/pull/97015/commits/239354e2e4a09914cd9fac0847e9d883c84c0e08 |
|
5de68c0
if statement is added to avoid errors, when testing. Not sure 100% is…
Ev2geny Sep 24, 2022
| https://github.com/python/cpython/pull/97015/commits/5de68c0556058c762572e8afe4c2981b38987a1b |
|
eef3439
Apply suggestions from code review
Ev2geny Sep 25, 2022
| https://github.com/python/cpython/pull/97015/commits/eef343984e5d422fd3994fb233a696f313d89927 |
|
c9801ee
__del__ was defined twice in _TemporaryFileWrapper. Fixed now
Ev2geny Sep 25, 2022
| https://github.com/python/cpython/pull/97015/commits/c9801eec27f494cd5da99e7604e688adb21fa0be |
|
6944ab2
_TemporaryFileCloser is returned to original state and the logic, whi…
Ev2geny Sep 25, 2022
| https://github.com/python/cpython/pull/97015/commits/6944ab23e513861508fe643558efce47f178875e |
|
44f0664
All delete operations are moved to the class _TemporaryFileCloser
Ev2geny Sep 25, 2022
| https://github.com/python/cpython/pull/97015/commits/44f0664b3e28e5e0d40ff64238544258b27206ff |
|
1dfaf72
Minor update to comments
Ev2geny Sep 25, 2022
| https://github.com/python/cpython/pull/97015/commits/1dfaf72a90f41039ef7786eeac342993f61259da |
|
e54feb5
Whitespec fixes by patchcheck.py
Ev2geny Sep 25, 2022
| https://github.com/python/cpython/pull/97015/commits/e54feb5d8621f79ff8437d3209b80b997aa9d199 |
|
d2d1119
Update Lib/tempfile.py
Ev2geny Sep 26, 2022
| https://github.com/python/cpython/pull/97015/commits/d2d11194ba0648d6b83b0982cca418911fb2d3ac |
|
bd4b2dd
Update Lib/tempfile.py
Ev2geny Sep 26, 2022
| https://github.com/python/cpython/pull/97015/commits/bd4b2ddc10476bc0c817431da34bac1af1f37da5 |
|
29eeaff
Modified exception handling in NamedTemporaryFile
Ev2geny Sep 26, 2022
| https://github.com/python/cpython/pull/97015/commits/29eeaff60ec551fbdd96ea04a202597906334a01 |
|
5306b6d
Wrapping at 80 characters is fixed
Ev2geny Sep 26, 2022
| https://github.com/python/cpython/pull/97015/commits/5306b6dd52a7813cf8c93d49387106fcae2dadce |
|
1c99fb3
Update Lib/tempfile.py
Ev2geny Oct 1, 2022
| https://github.com/python/cpython/pull/97015/commits/1c99fb344efe837c139376bb802eeabf971ac7a9 |
|
29b89d3
Documentation update, based on the feedback from @zooba
Ev2geny Oct 1, 2022
| https://github.com/python/cpython/pull/97015/commits/29b89d3d543e898361af93058b8548f5717682e1 |
|
e586028
Minor PEP8 update based on the feedback from @zooba
Ev2geny Oct 1, 2022
| https://github.com/python/cpython/pull/97015/commits/e58602812bc23388c2eff31234223706cd49693d |
|
3eceb45
Improving comments in the init test file, based on the feedback from …
Ev2geny Oct 1, 2022
| https://github.com/python/cpython/pull/97015/commits/3eceb4549bc0529eddcacec4e0e54bc175d6f28f |
|
892e87d
Updating of documentation
Ev2geny Oct 2, 2022
| https://github.com/python/cpython/pull/97015/commits/892e87d5f0d9d082a796a0855519624c4f2e8bb4 |
|
67996b2
Merge branch 'fix-issue-14243' of https://github.com/Ev2geny/cpython …
Ev2geny Oct 2, 2022
| https://github.com/python/cpython/pull/97015/commits/67996b281bf652a08ae1f1ab07b507fd9627f0f8 |
|
07b963e
Apply suggestions from code review
zooba Oct 4, 2022
| https://github.com/python/cpython/pull/97015/commits/07b963e453a9d15086a819804803b982d7cd94aa |
|
Clear filters
| https://github.com/python/cpython/pull/97015/files |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
|
tempfile.rst
| https://github.com/python/cpython/pull/97015/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e |
|
3.12.rst
| https://github.com/python/cpython/pull/97015/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
tempfile.py
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
test_tempfile.py
| https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
|
2020-09-28-04-56-04.bpo-14243.YECnxv.rst
| https://github.com/python/cpython/pull/97015/files#diff-09f69cf5362a627144db1a8fbeca57decb67fca30c3cce67979b0acde1c4b9c9 |
| Doc/library/tempfile.rst | https://github.com/python/cpython/pull/97015/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e |
|
View file
| https://github.com/Ev2geny/cpython/blob/07b963e453a9d15086a819804803b982d7cd94aa/Doc/library/tempfile.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/97015/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/97015/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
|
| https://github.com/python/cpython/pull/97015/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e |
|
| https://github.com/python/cpython/pull/97015/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e |
|
| https://github.com/python/cpython/pull/97015/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e |
|
| https://github.com/python/cpython/pull/97015/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L116 |
| Doc/whatsnew/3.12.rst | https://github.com/python/cpython/pull/97015/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
View file
| https://github.com/Ev2geny/cpython/blob/07b963e453a9d15086a819804803b982d7cd94aa/Doc/whatsnew/3.12.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/97015/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/97015/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
| https://github.com/python/cpython/pull/97015/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
| Lib/tempfile.py | https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
View file
| https://github.com/Ev2geny/cpython/blob/07b963e453a9d15086a819804803b982d7cd94aa/Lib/tempfile.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/97015/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
| Please reload this page | https://github.com/python/cpython/pull/97015/files |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
|
| https://github.com/python/cpython/pull/97015/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21 |
| Lib/test/test_tempfile.py | https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
|
View file
| https://github.com/Ev2geny/cpython/blob/07b963e453a9d15086a819804803b982d7cd94aa/Lib/test/test_tempfile.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/97015/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
|
| https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
|
| https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
|
| https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
|
| https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
|
| https://github.com/python/cpython/pull/97015/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983 |
| Misc/NEWS.d/next/Library/2020-09-28-04-56-04.bpo-14243.YECnxv.rst | https://github.com/python/cpython/pull/97015/files#diff-09f69cf5362a627144db1a8fbeca57decb67fca30c3cce67979b0acde1c4b9c9 |
|
View file
| https://github.com/Ev2geny/cpython/blob/07b963e453a9d15086a819804803b982d7cd94aa/Misc/NEWS.d/next/Library/2020-09-28-04-56-04.bpo-14243.YECnxv.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/97015/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |