| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:16cc3ddf-78e5-d496-3843-c096a63252da |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D490:11D50D:20B2CB:2BE168:696977FC |
| html-safe-nonce | d11c44fdbff40a0696f75cb7ccf7424f23a46b7799523b1e9805b5784a8c88f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDkwOjExRDUwRDoyMEIyQ0I6MkJFMTY4OjY5Njk3N0ZDIiwidmlzaXRvcl9pZCI6IjU1NjM4OTAxNTY3MzM4MjI5NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ca4a7df992a0be4cd991f71461f204d20c450d64849cff73006b73fb8da93021 |
| hovercard-subject-tag | pull_request:1060045301 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/96929/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c8fe368408127f300d52fa426b0ed6d822aff8e54893e4b36c5389359854c482/python/cpython/pull/96929 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c8fe368408127f300d52fa426b0ed6d822aff8e54893e4b36c5389359854c482/python/cpython/pull/96929 |
| og:image:alt | It is heavily inspired by
cpython/Lib/test/string_tests.py
Lines 99 to 161
in
cbdeda8
def test_count(sel... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6f193beb8ff08443adc07685d75302ab8aaf0a135f6e251c3ff3112c8deb881 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 212e3e3d3298bf5b313830edfd2399e869f7ea76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/96929#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96929 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96929 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/96929 |
| Reload | https://github.com/python/cpython/pull/96929 |
| Reload | https://github.com/python/cpython/pull/96929 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/96929#issue-comment-box |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| sobolevn:cover-py-unicode-count | https://github.com/sobolevn/cpython/tree/cover-py-unicode-count |
|
gh-94808: Cover PyUnicode_Count in CAPI
| https://github.com/python/cpython/pull/96929#top |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| sobolevn:cover-py-unicode-count | https://github.com/sobolevn/cpython/tree/cover-py-unicode-count |
|
Conversation
3
| https://github.com/python/cpython/pull/96929 |
|
Commits
1
| https://github.com/python/cpython/pull/96929/commits |
|
Checks
0
| https://github.com/python/cpython/pull/96929/checks |
|
Files changed
| https://github.com/python/cpython/pull/96929/files |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Sep 19, 2022 | https://github.com/python/cpython/pull/96929#issue-1377658239 |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
| cpython/Lib/test/string_tests.py | https://github.com/python/cpython/blob/cbdeda8ce7a3543cb3376d70e4cd46fcf24f42a7/Lib/test/string_tests.py#L99-L161 |
| cbdeda8 | https://github.com/python/cpython/commit/cbdeda8ce7a3543cb3376d70e4cd46fcf24f42a7 |
| cpython/Objects/unicodeobject.c | https://github.com/python/cpython/blob/cbdeda8ce7a3543cb3376d70e4cd46fcf24f42a7/Objects/unicodeobject.c#L8968-L9040 |
| cbdeda8 | https://github.com/python/cpython/commit/cbdeda8ce7a3543cb3376d70e4cd46fcf24f42a7 |
| cpython/Objects/unicodeobject.c | https://github.com/python/cpython/blob/cbdeda8ce7a3543cb3376d70e4cd46fcf24f42a7/Objects/unicodeobject.c#L10854-L10916 |
| cbdeda8 | https://github.com/python/cpython/commit/cbdeda8ce7a3543cb3376d70e4cd46fcf24f42a7 |
| Metabug: Improving C-level coverage #94808 | https://github.com/python/cpython/issues/94808 |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
|
| https://github.com/sobolevn |
| pythongh-94808 | https://github.com/python/cpython/issues/94808 |
| : Cover | https://github.com/python/cpython/pull/96929/commits/22aee9a9bd99ac609fcbd038a06d3d48196a9a5d |
| PyUnicode_Count | https://github.com/python/cpython/pull/96929/commits/22aee9a9bd99ac609fcbd038a06d3d48196a9a5d |
| in CAPI | https://github.com/python/cpython/pull/96929/commits/22aee9a9bd99ac609fcbd038a06d3d48196a9a5d |
| 22aee9a | https://github.com/python/cpython/pull/96929/commits/22aee9a9bd99ac609fcbd038a06d3d48196a9a5d |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Sep 19, 2022 | https://github.com/python/cpython/pull/96929#event-7411926784 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Sep 19, 2022 | https://github.com/python/cpython/pull/96929#event-7411928900 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| encukou | https://github.com/encukou |
| September 19, 2022 09:49 | https://github.com/python/cpython/pull/96929#event-7412118625 |
| https://github.com/mdboom |
| mdboom | https://github.com/mdboom |
| Sep 22, 2022 | https://github.com/python/cpython/pull/96929#issuecomment-1255473976 |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Oct 6, 2022
| https://github.com/python/cpython/pull/96929#pullrequestreview-1133207177 |
|
View reviewed changes
| https://github.com/python/cpython/pull/96929/files/22aee9a9bd99ac609fcbd038a06d3d48196a9a5d |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Oct 6, 2022 | https://github.com/python/cpython/pull/96929#event-7536112217 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| e63d7da | https://github.com/python/cpython/commit/e63d7dae90d15957303688285daeebc2e931e04b |
| Oct 6, 2022 | https://github.com/python/cpython/pull/96929#event-7536114893 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Oct 6, 2022 | https://github.com/python/cpython/pull/96929#event-7536115530 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Oct 6, 2022 | https://github.com/python/cpython/pull/96929#issuecomment-1270262538 |
| an optimization in 2011 | https://github.com/python/cpython/commit/c3cec7868bf1019c0987f1e9aadb56d73fa93d61 |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 6, 2022 | https://github.com/python/cpython/pull/96929#issuecomment-1270417448 |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
| carljm | https://github.com/carljm |
|
Oct 6, 2022
| https://github.com/python/cpython/pull/96929#ref-commit-7938d6f |
|
| https://github.com/carljm |
| Merge branch 'main' into dictwatch | https://github.com/carljm/cpython/commit/7938d6f56ca4971aa5ae2d0004e447d1bcc09bc5 |
| 7938d6f | https://github.com/carljm/cpython/commit/7938d6f56ca4971aa5ae2d0004e447d1bcc09bc5 |
| pythonGH-88050 | https://github.com/python/cpython/issues/88050 |
| python#97951 | https://github.com/python/cpython/pull/97951 |
| pythongh-93738 | https://github.com/python/cpython/issues/93738 |
| python#97962 | https://github.com/python/cpython/pull/97962 |
| pythongh-95986 | https://github.com/python/cpython/issues/95986 |
| python#95989 | https://github.com/python/cpython/pull/95989 |
| pythongh-97897 | https://github.com/python/cpython/issues/97897 |
| pythonGH-97944 | https://github.com/python/cpython/pull/97944 |
| pythongh-94808 | https://github.com/python/cpython/issues/94808 |
| python#96929 | https://github.com/python/cpython/pull/96929 |
| pythongh-94808 | https://github.com/python/cpython/issues/94808 |
| python#96610 | https://github.com/python/cpython/pull/96610 |
| pythongh-95691 | https://github.com/python/cpython/issues/95691 |
| python#95703 | https://github.com/python/cpython/pull/95703 |
| pythonGH-88968 | https://github.com/python/cpython/issues/88968 |
| python#97936 | https://github.com/python/cpython/pull/97936 |
| pythongh-96865 | https://github.com/python/cpython/issues/96865 |
| pythonGH-97528 | https://github.com/python/cpython/pull/97528 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Oct 6, 2022
| https://github.com/python/cpython/pull/96929#ref-issue-1400099347 |
|
Unify PyUncode_Count and unicode_count
#97982
| https://github.com/python/cpython/issues/97982 |
| carljm | https://github.com/carljm |
|
Oct 8, 2022
| https://github.com/python/cpython/pull/96929#ref-commit-1af2a98 |
|
| https://github.com/carljm |
| Merge branch 'main' into typewatch | https://github.com/carljm/cpython/commit/1af2a98c52cbe69d40b6c22f16c94701cb8e7247 |
| 1af2a98 | https://github.com/carljm/cpython/commit/1af2a98c52cbe69d40b6c22f16c94701cb8e7247 |
| pythongh-94808 | https://github.com/python/cpython/issues/94808 |
| python#95926 | https://github.com/python/cpython/pull/95926 |
| pythonGH-88050 | https://github.com/python/cpython/issues/88050 |
| python#97951 | https://github.com/python/cpython/pull/97951 |
| pythongh-93738 | https://github.com/python/cpython/issues/93738 |
| python#97962 | https://github.com/python/cpython/pull/97962 |
| pythongh-95986 | https://github.com/python/cpython/issues/95986 |
| python#95989 | https://github.com/python/cpython/pull/95989 |
| pythongh-97897 | https://github.com/python/cpython/issues/97897 |
| pythonGH-97944 | https://github.com/python/cpython/pull/97944 |
| pythongh-94808 | https://github.com/python/cpython/issues/94808 |
| python#96929 | https://github.com/python/cpython/pull/96929 |
| pythongh-94808 | https://github.com/python/cpython/issues/94808 |
| python#96610 | https://github.com/python/cpython/pull/96610 |
| pythongh-95691 | https://github.com/python/cpython/issues/95691 |
| python#95703 | https://github.com/python/cpython/pull/95703 |
| pythonGH-88968 | https://github.com/python/cpython/issues/88968 |
| python#97936 | https://github.com/python/cpython/pull/97936 |
| pythongh-96865 | https://github.com/python/cpython/issues/96865 |
| pythonGH-97528 | https://github.com/python/cpython/pull/97528 |
| pythongh-65961 | https://github.com/python/cpython/issues/65961 |
| python#97879 | https://github.com/python/cpython/pull/97879 |
| python#97926 | https://github.com/python/cpython/pull/97926 |
| pythongh-97850 | https://github.com/python/cpython/issues/97850 |
| python#97876 | https://github.com/python/cpython/pull/97876 |
| python#96671 | https://github.com/python/cpython/pull/96671 |
| pythongh-93738 | https://github.com/python/cpython/issues/93738 |
| python#97768 | https://github.com/python/cpython/pull/97768 |
| pythongh-91539 | https://github.com/python/cpython/issues/91539 |
| python#91566 | https://github.com/python/cpython/pull/91566 |
| python#97701 | https://github.com/python/cpython/pull/97701 |
| pythonGH-95172 | https://github.com/python/cpython/pull/95172 |
| python#95172 | https://github.com/python/cpython/pull/95172 |
| pythongh-88050 | https://github.com/python/cpython/issues/88050 |
| python#32073 | https://github.com/python/cpython/pull/32073 |
| pythongh-93738 | https://github.com/python/cpython/issues/93738 |
| python#97774 | https://github.com/python/cpython/pull/97774 |
| mpage | https://github.com/mpage |
|
Oct 11, 2022
| https://github.com/python/cpython/pull/96929#ref-commit-d458682 |
|
| https://github.com/sobolevn |
|
| https://github.com/mpage |
| pythongh-94808 | https://github.com/python/cpython/issues/94808 |
| : Cover | https://github.com/mpage/cpython/commit/d458682a2e793b672504d902d728f53ab5b22ae7 |
| PyUnicode_Count | https://github.com/mpage/cpython/commit/d458682a2e793b672504d902d728f53ab5b22ae7 |
| in CAPI ( | https://github.com/mpage/cpython/commit/d458682a2e793b672504d902d728f53ab5b22ae7 |
| python#96929 | https://github.com/python/cpython/pull/96929 |
| ) | https://github.com/mpage/cpython/commit/d458682a2e793b672504d902d728f53ab5b22ae7 |
| d458682 | https://github.com/mpage/cpython/commit/d458682a2e793b672504d902d728f53ab5b22ae7 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96929 |
|
| https://github.com/encukou |
|
encukou
| https://github.com/encukou |
|
| https://github.com/python/cpython/pull/96929/files/22aee9a9bd99ac609fcbd038a06d3d48196a9a5d |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
| Please reload this page | https://github.com/python/cpython/pull/96929 |
|
| https://github.com/sobolevn |
|
| https://github.com/mdboom |
|
| https://github.com/encukou |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |