René's URL Explorer Experiment


Title: gh-96821: Fix undefined behaviour in `_ctypes/cfield.c` by matthiasgoergens · Pull Request #96925 · python/cpython · GitHub

Open Graph Title: gh-96821: Fix undefined behaviour in `_ctypes/cfield.c` by matthiasgoergens · Pull Request #96925 · python/cpython

X Title: gh-96821: Fix undefined behaviour in `_ctypes/cfield.c` by matthiasgoergens · Pull Request #96925 · python/cpython

Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by optimizing compilers. Issue: gh-96821

Open Graph Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...

X Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...

Opengraph URL: https://github.com/python/cpython/pull/96925

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:67409203-3afd-7e09-cc50-b723a09d5416
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C08:146FD0:C22A67:10F04B9:696A36EE
html-safe-nonce3cc22871051944d030ebf98b9028b29d87a5eb7d06d68ff5350194fa7133ded3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzA4OjE0NkZEMDpDMjJBNjc6MTBGMDRCOTo2OTZBMzZFRSIsInZpc2l0b3JfaWQiOiI4NDQwMjI2NjEwOTQ5MDExMTgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd010a6192a4880707cc10a3652ceb168ab7c55a62e4f5696f40b5174c964539b
hovercard-subject-tagpull_request:1059886357
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/96925/files
twitter:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
og:image:altLeft-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96925/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96925%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96925%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96925/files
Reloadhttps://github.com/python/cpython/pull/96925/files
Reloadhttps://github.com/python/cpython/pull/96925/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/96925/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/96925/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
matthiasgoergenshttps://github.com/matthiasgoergens
python:mainhttps://github.com/python/cpython/tree/main
matthiasgoergens:matthias/fix-UB-in-cfieldhttps://github.com/matthiasgoergens/cpython/tree/matthias/fix-UB-in-cfield
Conversation 14 https://github.com/python/cpython/pull/96925
Commits 11 https://github.com/python/cpython/pull/96925/commits
Checks 0 https://github.com/python/cpython/pull/96925/checks
Files changed https://github.com/python/cpython/pull/96925/files
Please reload this pagehttps://github.com/python/cpython/pull/96925/files
gh-96821: Fix undefined behaviour in _ctypes/cfield.c https://github.com/python/cpython/pull/96925/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/96925/files
0572043 gh-96821: Fix undefined behaviour in cfield.c matthiasgoergens Sep 19, 2022 https://github.com/python/cpython/pull/96925/commits/0572043851a31f86720ea80596b5159828707728
e5b624a 📜🤖 Added by blurb_it. blurb-it[bot] Sep 19, 2022 https://github.com/python/cpython/pull/96925/commits/e5b624a69ded40f517969fd3fd28fee9e864ce3c
31f6509 Explicitly cast matthiasgoergens Sep 19, 2022 https://github.com/python/cpython/pull/96925/commits/31f65095087961896895af598b4344f9ae762024
898e949 Merge remote-tracking branch 'matthias/matthias/fix-UB-in-cfield' int… matthiasgoergens Sep 19, 2022 https://github.com/python/cpython/pull/96925/commits/898e94977b16374703c9281dbe54b8791ab241a5
0ec0f4f Merge branch 'main' into matthias/fix-UB-in-cfield matthiasgoergens Sep 19, 2022 https://github.com/python/cpython/pull/96925/commits/0ec0f4f69b501b62d96ca1fdbb2d1dccfeef37b9
45c3491 Re-enable test matthiasgoergens Sep 26, 2022 https://github.com/python/cpython/pull/96925/commits/45c34913d970d68e6c87863164604f74c30cd0bc
8d280e4 Merge remote-tracking branch 'origin/main' into matthias/fix-UB-in-cf… matthiasgoergens Sep 26, 2022 https://github.com/python/cpython/pull/96925/commits/8d280e496710140dcb06d552011ccc0d0df0ae4c
1612d54 Merge branch 'main' into matthias/fix-UB-in-cfield matthiasgoergens Sep 27, 2022 https://github.com/python/cpython/pull/96925/commits/1612d545e70f8e5bcfa8f8a0ca6701201f8475b6
b88f17e Merge branch 'main' into matthias/fix-UB-in-cfield matthiasgoergens Sep 27, 2022 https://github.com/python/cpython/pull/96925/commits/b88f17e721f236622d614eb4120da5a6e6a3074b
ad57b26 Merge branch 'main' into matthias/fix-UB-in-cfield matthiasgoergens Oct 6, 2022 https://github.com/python/cpython/pull/96925/commits/ad57b26599bee8c507db7ba84db2b7b26511c7a2
aae9e96 Merge branch 'main' into matthias/fix-UB-in-cfield matthiasgoergens Oct 9, 2022 https://github.com/python/cpython/pull/96925/commits/aae9e969eff44c04eaa616d3440f9c590026468f
Clear filters https://github.com/python/cpython/pull/96925/files
Please reload this pagehttps://github.com/python/cpython/pull/96925/files
Please reload this pagehttps://github.com/python/cpython/pull/96925/files
test_bitfields.py https://github.com/python/cpython/pull/96925/files#diff-c7e816339c51e08db1e9e20af20c515dad11b1d60656a61d8b1590c900974834
2022-09-19-06-42-20.gh-issue-96821.jrmhsw.rst https://github.com/python/cpython/pull/96925/files#diff-7a5dd2cc5cb7ce654580acaa6bf1afca1cfddcd9d50aa193bdcf398b0ba9114b
cfield.c https://github.com/python/cpython/pull/96925/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Lib/test/test_ctypes/test_bitfields.pyhttps://github.com/python/cpython/pull/96925/files#diff-c7e816339c51e08db1e9e20af20c515dad11b1d60656a61d8b1590c900974834
View file https://github.com/python/cpython/blob/aae9e969eff44c04eaa616d3440f9c590026468f/Lib/test/test_ctypes/test_bitfields.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96925/{{ revealButtonHref }}
https://github.com/python/cpython/pull/96925/files#diff-c7e816339c51e08db1e9e20af20c515dad11b1d60656a61d8b1590c900974834
https://github.com/python/cpython/pull/96925/files#diff-c7e816339c51e08db1e9e20af20c515dad11b1d60656a61d8b1590c900974834
Misc/NEWS.d/next/Core and Builtins/2022-09-19-06-42-20.gh-issue-96821.jrmhsw.rsthttps://github.com/python/cpython/pull/96925/files#diff-7a5dd2cc5cb7ce654580acaa6bf1afca1cfddcd9d50aa193bdcf398b0ba9114b
View file https://github.com/python/cpython/blob/aae9e969eff44c04eaa616d3440f9c590026468f/Misc/NEWS.d/next/Core%20and%20Builtins/2022-09-19-06-42-20.gh-issue-96821.jrmhsw.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96925/{{ revealButtonHref }}
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/96925/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
View file https://github.com/python/cpython/blob/aae9e969eff44c04eaa616d3440f9c590026468f/Modules/_ctypes/cfield.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96925/{{ revealButtonHref }}
https://github.com/python/cpython/pull/96925/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
https://github.com/python/cpython/pull/96925/files#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.