René's URL Explorer Experiment


Title: gh-96821: Fix undefined behaviour in `_ctypes/cfield.c` by matthiasgoergens · Pull Request #96925 · python/cpython · GitHub

Open Graph Title: gh-96821: Fix undefined behaviour in `_ctypes/cfield.c` by matthiasgoergens · Pull Request #96925 · python/cpython

X Title: gh-96821: Fix undefined behaviour in `_ctypes/cfield.c` by matthiasgoergens · Pull Request #96925 · python/cpython

Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...

Open Graph Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...

X Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...

Opengraph URL: https://github.com/python/cpython/pull/96925

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7ec0d503-0be5-3af3-693a-2611ec3215c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idACE0:1F1AF5:AE3A1B:EE2AA6:6969F13C
html-safe-nonce1ac0f0f38466d97a2856067662af6b8f28f10ebc0a703e472a085a6363b83e38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0UwOjFGMUFGNTpBRTNBMUI6RUUyQUE2OjY5NjlGMTNDIiwidmlzaXRvcl9pZCI6IjM2NDkyOTA2MjIwNDkzMTcxODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6fd4dfa14865ee557cd942b8e781f51e0f86dbaaea2ac4d5b9aeff8c7e2044ec
hovercard-subject-tagpull_request:1059886357
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/96925/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ee5f6e829c3b4d30fa955bbc9e97622219af2ed15566a6d08a36fdeeb0116aa8/python/cpython/pull/96925
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee5f6e829c3b4d30fa955bbc9e97622219af2ed15566a6d08a36fdeeb0116aa8/python/cpython/pull/96925
og:image:altLeft-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamematthiasgoergens
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96925#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96925
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96925
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96925
Reloadhttps://github.com/python/cpython/pull/96925
Reloadhttps://github.com/python/cpython/pull/96925
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/96925
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/96925
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/96925#issue-comment-box
matthiasgoergenshttps://github.com/matthiasgoergens
python:mainhttps://github.com/python/cpython/tree/main
matthiasgoergens:matthias/fix-UB-in-cfieldhttps://github.com/matthiasgoergens/cpython/tree/matthias/fix-UB-in-cfield
gh-96821: Fix undefined behaviour in _ctypes/cfield.c https://github.com/python/cpython/pull/96925#top
matthiasgoergenshttps://github.com/matthiasgoergens
python:mainhttps://github.com/python/cpython/tree/main
matthiasgoergens:matthias/fix-UB-in-cfieldhttps://github.com/matthiasgoergens/cpython/tree/matthias/fix-UB-in-cfield
Conversation 14 https://github.com/python/cpython/pull/96925
Commits 11 https://github.com/python/cpython/pull/96925/commits
Checks 0 https://github.com/python/cpython/pull/96925/checks
Files changed https://github.com/python/cpython/pull/96925/files
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/matthiasgoergens
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 19, 2022https://github.com/python/cpython/pull/96925#issue-1377476902
Please reload this pagehttps://github.com/python/cpython/pull/96925
Enable -fstrict-overflow #96821https://github.com/python/cpython/issues/96821
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/matthiasgoergens
pythongh-96821https://github.com/python/cpython/issues/96821
: Fix undefined behaviour in cfield.chttps://github.com/python/cpython/pull/96925/commits/0572043851a31f86720ea80596b5159828707728
0572043https://github.com/python/cpython/pull/96925/commits/0572043851a31f86720ea80596b5159828707728
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 19, 2022https://github.com/python/cpython/pull/96925#event-7410836868
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/96925/commits/e5b624a69ded40f517969fd3fd28fee9e864ce3c
e5b624ahttps://github.com/python/cpython/pull/96925/commits/e5b624a69ded40f517969fd3fd28fee9e864ce3c
https://github.com/matthiasgoergens
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 19, 2022https://github.com/python/cpython/pull/96925#issuecomment-1250628324
@kumaraditya303https://github.com/kumaraditya303
@mdickinsonhttps://github.com/mdickinson
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Sep 19, 2022 https://github.com/python/cpython/pull/96925#pullrequestreview-1111833851
View reviewed changes https://github.com/python/cpython/pull/96925/files/e5b624a69ded40f517969fd3fd28fee9e864ce3c
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/96925/files/e5b624a69ded40f517969fd3fd28fee9e864ce3c#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Please reload this pagehttps://github.com/python/cpython/pull/96925
matthiasgoergenshttps://github.com/matthiasgoergens
September 19, 2022 16:41https://github.com/python/cpython/pull/96925#commits-pushed-31f6509
https://github.com/matthiasgoergens
Explicitly casthttps://github.com/python/cpython/pull/96925/commits/31f65095087961896895af598b4344f9ae762024
31f6509https://github.com/python/cpython/pull/96925/commits/31f65095087961896895af598b4344f9ae762024
https://github.com/matthiasgoergens
Merge remote-tracking branch 'matthias/matthias/fix-UB-in-cfield' int…https://github.com/python/cpython/pull/96925/commits/898e94977b16374703c9281dbe54b8791ab241a5
898e949https://github.com/python/cpython/pull/96925/commits/898e94977b16374703c9281dbe54b8791ab241a5
https://github.com/matthiasgoergens
Merge branch 'main' into matthias/fix-UB-in-cfieldhttps://github.com/python/cpython/pull/96925/commits/0ec0f4f69b501b62d96ca1fdbb2d1dccfeef37b9
0ec0f4fhttps://github.com/python/cpython/pull/96925/commits/0ec0f4f69b501b62d96ca1fdbb2d1dccfeef37b9
https://github.com/matthiasgoergens
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 21, 2022https://github.com/python/cpython/pull/96925#event-7426831899
gh-96821: Add config option --with-strict-overflow #96823 https://github.com/python/cpython/pull/96823
Enable -fstrict-overflow #96821 https://github.com/python/cpython/issues/96821
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022https://github.com/python/cpython/pull/96925#issuecomment-1257191729
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/matthiasgoergens
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 25, 2022https://github.com/python/cpython/pull/96925#issuecomment-1257195852
@mdickinsonhttps://github.com/mdickinson
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022https://github.com/python/cpython/pull/96925#issuecomment-1257196488
cpython/Lib/test/test_ctypes/test_bitfields.pyhttps://github.com/python/cpython/blob/c8c0afc7137ab9f22bf59d591084948ca967c97c/Lib/test/test_ctypes/test_bitfields.py#L43-L44
c8c0afchttps://github.com/python/cpython/commit/c8c0afc7137ab9f22bf59d591084948ca967c97c
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022https://github.com/python/cpython/pull/96925#issuecomment-1257198528
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022https://github.com/python/cpython/pull/96925#issuecomment-1257199444
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022https://github.com/python/cpython/pull/96925#issuecomment-1257204613
#73939https://github.com/python/cpython/issues/73939
#84039https://github.com/python/cpython/issues/84039
#86098https://github.com/python/cpython/issues/86098
#59324https://github.com/python/cpython/issues/59324
@matthiasgoergenshttps://github.com/matthiasgoergens
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/matthiasgoergens
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 26, 2022https://github.com/python/cpython/pull/96925#issuecomment-1257538549
@mdickinsonhttps://github.com/mdickinson
Please reload this pagehttps://github.com/python/cpython/pull/96925
matthiasgoergenshttps://github.com/matthiasgoergens
September 26, 2022 14:31https://github.com/python/cpython/pull/96925#commits-pushed-45c3491
https://github.com/matthiasgoergens
Re-enable testhttps://github.com/python/cpython/pull/96925/commits/45c34913d970d68e6c87863164604f74c30cd0bc
45c3491https://github.com/python/cpython/pull/96925/commits/45c34913d970d68e6c87863164604f74c30cd0bc
https://github.com/matthiasgoergens
Merge remote-tracking branch 'origin/main' into matthias/fix-UB-in-cf…https://github.com/python/cpython/pull/96925/commits/8d280e496710140dcb06d552011ccc0d0df0ae4c
8d280e4https://github.com/python/cpython/pull/96925/commits/8d280e496710140dcb06d552011ccc0d0df0ae4c
https://github.com/matthiasgoergens
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96925
https://github.com/matthiasgoergens
Merge branch 'main' into matthias/fix-UB-in-cfieldhttps://github.com/python/cpython/pull/96925/commits/1612d545e70f8e5bcfa8f8a0ca6701201f8475b6
1612d54https://github.com/python/cpython/pull/96925/commits/1612d545e70f8e5bcfa8f8a0ca6701201f8475b6
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 27, 2022 https://github.com/python/cpython/pull/96925#ref-commit-f2e6432
https://github.com/matthiasgoergens
pythongh-96925https://github.com/python/cpython/pull/96925
: Some tests to demonstrate the issuehttps://github.com/matthiasgoergens/cpython/commit/f2e6432194224fba259d756f034671e8789181d5
f2e6432https://github.com/matthiasgoergens/cpython/commit/f2e6432194224fba259d756f034671e8789181d5
https://github.com/matthiasgoergens
Merge branch 'main' into matthias/fix-UB-in-cfieldhttps://github.com/python/cpython/pull/96925/commits/b88f17e721f236622d614eb4120da5a6e6a3074b
b88f17ehttps://github.com/python/cpython/pull/96925/commits/b88f17e721f236622d614eb4120da5a6e6a3074b
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 27, 2022https://github.com/python/cpython/pull/96925#issuecomment-1259826280
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 27, 2022https://github.com/python/cpython/pull/96925#issuecomment-1259838918
Please reload this pagehttps://github.com/python/cpython/pull/96925
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/matthiasgoergens
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 27, 2022https://github.com/python/cpython/pull/96925#issuecomment-1260147691
@mdickinsonhttps://github.com/mdickinson
Please reload this pagehttps://github.com/python/cpython/pull/96925
matthiasgoergenshttps://github.com/matthiasgoergens
October 6, 2022 16:14https://github.com/python/cpython/pull/96925#commits-pushed-ad57b26
https://github.com/matthiasgoergens
Merge branch 'main' into matthias/fix-UB-in-cfieldhttps://github.com/python/cpython/pull/96925/commits/ad57b26599bee8c507db7ba84db2b7b26511c7a2
ad57b26https://github.com/python/cpython/pull/96925/commits/ad57b26599bee8c507db7ba84db2b7b26511c7a2
https://github.com/matthiasgoergens
Merge branch 'main' into matthias/fix-UB-in-cfieldhttps://github.com/python/cpython/pull/96925/commits/aae9e969eff44c04eaa616d3440f9c590026468f
aae9e96https://github.com/python/cpython/pull/96925/commits/aae9e969eff44c04eaa616d3440f9c590026468f
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96925
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/python/cpython/pull/96925/files/e5b624a69ded40f517969fd3fd28fee9e864ce3c
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/96925
https://github.com/matthiasgoergens
https://github.com/mdickinson
https://github.com/Fidget-Spinner
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.