René's URL Explorer Experiment


Title: gh-96821: Fix undefined behaviour in `audioop.c` by matthiasgoergens · Pull Request #96923 · python/cpython · GitHub

Open Graph Title: gh-96821: Fix undefined behaviour in `audioop.c` by matthiasgoergens · Pull Request #96923 · python/cpython

X Title: gh-96821: Fix undefined behaviour in `audioop.c` by matthiasgoergens · Pull Request #96923 · python/cpython

Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by optimizing compilers. Issue: gh-96821

Open Graph Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...

X Description: Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...

Opengraph URL: https://github.com/python/cpython/pull/96923

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6061186a-f386-49bf-41f7-1a81029ec489
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3C4:2EC266:122B5EE:191704C:696A9104
html-safe-nonce818a59e2d463d07f4127e521d1496d81624b7ca4a59a925764b1a9281734efaa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0M0OjJFQzI2NjoxMjJCNUVFOjE5MTcwNEM6Njk2QTkxMDQiLCJ2aXNpdG9yX2lkIjoiMzMxODQ4NDgxMDYxODAxNjAwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3f056a4f5d959a9bda505f89b096c970d8391165f51d60524a1c9d8342e9135a
hovercard-subject-tagpull_request:1059770726
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/96923/files
twitter:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57026?s=400&v=4
og:image:altLeft-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is (implementation) defined behaviour, and gets compiled to the same machine code as before by...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96923/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96923%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96923%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96923/files
Reloadhttps://github.com/python/cpython/pull/96923/files
Reloadhttps://github.com/python/cpython/pull/96923/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/96923/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/96923/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mdickinsonhttps://github.com/mdickinson
python:mainhttps://github.com/python/cpython/tree/main
matthiasgoergens:matthias/fix-audioop-UBhttps://github.com/matthiasgoergens/cpython/tree/matthias/fix-audioop-UB
Conversation 20 https://github.com/python/cpython/pull/96923
Commits 11 https://github.com/python/cpython/pull/96923/commits
Checks 0 https://github.com/python/cpython/pull/96923/checks
Files changed https://github.com/python/cpython/pull/96923/files
Please reload this pagehttps://github.com/python/cpython/pull/96923/files
gh-96821: Fix undefined behaviour in audioop.c https://github.com/python/cpython/pull/96923/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/96923/files
13b5850 gh-96821: Fix undefined behaviour in `audioop.c` matthiasgoergens Sep 19, 2022 https://github.com/python/cpython/pull/96923/commits/13b585037cda30e450facd5e292dd04e4738e78c
07d709a 📜🤖 Added by blurb_it. blurb-it[bot] Sep 19, 2022 https://github.com/python/cpython/pull/96923/commits/07d709a5d526d09e81ecb8aaa3a12cd9211847bd
fd6f822 Merge branch 'main' into matthias/fix-audioop-UB matthiasgoergens Sep 20, 2022 https://github.com/python/cpython/pull/96923/commits/fd6f822199309b5689f57c559694b59bd47fdc17
a3502da Merge branch 'main' into matthias/fix-audioop-UB matthiasgoergens Sep 26, 2022 https://github.com/python/cpython/pull/96923/commits/a3502dacdf521f2bc0478025b9e631bc4a68271b
98b2352 Merge branch 'main' into matthias/fix-audioop-UB matthiasgoergens Sep 27, 2022 https://github.com/python/cpython/pull/96923/commits/98b2352aeb69a2a56236a9bd67feacb7b2379250
c549094 Merge remote-tracking branch 'origin/main' into matthias/fix-audioop-UB matthiasgoergens Oct 5, 2022 https://github.com/python/cpython/pull/96923/commits/c54909402d3a0f13532d7a28857a8e638dee0151
15e43a6 Move asserts for more coverage matthiasgoergens Oct 5, 2022 https://github.com/python/cpython/pull/96923/commits/15e43a6288d74022b2332697aa6575c7a83f1c4d
4e36000 Merge branch 'main' into matthias/fix-audioop-UB matthiasgoergens Oct 8, 2022 https://github.com/python/cpython/pull/96923/commits/4e36000d3ae27f1a303565834d7e8b1a32dc7343
c3f9108 Merge branch 'main' into matthias/fix-audioop-UB matthiasgoergens Oct 9, 2022 https://github.com/python/cpython/pull/96923/commits/c3f91088e2f07af036cb1a70828be5dc0b180a40
da7aab3 Merge remote-tracking branch 'origin/main' into matthias/fix-audioop-UB matthiasgoergens Oct 9, 2022 https://github.com/python/cpython/pull/96923/commits/da7aab32f491d54e9af0dc5e01f63d0d9873dff4
ba80611 Revert unneeded changes matthiasgoergens Oct 9, 2022 https://github.com/python/cpython/pull/96923/commits/ba806114d9810571f9aad81d2e3094e9f445e9c6
Clear filters https://github.com/python/cpython/pull/96923/files
Please reload this pagehttps://github.com/python/cpython/pull/96923/files
Please reload this pagehttps://github.com/python/cpython/pull/96923/files
2022-09-19-03-35-01.gh-issue-96821.izK6JA.rst https://github.com/python/cpython/pull/96923/files#diff-4fa3ea01e720d0ce55fb11c8d0385076d37e0079d9d01b660e9f06305b883659
audioop.c https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
Misc/NEWS.d/next/Core and Builtins/2022-09-19-03-35-01.gh-issue-96821.izK6JA.rsthttps://github.com/python/cpython/pull/96923/files#diff-4fa3ea01e720d0ce55fb11c8d0385076d37e0079d9d01b660e9f06305b883659
View file https://github.com/matthiasgoergens/cpython/blob/ba806114d9810571f9aad81d2e3094e9f445e9c6/Misc/NEWS.d/next/Core%20and%20Builtins/2022-09-19-03-35-01.gh-issue-96821.izK6JA.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96923/{{ revealButtonHref }}
Modules/audioop.chttps://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
View file https://github.com/matthiasgoergens/cpython/blob/ba806114d9810571f9aad81d2e3094e9f445e9c6/Modules/audioop.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96923/{{ revealButtonHref }}
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
Please reload this pagehttps://github.com/python/cpython/pull/96923/files
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com/python/cpython/pull/96923/files#diff-2cbe7383ad6f56245de202b2479340f868ea35884c4865adf39b318d6d3f32f6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.