René's URL Explorer Experiment


Title: gh-94808: Cover `LOAD_GLOBAL` for custom dict subtypes by sobolevn · Pull Request #96767 · python/cpython · GitHub

Open Graph Title: gh-94808: Cover `LOAD_GLOBAL` for custom dict subtypes by sobolevn · Pull Request #96767 · python/cpython

X Title: gh-94808: Cover `LOAD_GLOBAL` for custom dict subtypes by sobolevn · Pull Request #96767 · python/cpython

Description: I've covered several missing conditions in TARGET(LOAD_GLOBAL): The one where custom globals() dict subtype raises non KeyError: cpython/Python/ceval.c Lines 2445 ...

Open Graph Description: I've covered several missing conditions in TARGET(LOAD_GLOBAL): The one where custom globals() dict subtype raises non KeyError: cpython/Python/ceval.c Lines 2...

X Description: I've covered several missing conditions in TARGET(LOAD_GLOBAL): The one where custom globals() dict subtype raises non KeyError: cpython/Python/ceval.c Lin...

Opengraph URL: https://github.com/python/cpython/pull/96767

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9857bd33-fac0-384d-37dd-25548f627aa8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8C0:2361CC:265EBEE:36115BE:69691999
html-safe-noncee885b8e3a3a8a2e8b1feb7066afbb7f87c79bff4479bf37ab68112ebc41edc80
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEMwOjIzNjFDQzoyNjVFQkVFOjM2MTE1QkU6Njk2OTE5OTkiLCJ2aXNpdG9yX2lkIjoiMzQzNDM4ODYzMDU2NDA1MTM1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3d331ccea634af9e588e422c0eede4284069c61c7374968e632bcf9e3237224b
hovercard-subject-tagpull_request:1053049246
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/96767/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7d2c02e02ff31505688390f472fe4ff74d79055f7cc5c06db762f9028b4d4185/python/cpython/pull/96767
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d2c02e02ff31505688390f472fe4ff74d79055f7cc5c06db762f9028b4d4185/python/cpython/pull/96767
og:image:altI've covered several missing conditions in TARGET(LOAD_GLOBAL): The one where custom globals() dict subtype raises non KeyError: cpython/Python/ceval.c Lines 2...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd206f7ed6207863172be4a783826e86bd2375c3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96767#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96767
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96767
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96767
Reloadhttps://github.com/python/cpython/pull/96767
Reloadhttps://github.com/python/cpython/pull/96767
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/96767
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/96767
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/96767#issue-comment-box
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:cover-load-global-custom-dictshttps://github.com/sobolevn/cpython/tree/cover-load-global-custom-dicts
gh-94808: Cover LOAD_GLOBAL for custom dict subtypes https://github.com/python/cpython/pull/96767#top
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:cover-load-global-custom-dictshttps://github.com/sobolevn/cpython/tree/cover-load-global-custom-dicts
Conversation 6 https://github.com/python/cpython/pull/96767
Commits 3 https://github.com/python/cpython/pull/96767/commits
Checks 0 https://github.com/python/cpython/pull/96767/checks
Files changed https://github.com/python/cpython/pull/96767/files
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Sep 12, 2022https://github.com/python/cpython/pull/96767#issue-1369581440
Please reload this pagehttps://github.com/python/cpython/pull/96767
cpython/Python/ceval.chttps://github.com/python/cpython/blob/53a54b781d1f05f2d0b40ce88b3da92d5d23e9d2/Python/ceval.c#L2445-L2447
53a54b7https://github.com/python/cpython/commit/53a54b781d1f05f2d0b40ce88b3da92d5d23e9d2
cpython/Python/ceval.chttps://github.com/python/cpython/blob/53a54b781d1f05f2d0b40ce88b3da92d5d23e9d2/Python/ceval.c#L2458
53a54b7https://github.com/python/cpython/commit/53a54b781d1f05f2d0b40ce88b3da92d5d23e9d2
cpython/Python/ceval.chttps://github.com/python/cpython/blob/53a54b781d1f05f2d0b40ce88b3da92d5d23e9d2/Python/ceval.c#L2453-L2457
53a54b7https://github.com/python/cpython/commit/53a54b781d1f05f2d0b40ce88b3da92d5d23e9d2
Metabug: Improving C-level coverage #94808https://github.com/python/cpython/issues/94808
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.com/sobolevn
pythongh-94808https://github.com/python/cpython/issues/94808
: Coverhttps://github.com/python/cpython/pull/96767/commits/d7310bd20974381d6e2ce54dba2fffc71e47da7c
LOAD_GLOBALhttps://github.com/python/cpython/pull/96767/commits/d7310bd20974381d6e2ce54dba2fffc71e47da7c
for custom dict subtypeshttps://github.com/python/cpython/pull/96767/commits/d7310bd20974381d6e2ce54dba2fffc71e47da7c
d7310bdhttps://github.com/python/cpython/pull/96767/commits/d7310bd20974381d6e2ce54dba2fffc71e47da7c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Sep 12, 2022https://github.com/python/cpython/pull/96767#event-7365804199
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 12, 2022https://github.com/python/cpython/pull/96767#event-7365857951
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
brandtbucherhttps://github.com/brandtbucher
mdboomhttps://github.com/mdboom
September 12, 2022 09:57https://github.com/python/cpython/pull/96767#event-7365919438
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Sep 12, 2022 https://github.com/python/cpython/pull/96767#pullrequestreview-1104600732
View reviewed changes https://github.com/python/cpython/pull/96767/files/d7310bd20974381d6e2ce54dba2fffc71e47da7c
mdboomhttps://github.com/mdboom
https://github.com/python/cpython/pull/96767#pullrequestreview-1104600732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 12, 2022https://github.com/python/cpython/pull/96767#event-7369896570
https://github.com/sobolevn
Add regex to the last testhttps://github.com/python/cpython/pull/96767/commits/51412c2703ecd01df0c6d3886f552b20b0d053ae
51412c2https://github.com/python/cpython/pull/96767/commits/51412c2703ecd01df0c6d3886f552b20b0d053ae
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 3, 2022 https://github.com/python/cpython/pull/96767#pullrequestreview-1167174148
View reviewed changes https://github.com/python/cpython/pull/96767/files/51412c2703ecd01df0c6d3886f552b20b0d053ae
Lib/test/test_builtin.pyhttps://github.com/python/cpython/pull/96767/files/51412c2703ecd01df0c6d3886f552b20b0d053ae#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
iritkatrielhttps://github.com/iritkatriel
Nov 3, 2022https://github.com/python/cpython/pull/96767#discussion_r1013074014
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/96767
sobolevnhttps://github.com/sobolevn
Nov 4, 2022https://github.com/python/cpython/pull/96767#discussion_r1013796646
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.com/sobolevn
Address reviewhttps://github.com/python/cpython/pull/96767/commits/911bca163b54b76afa5366d6f9838a9dbadac115
911bca1https://github.com/python/cpython/pull/96767/commits/911bca163b54b76afa5366d6f9838a9dbadac115
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 4, 2022 https://github.com/python/cpython/pull/96767#ref-issue-1303833875
Metabug: Improving C-level coverage #94808 https://github.com/python/cpython/issues/94808
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 4, 2022 https://github.com/python/cpython/pull/96767#pullrequestreview-1168239174
View reviewed changes https://github.com/python/cpython/pull/96767/files/911bca163b54b76afa5366d6f9838a9dbadac115
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 4, 2022https://github.com/python/cpython/pull/96767#event-7739257766
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Nov 4, 2022https://github.com/python/cpython/pull/96767#event-7739261906
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
044bcc1https://github.com/python/cpython/commit/044bcc1771fe7e2f8eba21793a72ba15e75e6715
Nov 4, 2022https://github.com/python/cpython/pull/96767#event-7739264143
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 4, 2022https://github.com/python/cpython/pull/96767#issuecomment-1303197703
@sobolevnhttps://github.com/sobolevn
@iritkatrielhttps://github.com/iritkatriel
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 4, 2022https://github.com/python/cpython/pull/96767#event-7739264458
miss-islingtonhttps://github.com/miss-islington
Nov 4, 2022 https://github.com/python/cpython/pull/96767#ref-commit-6c30789
https://github.com/sobolevn
https://github.com/miss-islington
pythongh-94808https://github.com/python/cpython/issues/94808
: Coverhttps://github.com/miss-islington/cpython/commit/6c30789d491eb94f9ca049f61c3c2aabb760e640
LOAD_GLOBALhttps://github.com/miss-islington/cpython/commit/6c30789d491eb94f9ca049f61c3c2aabb760e640
for custom dict subtypes (https://github.com/miss-islington/cpython/commit/6c30789d491eb94f9ca049f61c3c2aabb760e640
pythonG…https://github.com/python/cpython/pull/96767
6c30789https://github.com/miss-islington/cpython/commit/6c30789d491eb94f9ca049f61c3c2aabb760e640
…H-96767https://github.com/python/cpython/pull/96767
044bcc1https://github.com/miss-islington/cpython/commit/044bcc1771fe7e2f8eba21793a72ba15e75e6715
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 4, 2022https://github.com/python/cpython/pull/96767#issuecomment-1303197956
@sobolevnhttps://github.com/sobolevn
@iritkatrielhttps://github.com/iritkatriel
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
iritkatrielhttps://github.com/iritkatriel
Nov 4, 2022https://github.com/python/cpython/pull/96767#event-7739266536
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 4, 2022https://github.com/python/cpython/pull/96767#issuecomment-1303198055
GH-99091https://github.com/python/cpython/pull/99091
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Nov 4, 2022https://github.com/python/cpython/pull/96767#event-7739267198
iritkatrielhttps://github.com/iritkatriel
Nov 4, 2022 https://github.com/python/cpython/pull/96767#ref-commit-2b79f4e
https://github.com/miss-islington
[3.11]https://github.com/python/cpython/commit/2b79f4e469450d28ae0db593782500312f747451
gh-94808https://github.com/python/cpython/issues/94808
: Coverhttps://github.com/python/cpython/commit/2b79f4e469450d28ae0db593782500312f747451
LOAD_GLOBALhttps://github.com/python/cpython/commit/2b79f4e469450d28ae0db593782500312f747451
for custom dict subtypes (https://github.com/python/cpython/commit/2b79f4e469450d28ae0db593782500312f747451
GH-96767https://github.com/python/cpython/pull/96767
…https://github.com/python/cpython/commit/2b79f4e469450d28ae0db593782500312f747451
2b79f4ehttps://github.com/python/cpython/commit/2b79f4e469450d28ae0db593782500312f747451
GH-99091https://github.com/python/cpython/pull/99091
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
Feb 17, 2025https://github.com/python/cpython/pull/96767#event-16336590009
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96767
https://github.com/mdboom
mdboom https://github.com/mdboom
https://github.com/python/cpython/pull/96767/files/d7310bd20974381d6e2ce54dba2fffc71e47da7c
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/96767/files/911bca163b54b76afa5366d6f9838a9dbadac115
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/96767
https://github.com/sobolevn
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/mdboom
https://github.com/iritkatriel
https://github.com/ZeroIntensity
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.