René's URL Explorer Experiment


Title: gh-88500: Reduce memory use of `urllib.unquote` by gpshead · Pull Request #96763 · python/cpython · GitHub

Open Graph Title: gh-88500: Reduce memory use of `urllib.unquote` by gpshead · Pull Request #96763 · python/cpython

X Title: gh-88500: Reduce memory use of `urllib.unquote` by gpshead · Pull Request #96763 · python/cpython

Description: urllib.unquote_to_bytes and urllib.unquote could both potentially generate O(len(string)) intermediate bytes or str objects while computing the unquoted final result depending on the input provided. As Python objects are relatively large, this could consume a lot of ram. This switches the implementation to using an expanding bytearray and a generator internally instead of precomputed split() style operations. Microbenchmarks with some antagonistic inputs like mess = "\u0141%% a�"*1000 show this is 10-20% slower for unquote and unquote_to_bytes and no different for typical inputs that are short or lack much unicode or % escaping. But the functions are already quite fast anyways so not a big deal. The slowdown scales consistently linear with input size as expected. Memory usage observed manually using /usr/bin/time -v on python -m timeit runs of larger inputs. Unittesting memory consumption is difficult and does not seem worthwhile. Observed memory usage is ~1/2 for unquote() and <1/3 for unquote_to_bytes() using python -m timeit -s 'from urllib.parse import unquote, unquote_to_bytes; v="\u0141\u0161 "*500_000' 'unquote_to_bytes(v)' as a test. Issue: gh-88500 Closes #88500.

Open Graph Description: urllib.unquote_to_bytes and urllib.unquote could both potentially generate O(len(string)) intermediate bytes or str objects while computing the unquoted final result depending on the input provided...

X Description: urllib.unquote_to_bytes and urllib.unquote could both potentially generate O(len(string)) intermediate bytes or str objects while computing the unquoted final result depending on the input provided...

Opengraph URL: https://github.com/python/cpython/pull/96763

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:454b8944-9dfb-1f25-1518-570276418658
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F14:29AEE8:38702A5:4B1E569:6B0215D7
html-safe-nonce9c8f61654d01224996b2ee27532f3746946fdfafabcf73421660f62da2840e34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjE0OjI5QUVFODozODcwMkE1OjRCMUU1Njk6NkIwMjE1RDciLCJ2aXNpdG9yX2lkIjoiODE2MDMzMTA3ODQyMzQxODMyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac79791f06dcb187cc3e97c886f56fa53fe1b312ae194c7a3e0066f5be20912ac9
hovercard-subject-tagpull_request:1052942663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/96763/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:alturllib.unquote_to_bytes and urllib.unquote could both potentially generate O(len(string)) intermediate bytes or str objects while computing the unquoted final result depending on the input provided...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96763/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96763%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96763%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96763/files
Reloadhttps://github.com/python/cpython/pull/96763/files
Reloadhttps://github.com/python/cpython/pull/96763/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:gh/88500/unquote_mem_usehttps://github.com/gpshead/cpython/tree/gh/88500/unquote_mem_use
Conversation 2 https://github.com/python/cpython/pull/96763
Commits 5 https://github.com/python/cpython/pull/96763/commits
Checks 0 https://github.com/python/cpython/pull/96763/checks
Files changed https://github.com/python/cpython/pull/96763/files
Please reload this pagehttps://github.com/python/cpython/pull/96763/files
gh-88500: Reduce memory use of urllib.unquote https://github.com/python/cpython/pull/96763/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/96763/files
c02c357 gh-88500: Reduce memory use of urllib.unquote gpshead Sep 12, 2022 https://github.com/python/cpython/pull/96763/commits/c02c35744f99bf4d5dab9fdff5740da225d89279
142a7e2 Rename the internal implementation function. gpshead Sep 16, 2022 https://github.com/python/cpython/pull/96763/commits/142a7e22fec34e38d22c63040390e56bd9ba345b
a81248d Merge branch 'main' into gh/88500/unquote_mem_use gpshead Sep 16, 2022 https://github.com/python/cpython/pull/96763/commits/a81248d76bca199f88d416d9247ff50e9526826e
4ffac18 NEWS entry, keep old var name for a smaller diff. gpshead Sep 16, 2022 https://github.com/python/cpython/pull/96763/commits/4ffac18d4e8ce373ad052aa36c412cc6dda172d0
b87595b Merge branch 'main' into gh/88500/unquote_mem_use gpshead Nov 11, 2022 https://github.com/python/cpython/pull/96763/commits/b87595b89a6a95b6e009e372d6ddc2cd082d643e
Clear filters https://github.com/python/cpython/pull/96763/files
Please reload this pagehttps://github.com/python/cpython/pull/96763/files
Please reload this pagehttps://github.com/python/cpython/pull/96763/files
test_urllib.py https://github.com/python/cpython/pull/96763/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
parse.py https://github.com/python/cpython/pull/96763/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
2022-09-16-08-21-46.gh-issue-88500.jQ0pCc.rst https://github.com/python/cpython/pull/96763/files#diff-37c43108d254554b291913f00acdeaaee056891a52e6ba7bae5aa98bfd92cdf7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644
Lib/test/test_urllib.pyhttps://github.com/python/cpython/pull/96763/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
View file https://github.com/gpshead/cpython/blob/b87595b89a6a95b6e009e372d6ddc2cd082d643e/Lib/test/test_urllib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96763/{{ revealButtonHref }}
https://github.com/python/cpython/pull/96763/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/96763/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643
Lib/urllib/parse.pyhttps://github.com/python/cpython/pull/96763/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
View file https://github.com/gpshead/cpython/blob/b87595b89a6a95b6e009e372d6ddc2cd082d643e/Lib/urllib/parse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96763/{{ revealButtonHref }}
https://github.com/python/cpython/pull/96763/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/96763/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/96763/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/96763/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
https://github.com/python/cpython/pull/96763/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
Misc/NEWS.d/next/Library/2022-09-16-08-21-46.gh-issue-88500.jQ0pCc.rsthttps://github.com/python/cpython/pull/96763/files#diff-37c43108d254554b291913f00acdeaaee056891a52e6ba7bae5aa98bfd92cdf7
View file https://github.com/gpshead/cpython/blob/b87595b89a6a95b6e009e372d6ddc2cd082d643e/Misc/NEWS.d/next/Library/2022-09-16-08-21-46.gh-issue-88500.jQ0pCc.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/96763/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.