René's URL Explorer Experiment


Title: gh-96735: Fix undefined behaviour in struct unpacking functions by mdickinson · Pull Request #96739 · python/cpython · GitHub

Open Graph Title: gh-96735: Fix undefined behaviour in struct unpacking functions by mdickinson · Pull Request #96739 · python/cpython

X Title: gh-96735: Fix undefined behaviour in struct unpacking functions by mdickinson · Pull Request #96739 · python/cpython

Description: This PR fixes undefined behaviour in the struct module unpacking support functions bu_longlong, lu_longlong, bu_int and lu_int; thanks to @kumaraditya303 for finding these. The fix is to accumulate...

Open Graph Description: This PR fixes undefined behaviour in the struct module unpacking support functions bu_longlong, lu_longlong, bu_int and lu_int; thanks to @kumaraditya303 for finding these. The fix is to accumulate...

X Description: This PR fixes undefined behaviour in the struct module unpacking support functions bu_longlong, lu_longlong, bu_int and lu_int; thanks to @kumaraditya303 for finding these. The fix is to accumulate...

Opengraph URL: https://github.com/python/cpython/pull/96739

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:43928747-9d44-3345-2e58-d40508938dd1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A10:1D772C:DE4C5F:12B7DEC:696AC819
html-safe-nonce52a053981bb3d82b776ebcb2ef4d4341b520e60767cbb1c515c3fe5ef21d8b60
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTEwOjFENzcyQzpERTRDNUY6MTJCN0RFQzo2OTZBQzgxOSIsInZpc2l0b3JfaWQiOiIzMzc2OTUyNTY1NDkwNjk4MjY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1d2201b251f0f672375f06fb1e98b19bcf20903ebdf58a41cf11a8d192663f55
hovercard-subject-tagpull_request:1052276114
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/96739/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3573d0c274166c906b17054bdedcc5e8755ddcccecde5051d6b0bbf9fd272dd6/python/cpython/pull/96739
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3573d0c274166c906b17054bdedcc5e8755ddcccecde5051d6b0bbf9fd272dd6/python/cpython/pull/96739
og:image:altThis PR fixes undefined behaviour in the struct module unpacking support functions bu_longlong, lu_longlong, bu_int and lu_int; thanks to @kumaraditya303 for finding these. The fix is to accumulate...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemdickinson
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96739#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96739
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96739
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96739
Reloadhttps://github.com/python/cpython/pull/96739
Reloadhttps://github.com/python/cpython/pull/96739
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/96739
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/96739
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/96739#issue-comment-box
mdickinsonhttps://github.com/mdickinson
python:mainhttps://github.com/python/cpython/tree/main
mdickinson:fix-struct-unpack-undefined-behaviourhttps://github.com/mdickinson/cpython/tree/fix-struct-unpack-undefined-behaviour
gh-96735: Fix undefined behaviour in struct unpacking functions https://github.com/python/cpython/pull/96739#top
mdickinsonhttps://github.com/mdickinson
python:mainhttps://github.com/python/cpython/tree/main
mdickinson:fix-struct-unpack-undefined-behaviourhttps://github.com/mdickinson/cpython/tree/fix-struct-unpack-undefined-behaviour
Conversation 9 https://github.com/python/cpython/pull/96739
Commits 10 https://github.com/python/cpython/pull/96739/commits
Checks 0 https://github.com/python/cpython/pull/96739/checks
Files changed https://github.com/python/cpython/pull/96739/files
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 10, 2022https://github.com/python/cpython/pull/96739#issue-1368659488
Please reload this pagehttps://github.com/python/cpython/pull/96739
@kumaraditya303https://github.com/kumaraditya303
https://godbolt.org/z/5zvxodj64https://godbolt.org/z/5zvxodj64
Undefined behavior in struct.unpack #96735https://github.com/python/cpython/issues/96735
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/mdickinson
Fix undefined behaviour in bu_ulonglonghttps://github.com/python/cpython/pull/96739/commits/22fdce61d61a6b68f84c3e6e263de2860429ccea
22fdce6https://github.com/python/cpython/pull/96739/commits/22fdce61d61a6b68f84c3e6e263de2860429ccea
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Sep 10, 2022https://github.com/python/cpython/pull/96739#event-7361102701
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 10, 2022https://github.com/python/cpython/pull/96739#event-7361102743
mdickinsonhttps://github.com/mdickinson
September 10, 2022 16:58https://github.com/python/cpython/pull/96739#commits-pushed-e12943b
https://github.com/mdickinson
Add regression testhttps://github.com/python/cpython/pull/96739/commits/e12943b091dfb3e9b606f415024dfdd28caf3ba1
e12943bhttps://github.com/python/cpython/pull/96739/commits/e12943b091dfb3e9b606f415024dfdd28caf3ba1
https://github.com/mdickinson
Also apply the fix to lu_longlonghttps://github.com/python/cpython/pull/96739/commits/8efefd8b5c91312c574ae1996052f45d7387e86a
8efefd8https://github.com/python/cpython/pull/96739/commits/8efefd8b5c91312c574ae1996052f45d7387e86a
https://github.com/mdickinson
Merge branch 'main' into fix-struct-unpack-undefined-behaviourhttps://github.com/python/cpython/pull/96739/commits/cba4b8b60f9969dd877d152231a2a4e9a5b2d5a1
cba4b8bhttps://github.com/python/cpython/pull/96739/commits/cba4b8b60f9969dd877d152231a2a4e9a5b2d5a1
https://github.com/mdickinson
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96739
mdickinsonhttps://github.com/mdickinson
September 10, 2022 17:27https://github.com/python/cpython/pull/96739#commits-pushed-0d49e73
https://github.com/mdickinson
Fix similar undefined behaviour issues in bu_int and lu_inthttps://github.com/python/cpython/pull/96739/commits/0d49e73cfc5f71fb984f68ac16efe85b4e70d78e
0d49e73https://github.com/python/cpython/pull/96739/commits/0d49e73cfc5f71fb984f68ac16efe85b4e70d78e
https://github.com/mdickinson
Merge remote-tracking branch 'mdickinson/fix-struct-unpack-undefined-…https://github.com/python/cpython/pull/96739/commits/bfd714f55fa7f4a1e570ffd338eb249e3d5ac012
bfd714fhttps://github.com/python/cpython/pull/96739/commits/bfd714f55fa7f4a1e570ffd338eb249e3d5ac012
https://github.com/mdickinson
Remove redundant testhttps://github.com/python/cpython/pull/96739/commits/5aeef09d6e30859681bfaf37604a676603be7b8b
5aeef09https://github.com/python/cpython/pull/96739/commits/5aeef09d6e30859681bfaf37604a676603be7b8b
https://github.com/mdickinson
Fix accumulator typehttps://github.com/python/cpython/pull/96739/commits/204e924c85e04b8ea8186c1dfa9cf4618063b127
204e924https://github.com/python/cpython/pull/96739/commits/204e924c85e04b8ea8186c1dfa9cf4618063b127
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 10, 2022https://github.com/python/cpython/pull/96739#event-7361161339
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 10, 2022https://github.com/python/cpython/pull/96739#issuecomment-1242768300
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
kumaraditya303https://github.com/kumaraditya303
September 10, 2022 17:04https://github.com/python/cpython/pull/96739#event-7361183462
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Sep 10, 2022 https://github.com/python/cpython/pull/96739#pullrequestreview-1103156019
View reviewed changes https://github.com/python/cpython/pull/96739/files/204e924c85e04b8ea8186c1dfa9cf4618063b127
kumaraditya303https://github.com/kumaraditya303
https://github.com/python/cpython/pull/96739#pullrequestreview-1103156019
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Sep 10, 2022https://github.com/python/cpython/pull/96739#issuecomment-1242770673
Please reload this pagehttps://github.com/python/cpython/pull/96739
mdickinsonhttps://github.com/mdickinson
September 13, 2022 20:04https://github.com/python/cpython/pull/96739#commits-pushed-994703e
https://github.com/mdickinson
Branch-free sign-extensionhttps://github.com/python/cpython/pull/96739/commits/994703e10e0af676559a7028ba77afee4e2bcb23
994703ehttps://github.com/python/cpython/pull/96739/commits/994703e10e0af676559a7028ba77afee4e2bcb23
https://github.com/mdickinson
Fix unconventional spacinghttps://github.com/python/cpython/pull/96739/commits/1294440b5c04c807f36911ab7d8721f87045ca90
1294440https://github.com/python/cpython/pull/96739/commits/1294440b5c04c807f36911ab7d8721f87045ca90
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Sep 13, 2022https://github.com/python/cpython/pull/96739#event-7379445901
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 13, 2022https://github.com/python/cpython/pull/96739#issuecomment-1245851207
@mdickinsonhttps://github.com/mdickinson
1294440https://github.com/python/cpython/commit/1294440b5c04c807f36911ab7d8721f87045ca90
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Sep 13, 2022https://github.com/python/cpython/pull/96739#event-7379446127
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 13, 2022https://github.com/python/cpython/pull/96739#issuecomment-1245861070
@kumaraditya303https://github.com/kumaraditya303
https://godbolt.org/z/e8roKrn6rhttps://godbolt.org/z/e8roKrn6r
https://godbolt.org/z/bPhbsT9Knhttps://godbolt.org/z/bPhbsT9Kn
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 14, 2022 https://github.com/python/cpython/pull/96739#ref-pullrequest-1365587204
gh-96678: A few asserts to demonstrate undefined behaviour matthiasgoergens/cpython#18 https://github.com/matthiasgoergens/cpython/pull/18
https://github.com/matthiasgoergens
matthiasgoergenshttps://github.com/matthiasgoergens
Sep 14, 2022https://github.com/python/cpython/pull/96739#issuecomment-1246678697
Please reload this pagehttps://github.com/python/cpython/pull/96739
#96821https://github.com/python/cpython/issues/96821
#96678 (comment)https://github.com/python/cpython/issues/96678#issuecomment-1243499193
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 18, 2022 https://github.com/python/cpython/pull/96739#ref-pullrequest-1376694436
PEP 7: Mention signed overflow explicitly python/peps#2796 https://github.com/python/peps/pull/2796
gh-96821: Add config option --with-strict-overflow #96823 https://github.com/python/cpython/pull/96823
Enable -fstrict-overflow #96821 https://github.com/python/cpython/issues/96821
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022https://github.com/python/cpython/pull/96739#issuecomment-1257155572
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
Sep 25, 2022https://github.com/python/cpython/pull/96739#event-7453165305
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Sep 25, 2022https://github.com/python/cpython/pull/96739#event-7453165307
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022https://github.com/python/cpython/pull/96739#issuecomment-1257158559
6281affhttps://github.com/python/cpython/commit/6281affee6423296893b509cd78dc563ca58b196
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
f5f047ahttps://github.com/python/cpython/commit/f5f047aa628caeca680745c55e24519f06aa6724
Sep 25, 2022https://github.com/python/cpython/pull/96739#event-7453187864
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 25, 2022https://github.com/python/cpython/pull/96739#event-7453187931
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
September 25, 2022 09:55https://github.com/python/cpython/pull/96739#event-7453188045
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
Sep 25, 2022 https://github.com/python/cpython/pull/96739#ref-issue-1368578739
Undefined behavior in struct.unpack #96735 https://github.com/python/cpython/issues/96735
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96739
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/96739/files/204e924c85e04b8ea8186c1dfa9cf4618063b127
Please reload this pagehttps://github.com/python/cpython/pull/96739
https://github.com/mdickinson
https://github.com/kumaraditya303
https://github.com/bedevere-bot
https://github.com/matthiasgoergens
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.