René's URL Explorer Experiment


Title: [3.10] gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests (GH-96135) by miss-islington · Pull Request #96235 · python/cpython · GitHub

Open Graph Title: [3.10] gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests (GH-96135) by miss-islington · Pull Request #96235 · python/cpython

X Title: [3.10] gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests (GH-96135) by miss-islington · Pull Request #96235 · python/cpython

Description: Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in del. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explicitly...

Open Graph Description: Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in del. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explicitly...

X Description: Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in del. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explicitly...

Mail addresses
storchaka@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/96235

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:43a2ad74-fc0b-e538-867c-8163214308a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99F4:2CF514:11B9B6:16F1CD:696B3327
html-safe-nonce97b0fea5c7633d506d626d2f272209e1366be76f54fbdbc5249f72fd66dd2c07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUY0OjJDRjUxNDoxMUI5QjY6MTZGMUNEOjY5NkIzMzI3IiwidmlzaXRvcl9pZCI6IjY3MTMyNTIyNjczMjM3NjU1NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4b544f9e012964dbf916d8c5d58d51757ef6ac6c8b5d53b52e968760d03cb435
hovercard-subject-tagpull_request:1035387463
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/96235/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4081dce2273db83015ea886459dce68270b7c31e68ed3e0a4a77eee774c7a955/python/cpython/pull/96235
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4081dce2273db83015ea886459dce68270b7c31e68ed3e0a4a77eee774c7a955/python/cpython/pull/96235
og:image:altTests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in del. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explicitly...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96235#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96235
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96235
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96235
Reloadhttps://github.com/python/cpython/pull/96235
Reloadhttps://github.com/python/cpython/pull/96235
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/96235
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/96235
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/96235#issue-comment-box
serhiy-storchakahttps://github.com/serhiy-storchaka
python:3.10https://github.com/python/cpython/tree/3.10
miss-islington:backport-4de06e3-3.10https://github.com/miss-islington/cpython/tree/backport-4de06e3-3.10
[3.10] gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests (GH-96135) https://github.com/python/cpython/pull/96235#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:3.10https://github.com/python/cpython/tree/3.10
miss-islington:backport-4de06e3-3.10https://github.com/miss-islington/cpython/tree/backport-4de06e3-3.10
Conversation 4 https://github.com/python/cpython/pull/96235
Commits 1 https://github.com/python/cpython/pull/96235/commits
Checks 0 https://github.com/python/cpython/pull/96235/checks
Files changed https://github.com/python/cpython/pull/96235/files
Please reload this pagehttps://github.com/python/cpython/pull/96235
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022https://github.com/python/cpython/pull/96235#issue-1349338964
Please reload this pagehttps://github.com/python/cpython/pull/96235
4de06e3https://github.com/python/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
IsolatedAsyncioTestCase __del__ could be dangerous  #96021https://github.com/python/cpython/issues/96021
Please reload this pagehttps://github.com/python/cpython/pull/96235
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Aug 24, 2022https://github.com/python/cpython/pull/96235#event-7250323119
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022https://github.com/python/cpython/pull/96235#issuecomment-1225633335
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/96235
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 24, 2022 https://github.com/python/cpython/pull/96235#ref-pullrequest-1345094128
gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests #96135 https://github.com/python/cpython/pull/96135
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Aug 24, 2022https://github.com/python/cpython/pull/96235#event-7250323552
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022https://github.com/python/cpython/pull/96235#issuecomment-1225633369
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/96235
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 24, 2022https://github.com/python/cpython/pull/96235#event-7250323662
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022https://github.com/python/cpython/pull/96235#issuecomment-1225633737
Please reload this pagehttps://github.com/python/cpython/pull/96235
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022https://github.com/python/cpython/pull/96235#issuecomment-1225656464
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/96235
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 25, 2022 https://github.com/python/cpython/pull/96235#pullrequestreview-1084781565
View reviewed changes https://github.com/python/cpython/pull/96235/files
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 25, 2022https://github.com/python/cpython/pull/96235#event-7256054344
https://github.com/serhiy-storchaka
pythongh-96021https://github.com/python/cpython/issues/96021
: Explicitly tear down the IsolatedAsyncioTestCase loop…https://github.com/python/cpython/pull/96235/commits/bc069b0fffa484c5938cda41384fc031c89c11bb
bc069b0https://github.com/python/cpython/pull/96235/commits/bc069b0fffa484c5938cda41384fc031c89c11bb
pythonGH-96135https://github.com/python/cpython/pull/96135
4de06e3https://github.com/miss-islington/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
force-pushedhttps://github.com/python/cpython/compare/7f2198a8fa9aa216d7e32e24863b46358d3934f3..bc069b0fffa484c5938cda41384fc031c89c11bb
7f2198ahttps://github.com/python/cpython/commit/7f2198a8fa9aa216d7e32e24863b46358d3934f3
bc069b0https://github.com/python/cpython/commit/bc069b0fffa484c5938cda41384fc031c89c11bb
Compare https://github.com/python/cpython/compare/7f2198a8fa9aa216d7e32e24863b46358d3934f3..bc069b0fffa484c5938cda41384fc031c89c11bb
August 27, 2022 17:36https://github.com/python/cpython/pull/96235#event-7272350603
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
9b070d3https://github.com/python/cpython/commit/9b070d361da2d1458ba005e2451b26d698c1fbf7
Aug 28, 2022https://github.com/python/cpython/pull/96235#event-7272921516
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 28, 2022https://github.com/python/cpython/pull/96235#event-7272921534
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
August 28, 2022 05:35https://github.com/python/cpython/pull/96235#event-7272921630
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96235
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/96235/files/7f2198a8fa9aa216d7e32e24863b46358d3934f3
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/96235
https://github.com/miss-islington
https://github.com/serhiy-storchaka
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.