René's URL Explorer Experiment


Title: gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests by serhiy-storchaka · Pull Request #96135 · python/cpython · GitHub

Open Graph Title: gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests by serhiy-storchaka · Pull Request #96135 · python/cpython

X Title: gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests by serhiy-storchaka · Pull Request #96135 · python/cpython

Description: Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in __del__. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explic...

Open Graph Description: Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in __del__. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explic...

X Description: Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in __del__. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explic...

Opengraph URL: https://github.com/python/cpython/pull/96135

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d634eeaf-d5df-1539-f11f-9e7064e1bd75
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABF8:2A0D62:28421F6:36A72D2:696AE01F
html-safe-nonce5a4ba30bdfd7277cc2b6bb4cba4d9aa6a742506f0bb0ee6df91951b9f9602126
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkY4OjJBMEQ2MjoyODQyMUY2OjM2QTcyRDI6Njk2QUUwMUYiLCJ2aXNpdG9yX2lkIjoiNzY4MDI0MzgyODk3MDUzNzI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf9ad0cd7853c3f99f1ebc33bf52a56c4955d1e9325205c1a91deed413e0f4519
hovercard-subject-tagpull_request:1031727716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/96135/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ddfd3415756448413b130da683ee6def069c02e4ce1d9ebf0fc5dd37c4fa8d13/python/cpython/pull/96135
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ddfd3415756448413b130da683ee6def069c02e4ce1d9ebf0fc5dd37c4fa8d13/python/cpython/pull/96135
og:image:altTests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in __del__. It makes tests depending on the GC an unreliable on other implementations. It is better to close the runner explic...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameserhiy-storchaka
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d84d50b3c75fa36755c3cf392edbc09e626f979
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/96135#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96135
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96135
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/96135
Reloadhttps://github.com/python/cpython/pull/96135
Reloadhttps://github.com/python/cpython/pull/96135
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/96135
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/96135
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/96135#issue-comment-box
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:test-async-case-debug-close-runnerhttps://github.com/serhiy-storchaka/cpython/tree/test-async-case-debug-close-runner
gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests https://github.com/python/cpython/pull/96135#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:test-async-case-debug-close-runnerhttps://github.com/serhiy-storchaka/cpython/tree/test-async-case-debug-close-runner
Conversation 3 https://github.com/python/cpython/pull/96135
Commits 2 https://github.com/python/cpython/pull/96135/commits
Checks 0 https://github.com/python/cpython/pull/96135/checks
Files changed https://github.com/python/cpython/pull/96135/files
Please reload this pagehttps://github.com/python/cpython/pull/96135
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 20, 2022https://github.com/python/cpython/pull/96135#issue-1345094128
gh-96021https://github.com/python/cpython/issues/96021
Please reload this pagehttps://github.com/python/cpython/pull/96135
https://github.com/serhiy-storchaka
pythongh-96021https://github.com/python/cpython/issues/96021
: Explicitly close the IsolatedAsyncioTestCase runner i…https://github.com/python/cpython/pull/96135/commits/f2af698d5aa3c3a1806385dad6c7a3bc9e2dc9d9
f2af698https://github.com/python/cpython/pull/96135/commits/f2af698d5aa3c3a1806385dad6c7a3bc9e2dc9d9
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Aug 20, 2022https://github.com/python/cpython/pull/96135#event-7226040080
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 20, 2022https://github.com/python/cpython/pull/96135#event-7226040116
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
August 20, 2022 08:37https://github.com/python/cpython/pull/96135#event-7226047687
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Aug 21, 2022https://github.com/python/cpython/pull/96135#event-7227423372
https://github.com/serhiy-storchaka
Call support.gc_collect() after test._tearDownAsyncioRunner(), nothttps://github.com/python/cpython/pull/96135/commits/02983cc3dbea2ac6f276bdf5f0d7a1da9a70f5cf
02983cchttps://github.com/python/cpython/pull/96135/commits/02983cc3dbea2ac6f276bdf5f0d7a1da9a70f5cf
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
4de06e3https://github.com/python/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
Aug 24, 2022https://github.com/python/cpython/pull/96135#event-7250321233
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022https://github.com/python/cpython/pull/96135#issuecomment-1225633106
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/96135
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 24, 2022https://github.com/python/cpython/pull/96135#event-7250321748
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
August 24, 2022 12:07https://github.com/python/cpython/pull/96135#event-7250321781
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 24, 2022https://github.com/python/cpython/pull/96135#issuecomment-1225633280
GH-96234https://github.com/python/cpython/pull/96234
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/96135
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Aug 24, 2022https://github.com/python/cpython/pull/96135#event-7250322969
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022 https://github.com/python/cpython/pull/96135#ref-commit-cb2487b
https://github.com/serhiy-storchaka
https://github.com/miss-islington
pythongh-96021https://github.com/python/cpython/issues/96021
: Explicitly close the IsolatedAsyncioTestCase runner i…https://github.com/miss-islington/cpython/commit/cb2487bdee1928deaa9437b31f920ed7f9b7806a
cb2487bhttps://github.com/miss-islington/cpython/commit/cb2487bdee1928deaa9437b31f920ed7f9b7806a
pythonGH-96135https://github.com/python/cpython/pull/96135
4de06e3https://github.com/miss-islington/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2022 https://github.com/python/cpython/pull/96135#ref-commit-7f2198a
https://github.com/serhiy-storchaka
https://github.com/miss-islington
pythongh-96021https://github.com/python/cpython/issues/96021
: Explicitly close the IsolatedAsyncioTestCase runner i…https://github.com/miss-islington/cpython/commit/7f2198a8fa9aa216d7e32e24863b46358d3934f3
7f2198ahttps://github.com/miss-islington/cpython/commit/7f2198a8fa9aa216d7e32e24863b46358d3934f3
pythonGH-96135https://github.com/python/cpython/pull/96135
4de06e3https://github.com/miss-islington/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 24, 2022https://github.com/python/cpython/pull/96135#issuecomment-1225633337
GH-96235https://github.com/python/cpython/pull/96235
3.10 branchhttps://github.com/python/cpython/tree/3.10
Please reload this pagehttps://github.com/python/cpython/pull/96135
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
Aug 24, 2022https://github.com/python/cpython/pull/96135#event-7250323394
mdboomhttps://github.com/mdboom
Aug 24, 2022 https://github.com/python/cpython/pull/96135#ref-commit-7efaa83
https://github.com/serhiy-storchaka
https://github.com/mdboom
pythongh-96021https://github.com/python/cpython/issues/96021
: Explicitly close the IsolatedAsyncioTestCase runner i…https://github.com/mdboom/cpython/commit/7efaa8307466f83b8bb8366cd11d39692623a4c4
7efaa83https://github.com/mdboom/cpython/commit/7efaa8307466f83b8bb8366cd11d39692623a4c4
pythonGH-96135https://github.com/python/cpython/pull/96135
miss-islingtonhttps://github.com/miss-islington
Aug 25, 2022 https://github.com/python/cpython/pull/96135#ref-commit-f51216d
https://github.com/miss-islington
https://github.com/serhiy-storchaka
gh-96021https://github.com/python/cpython/issues/96021
: Explicitly close the IsolatedAsyncioTestCase runner in tests (https://github.com/python/cpython/commit/f51216df073310c783f1890993fe9b67ccb3c6b4
f51216dhttps://github.com/python/cpython/commit/f51216df073310c783f1890993fe9b67ccb3c6b4
GH-96135https://github.com/python/cpython/pull/96135
4de06e3https://github.com/python/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 27, 2022 https://github.com/python/cpython/pull/96135#ref-commit-bc069b0
https://github.com/serhiy-storchaka
pythongh-96021https://github.com/python/cpython/issues/96021
: Explicitly tear down the IsolatedAsyncioTestCase loop…https://github.com/miss-islington/cpython/commit/bc069b0fffa484c5938cda41384fc031c89c11bb
bc069b0https://github.com/miss-islington/cpython/commit/bc069b0fffa484c5938cda41384fc031c89c11bb
pythonGH-96135https://github.com/python/cpython/pull/96135
4de06e3https://github.com/miss-islington/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 28, 2022 https://github.com/python/cpython/pull/96135#ref-commit-9b070d3
https://github.com/miss-islington
https://github.com/serhiy-storchaka
gh-96021https://github.com/python/cpython/issues/96021
: Explicitly tear down the IsolatedAsyncioTestCase loop in te…https://github.com/python/cpython/commit/9b070d361da2d1458ba005e2451b26d698c1fbf7
9b070d3https://github.com/python/cpython/commit/9b070d361da2d1458ba005e2451b26d698c1fbf7
GH-96135https://github.com/python/cpython/pull/96135
GH-96235https://github.com/python/cpython/pull/96235
4de06e3https://github.com/python/cpython/commit/4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Dec 13, 2022 https://github.com/python/cpython/pull/96135#ref-issue-1340040061
IsolatedAsyncioTestCase __del__ could be dangerous #96021 https://github.com/python/cpython/issues/96021
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F96135
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
IsolatedAsyncioTestCase __del__ could be dangerous https://github.com/python/cpython/issues/96021
Please reload this pagehttps://github.com/python/cpython/pull/96135
https://github.com/serhiy-storchaka
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.