Title: bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH by elprans · Pull Request #9607 · python/cpython · GitHub
Open Graph Title: bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH by elprans · Pull Request #9607 · python/cpython
X Title: bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH by elprans · Pull Request #9607 · python/cpython
Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit argument to py_compile.compile() or compileall. An environment variable should never override an explicit argument to a library function. That change leads to multiple test failures if the SOURCE_DATE_EPOCH environment variable is set. This changes py_compile.compile() to only look at SOURCE_DATE_EPOCH if no explicit invalidation_mode was specified. I also made various relevant tests run with explicit control over the value of SOURCE_DATE_EPOCH. While looking at this, I noticed that zipimport does not work with hash-based .pycs at all, though I left the fixes for subsequent commits. https://bugs.python.org/issue34022
Open Graph Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ...
X Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ...
Opengraph URL: https://github.com/python/cpython/pull/9607
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:08518950-20c0-ca1e-8f24-a9a4c90226e0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8BFC:174FB1:1D99876:27450F9:696AFD2E |
| html-safe-nonce | 5dfbe3fe81eb696e1cd28637ead4280304b27397278e02629eb08f121eb0c6f6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkZDOjE3NEZCMToxRDk5ODc2OjI3NDUwRjk6Njk2QUZEMkUiLCJ2aXNpdG9yX2lkIjoiMzAyNDYxMjI5OTEzODMzMzk5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1effe2869fe6dfbd2a32da3fdf07b846333303f421ea33aa2f945b1b924d31ff |
| hovercard-subject-tag | pull_request:218728744 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/9607/files |
| twitter:image | https://avatars.githubusercontent.com/u/347119?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/347119?s=400&v=4 |
| og:image:alt | Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width