| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fe31669e-1573-6085-c61a-450f3af94a47 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86BA:F2D7A:30D0D03:44095B6:6969366E |
| html-safe-nonce | fd4e41b0a19df0b8021f86050a31e1b9aba94e6c7aa63f5d4f24909b13924b49 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkJBOkYyRDdBOjMwRDBEMDM6NDQwOTVCNjo2OTY5MzY2RSIsInZpc2l0b3JfaWQiOiI0NjM2ODU0NjEwMTU0ODI5NDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fafadd5e36dbef022191ccca4d20d74789ca5975615f355aca59c8c866214dea |
| hovercard-subject-tag | pull_request:1022349725 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/95848/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/40c10aca7eb89e616ad52e8d0138bedf8389405f0cf94a42dc4d96ef76635f10/python/cpython/pull/95848 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/40c10aca7eb89e616ad52e8d0138bedf8389405f0cf94a42dc4d96ef76635f10/python/cpython/pull/95848 |
| og:image:alt | This is the non-refactoring part of #95505.
(Plus the ACKS fixup I forgot to include in #95819 😅)
Issue: Wrong sign placement in PyUnicode_FromFormat #95504 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | encukou |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/95848#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95848 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95848 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/95848 |
| Reload | https://github.com/python/cpython/pull/95848 |
| Reload | https://github.com/python/cpython/pull/95848 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/95848#issue-comment-box |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:unicode-from-format-negative | https://github.com/encukou/cpython/tree/unicode-from-format-negative |
|
gh-95504: Fix negative numbers in PyUnicode_FromFormat
| https://github.com/python/cpython/pull/95848#top |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:unicode-from-format-negative | https://github.com/encukou/cpython/tree/unicode-from-format-negative |
|
Conversation
5
| https://github.com/python/cpython/pull/95848 |
|
Commits
3
| https://github.com/python/cpython/pull/95848/commits |
|
Checks
0
| https://github.com/python/cpython/pull/95848/checks |
|
Files changed
| https://github.com/python/cpython/pull/95848/files |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95848#issue-1334214496 |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
| #95505 | https://github.com/python/cpython/pull/95505 |
| #95819 | https://github.com/python/cpython/pull/95819 |
| Wrong sign placement in PyUnicode_FromFormat #95504 | https://github.com/python/cpython/issues/95504 |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
|
| https://github.com/philg314 |
|
| https://github.com/encukou |
| Fix negative numbers in PyUnicode_FromFormat | https://github.com/python/cpython/pull/95848/commits/d2099ed2cc4d36e8c4a85d6f3382cf8e89b33496 |
| d2099ed | https://github.com/python/cpython/pull/95848/commits/d2099ed2cc4d36e8c4a85d6f3382cf8e89b33496 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95848#event-7161344712 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Aug 10, 2022
| https://github.com/python/cpython/pull/95848#ref-pullrequest-1323562810 |
|
gh-95504: Fix sign placement in PyUnicode_FromFormat
#95505
| https://github.com/python/cpython/pull/95505 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
|
Aug 10, 2022
| https://github.com/python/cpython/pull/95848#pullrequestreview-1067889968 |
|
View reviewed changes
| https://github.com/python/cpython/pull/95848/files/d2099ed2cc4d36e8c4a85d6f3382cf8e89b33496 |
| philg314 | https://github.com/philg314 |
| https://github.com/python/cpython/pull/95848#pullrequestreview-1067889968 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
| Doc/whatsnew/3.12.rst | https://github.com/python/cpython/pull/95848/files/d2099ed2cc4d36e8c4a85d6f3382cf8e89b33496#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
| Misc/NEWS.d/next/C API/2022-07-31-21-58-27.gh-issue-95504.wy7B1F.rst | https://github.com/python/cpython/pull/95848/files/d2099ed2cc4d36e8c4a85d6f3382cf8e89b33496#diff-5e5ce163f8757f7712ae14a987c14ec90d530e6192acce7e5bd7f71c07350961 |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
| encukou | https://github.com/encukou |
| August 10, 2022 11:04 | https://github.com/python/cpython/pull/95848#commits-pushed-e7c617f |
|
| https://github.com/encukou |
|
| https://github.com/philg314 |
| Apply What's New fixes | https://github.com/python/cpython/pull/95848/commits/e7c617f85c336c6965d0c63e3a33785fb3ca83c0 |
| e7c617f | https://github.com/python/cpython/pull/95848/commits/e7c617f85c336c6965d0c63e3a33785fb3ca83c0 |
|
| https://github.com/encukou |
| Remove trailing namespace in docs :/ | https://github.com/python/cpython/pull/95848/commits/bb48dfbd26d2efd30c945637d9c802ef74619ed2 |
| bb48dfb | https://github.com/python/cpython/pull/95848/commits/bb48dfbd26d2efd30c945637d9c802ef74619ed2 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| 71c3d64 | https://github.com/python/cpython/commit/71c3d649b5a0324c6eb01f9ad025c1e102b82bba |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95848#event-7162866303 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95848#event-7162866629 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| August 10, 2022 11:12 | https://github.com/python/cpython/pull/95848#event-7162867004 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
|
Aug 10, 2022
| https://github.com/python/cpython/pull/95848#pullrequestreview-1068389841 |
|
View reviewed changes
| https://github.com/python/cpython/pull/95848/files/bb48dfbd26d2efd30c945637d9c802ef74619ed2 |
| Doc/whatsnew/3.12.rst | https://github.com/python/cpython/pull/95848/files/e7c617f85c336c6965d0c63e3a33785fb3ca83c0..bb48dfbd26d2efd30c945637d9c802ef74619ed2#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
| philg314 | https://github.com/philg314 |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95848#discussion_r942524466 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
| encukou | https://github.com/encukou |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95848#discussion_r942564719 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
| https://github.com/kumaraditya303 |
| kumaraditya303 | https://github.com/kumaraditya303 |
|
Sep 4, 2022
| https://github.com/python/cpython/pull/95848#ref-issue-1323560587 |
|
Wrong sign placement in PyUnicode_FromFormat
#95504
| https://github.com/python/cpython/issues/95504 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95848 |
|
| https://github.com/philg314 |
|
philg314
| https://github.com/philg314 |
|
| https://github.com/python/cpython/pull/95848/files/bb48dfbd26d2efd30c945637d9c802ef74619ed2 |
| Please reload this page | https://github.com/python/cpython/pull/95848 |
|
| https://github.com/encukou |
|
| https://github.com/philg314 |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |