| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:153926d6-95f3-74da-6c8e-8f1813f14209 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3C4:3DE392:30FDAF2:446F95C:69693559 |
| html-safe-nonce | 775a152ad399b797e6b9dfaa2ff856f77da11638e31e27d5a6a5127fdf14b8d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0M0OjNERTM5MjozMEZEQUYyOjQ0NkY5NUM6Njk2OTM1NTkiLCJ2aXNpdG9yX2lkIjoiMjM5NTAzODQ5NTE5Mzc3MzQwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 90981d83751d65cf7c7d5efda55372b66b68653e8587665c1ef0f3ac24162ef7 |
| hovercard-subject-tag | pull_request:1013107801 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/95505/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e941abbb44bce3584591ca8845c795d0c39beda1a113194adba8af143f6ba57e/python/cpython/pull/95505 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e941abbb44bce3584591ca8845c795d0c39beda1a113194adba8af143f6ba57e/python/cpython/pull/95505 |
| og:image:alt | gh-95504: Fix sign placement in PyUnicode_FromFormat
The sign doesn't stick to the number anymore:
PyUnicode_FromFormat("d", -123); results in "-0123" instead of "0-... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | philg314 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/95505#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95505 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95505 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/95505 |
| Reload | https://github.com/python/cpython/pull/95505 |
| Reload | https://github.com/python/cpython/pull/95505 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/95505#issue-comment-box |
| philg314 | https://github.com/philg314 |
| python:main | https://github.com/python/cpython/tree/main |
| philg314:unicode-from-format-negative | https://github.com/philg314/cpython/tree/unicode-from-format-negative |
|
gh-95504: Fix sign placement in PyUnicode_FromFormat
| https://github.com/python/cpython/pull/95505#top |
| philg314 | https://github.com/philg314 |
| python:main | https://github.com/python/cpython/tree/main |
| philg314:unicode-from-format-negative | https://github.com/philg314/cpython/tree/unicode-from-format-negative |
|
Conversation
16
| https://github.com/python/cpython/pull/95505 |
|
Commits
8
| https://github.com/python/cpython/pull/95505/commits |
|
Checks
0
| https://github.com/python/cpython/pull/95505/checks |
|
Files changed
| https://github.com/python/cpython/pull/95505/files |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| Jul 31, 2022 | https://github.com/python/cpython/pull/95505#issue-1323562810 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| gh-95504 | https://github.com/python/cpython/issues/95504 |
| Wrong sign placement in PyUnicode_FromFormat #95504 | https://github.com/python/cpython/issues/95504 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| philg314 | https://github.com/philg314 |
| July 31, 2022 21:21 | https://github.com/python/cpython/pull/95505#commits-pushed-2d6f3e1 |
|
| https://github.com/philg314 |
| Add tests for PyUnicode_FromFormat | https://github.com/python/cpython/pull/95505/commits/2d6f3e1125a4cf2f3744fb02f9cf959624cceca1 |
| 2d6f3e1 | https://github.com/python/cpython/pull/95505/commits/2d6f3e1125a4cf2f3744fb02f9cf959624cceca1 |
|
| https://github.com/philg314 |
| Fix negative numbers in PyUnicode_FromFormat | https://github.com/python/cpython/pull/95505/commits/bd72e2a6f012bea145bef94471f1247492796b35 |
| bd72e2a | https://github.com/python/cpython/pull/95505/commits/bd72e2a6f012bea145bef94471f1247492796b35 |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Jul 31, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1200490610 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432b8b111ec9bf5bfe9ad6c72c4 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jul 31, 2022 | https://github.com/python/cpython/pull/95505#event-7096773704 |
| https://github.com/corona10 |
| corona10 | https://github.com/corona10 |
| methane | https://github.com/methane |
| August 1, 2022 03:03 | https://github.com/python/cpython/pull/95505#event-7097615261 |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Aug 1, 2022
| https://github.com/python/cpython/pull/95505#pullrequestreview-1056979151 |
|
View reviewed changes
| https://github.com/python/cpython/pull/95505/files/bd72e2a6f012bea145bef94471f1247492796b35 |
| methane | https://github.com/methane |
| https://github.com/python/cpython/pull/95505#pullrequestreview-1056979151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 1, 2022 | https://github.com/python/cpython/pull/95505#event-7099580500 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| Aug 1, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1201359898 |
| @encukou | https://github.com/encukou |
| #93649 | https://github.com/python/cpython/issues/93649 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| August 1, 2022 15:33 | https://github.com/python/cpython/pull/95505#event-7102676241 |
| philg314 | https://github.com/philg314 |
| August 2, 2022 05:04 | https://github.com/python/cpython/pull/95505#commits-pushed-95b4f83 |
|
| https://github.com/philg314 |
| Merge remote-tracking branch 'upstream/main' into unicode-from-format… | https://github.com/python/cpython/pull/95505/commits/95b4f830c5b66c36f5f1830db741aee57d2452b1 |
| 95b4f83 | https://github.com/python/cpython/pull/95505/commits/95b4f830c5b66c36f5f1830db741aee57d2452b1 |
|
| https://github.com/philg314 |
| Add whatsnew | https://github.com/python/cpython/pull/95505/commits/99b0ebcc108df0e33f81eef418c4917714371705 |
| 99b0ebc | https://github.com/python/cpython/pull/95505/commits/99b0ebcc108df0e33f81eef418c4917714371705 |
|
| https://github.com/philg314 |
| pythongh-93649 | https://github.com/python/cpython/issues/93649 |
| : Split unicode tests from _testcapimodule.c | https://github.com/python/cpython/pull/95505/commits/63e9afdab78b6d28223bb1345ac2892ead310873 |
| 63e9afd | https://github.com/python/cpython/pull/95505/commits/63e9afdab78b6d28223bb1345ac2892ead310873 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| August 2, 2022 03:28 | https://github.com/python/cpython/pull/95505#event-7106322219 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| code owner | https://github.com/python/cpython/blob/d2c1a9c76c001b18c14e50779b0ee41ea4ccf0b3/.github/CODEOWNERS#L113 |
| August 2, 2022 03:28 | https://github.com/python/cpython/pull/95505#event-7106322244 |
| philg314 | https://github.com/philg314 |
| August 6, 2022 13:00 | https://github.com/python/cpython/pull/95505#commits-pushed-d70fa1f |
|
| https://github.com/philg314 |
| Use built-in AssertionError | https://github.com/python/cpython/pull/95505/commits/d70fa1f0376ad2c5150becf23ab0622a8b5c7ada |
| d70fa1f | https://github.com/python/cpython/pull/95505/commits/d70fa1f0376ad2c5150becf23ab0622a8b5c7ada |
|
| https://github.com/philg314 |
| Merge remote-tracking branch 'upstream/main' into unicode-from-format… | https://github.com/python/cpython/pull/95505/commits/79a8138bc0e7fe226a735a8eeaca36f46786dac7 |
| 79a8138 | https://github.com/python/cpython/pull/95505/commits/79a8138bc0e7fe226a735a8eeaca36f46786dac7 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| Aug 6, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1207197938 |
| @encukou | https://github.com/encukou |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| August 7, 2022 08:50 | https://github.com/python/cpython/pull/95505#event-7141909468 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Aug 7, 2022
| https://github.com/python/cpython/pull/95505#pullrequestreview-1064390550 |
|
View reviewed changes
| https://github.com/python/cpython/pull/95505/files/79a8138bc0e7fe226a735a8eeaca36f46786dac7 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://github.com/python/cpython/pull/95505#pullrequestreview-1064390550 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| Misc/ACKS | https://github.com/python/cpython/pull/95505/files/79a8138bc0e7fe226a735a8eeaca36f46786dac7#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| Objects/unicodeobject.c | https://github.com/python/cpython/pull/95505/files/79a8138bc0e7fe226a735a8eeaca36f46786dac7#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| Objects/unicodeobject.c | https://github.com/python/cpython/pull/95505/files/79a8138bc0e7fe226a735a8eeaca36f46786dac7#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Aug 7, 2022 | https://github.com/python/cpython/pull/95505#discussion_r939634797 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| philg314 | https://github.com/philg314 |
| Aug 7, 2022 | https://github.com/python/cpython/pull/95505#discussion_r939640880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
|
| https://github.com/philg314 |
| Implement requested changes | https://github.com/python/cpython/pull/95505/commits/e8d0edfc16dbd365e59dc3d7013e9691b6d35390 |
| e8d0edf | https://github.com/python/cpython/pull/95505/commits/e8d0edfc16dbd365e59dc3d7013e9691b6d35390 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Aug 8, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1207923925 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| Aug 8, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1207946108 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
|
gh-93649: Split unicode tests from _testcapimodule.c & add some more
#95819
| https://github.com/python/cpython/pull/95819 |
|
gh-95504: Fix negative numbers in PyUnicode_FromFormat
#95848
| https://github.com/python/cpython/pull/95848 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1210289879 |
| @philg314 | https://github.com/philg314 |
| #95819 | https://github.com/python/cpython/pull/95819 |
| #95848 | https://github.com/python/cpython/pull/95848 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1210527645 |
| #95819 | https://github.com/python/cpython/pull/95819 |
| #95848 | https://github.com/python/cpython/pull/95848 |
| @philg314 | https://github.com/philg314 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95505#event-7162873981 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| Aug 10, 2022 | https://github.com/python/cpython/pull/95505#issuecomment-1210754917 |
| @methane | https://github.com/methane |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| @encukou | https://github.com/encukou |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
| https://github.com/philg314 |
| philg314 | https://github.com/philg314 |
| August 10, 2022 14:28 | https://github.com/python/cpython/pull/95505#event-7164380467 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Aug 15, 2022
| https://github.com/python/cpython/pull/95505#ref-issue-1338740953 |
|
Test Limited API in _testcapi module
#95991
| https://github.com/python/cpython/issues/95991 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95505 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/95505/files/79a8138bc0e7fe226a735a8eeaca36f46786dac7 |
|
| https://github.com/methane |
|
methane
| https://github.com/methane |
|
| https://github.com/python/cpython/pull/95505/files/bd72e2a6f012bea145bef94471f1247492796b35 |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Please reload this page | https://github.com/python/cpython/pull/95505 |
|
| https://github.com/philg314 |
|
| https://github.com/encukou |
|
| https://github.com/methane |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |