René's URL Explorer Experiment


Title: bpo-5950: Support reading zips with comments in zipimport by ZackerySpytz · Pull Request #9548 · python/cpython · GitHub

Open Graph Title: bpo-5950: Support reading zips with comments in zipimport by ZackerySpytz · Pull Request #9548 · python/cpython

X Title: bpo-5950: Support reading zips with comments in zipimport by ZackerySpytz · Pull Request #9548 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Some of the code is based on _EndRecData() in Lib/zipfile.py. https://bugs.python.org/issue5950

X Description: Some of the code is based on _EndRecData() in Lib/zipfile.py. https://bugs.python.org/issue5950

Opengraph URL: https://github.com/python/cpython/pull/9548

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7662582e-f1db-1af2-bd59-efdbd69924e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id814A:4D9F2:234E26E:2E98301:6B025201
html-safe-nonce27c9b66eab7785e515c0e0207d7cb534f0273864396454d2a5ffc18d36085c4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTRBOjREOUYyOjIzNEUyNkU6MkU5ODMwMTo2QjAyNTIwMSIsInZpc2l0b3JfaWQiOiI3NTQ4MDEyODcyNTI2MzUyODk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca8103ad565159fed9e4707364251abf68dab4c0f0f4a24b0bbb3e6891da1ecdb
hovercard-subject-tagpull_request:217778619
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/9548/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/632ee7ecd64708bba3bdd6bccf35d1a95cfadc5858119386bddaabeccbdf4dbd/python/cpython/pull/9548
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/632ee7ecd64708bba3bdd6bccf35d1a95cfadc5858119386bddaabeccbdf4dbd/python/cpython/pull/9548
og:image:altSome of the code is based on _EndRecData() in Lib/zipfile.py. https://bugs.python.org/issue5950
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZackerySpytz
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/9548#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9548
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9548
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9548
Reloadhttps://github.com/python/cpython/pull/9548
Reloadhttps://github.com/python/cpython/pull/9548
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
warsawhttps://github.com/warsaw
python:masterhttps://github.com/python/cpython/tree/master
ZackerySpytz:bpo-5950-zipimport-zip-commentshttps://github.com/ZackerySpytz/cpython/tree/bpo-5950-zipimport-zip-comments
Conversationhttps://github.com/python/cpython/pull/9548
Commits2 (2)https://github.com/python/cpython/pull/9548/commits
Checkshttps://github.com/python/cpython/pull/9548/checks
Files changedhttps://github.com/python/cpython/pull/9548/files
bpo-5950: Support reading zips with comments in zipimporthttps://github.com/python/cpython/pull/9548#top
warsawhttps://github.com/warsaw
python:masterhttps://github.com/python/cpython/tree/master
ZackerySpytz:bpo-5950-zipimport-zip-commentshttps://github.com/ZackerySpytz/cpython/tree/bpo-5950-zipimport-zip-comments
https://github.com/ZackerySpytz
ZackerySpytzhttps://github.com/ZackerySpytz
Sep 24, 2018https://github.com/python/cpython/pull/9548#issue-363308083
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://bugs.python.org/issue5950https://bugs.python.org/issue5950
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/ZackerySpytz
bpo-5950: Support reading zips with comments in zipimporthttps://github.com/python/cpython/pull/9548/commits/49cee0d89da15b15b2acc783b9f3ca3b8245008d
49cee0dhttps://github.com/python/cpython/pull/9548/commits/49cee0d89da15b15b2acc783b9f3ca3b8245008d
https://github.com/ZackerySpytz
ZackerySpytzhttps://github.com/ZackerySpytz
September 24, 2018 20:29https://github.com/python/cpython/pull/9548#event-1864112296
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 24, 2018https://github.com/python/cpython/pull/9548#event-1864112362
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 24, 2018https://github.com/python/cpython/pull/9548#event-1864112383
https://github.com/dsamersoff
dsamersoffhttps://github.com/dsamersoff
Sep 25, 2018https://github.com/python/cpython/pull/9548#issuecomment-424247694
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/warsaw
warsawhttps://github.com/warsaw
Sep 25, 2018 https://github.com/python/cpython/pull/9548#pullrequestreview-158576974
View reviewed changes https://github.com/python/cpython/pull/9548/files/49cee0d89da15b15b2acc783b9f3ca3b8245008d
warsawhttps://github.com/warsaw
https://github.com/python/cpython/pull/9548#pullrequestreview-158576974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
Lib/test/test_zipimport.pyhttps://github.com/python/cpython/pull/9548/files/49cee0d89da15b15b2acc783b9f3ca3b8245008d#diff-7bd348e163b82b8878ad3bf3a9393e975b3caefdf03a2f6cef471992d2339232
Please reload this pagehttps://github.com/python/cpython/pull/9548
Lib/zipimport.pyhttps://github.com/python/cpython/pull/9548/files/49cee0d89da15b15b2acc783b9f3ca3b8245008d#diff-0ab01fa6f64b682ece9d2ebacbdada9f8c559116d01f5ab6c7736ce0c5569ec9
warsawhttps://github.com/warsaw
Sep 25, 2018https://github.com/python/cpython/pull/9548#discussion_r220220498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
ZackerySpytzhttps://github.com/ZackerySpytz
Sep 25, 2018https://github.com/python/cpython/pull/9548#discussion_r220286513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
Lib/zipimport.pyhttps://github.com/python/cpython/pull/9548/files/49cee0d89da15b15b2acc783b9f3ca3b8245008d#diff-0ab01fa6f64b682ece9d2ebacbdada9f8c559116d01f5ab6c7736ce0c5569ec9
warsawhttps://github.com/warsaw
Sep 25, 2018https://github.com/python/cpython/pull/9548#discussion_r220220668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
ZackerySpytzhttps://github.com/ZackerySpytz
Sep 25, 2018https://github.com/python/cpython/pull/9548#discussion_r220286548
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
Lib/zipimport.pyhttps://github.com/python/cpython/pull/9548/files/49cee0d89da15b15b2acc783b9f3ca3b8245008d#diff-0ab01fa6f64b682ece9d2ebacbdada9f8c559116d01f5ab6c7736ce0c5569ec9
warsawhttps://github.com/warsaw
Sep 25, 2018https://github.com/python/cpython/pull/9548#discussion_r220220936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
ZackerySpytzhttps://github.com/ZackerySpytz
Sep 25, 2018https://github.com/python/cpython/pull/9548#discussion_r220286579
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 25, 2018https://github.com/python/cpython/pull/9548#issuecomment-424371564
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 25, 2018https://github.com/python/cpython/pull/9548#event-1865945437
https://github.com/ZackerySpytz
Address comments.https://github.com/python/cpython/pull/9548/commits/09dbd17fa63842d76199c21517ab9173f27ed109
09dbd17https://github.com/python/cpython/pull/9548/commits/09dbd17fa63842d76199c21517ab9173f27ed109
https://github.com/ZackerySpytz
ZackerySpytzhttps://github.com/ZackerySpytz
Sep 25, 2018https://github.com/python/cpython/pull/9548#issuecomment-424434523
@warsawhttps://github.com/warsaw
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Sep 25, 2018https://github.com/python/cpython/pull/9548#event-1866416583
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 25, 2018https://github.com/python/cpython/pull/9548#issuecomment-424434540
@warsawhttps://github.com/warsaw
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/warsaw
warsawhttps://github.com/warsaw
Sep 25, 2018 https://github.com/python/cpython/pull/9548#pullrequestreview-158701996
View reviewed changes https://github.com/python/cpython/pull/9548/files/09dbd17fa63842d76199c21517ab9173f27ed109
warsawhttps://github.com/warsaw
https://github.com/python/cpython/pull/9548#pullrequestreview-158701996
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Sep 25, 2018https://github.com/python/cpython/pull/9548#event-1866638109
https://github.com/warsaw
warsawhttps://github.com/warsaw
5a5ce06https://github.com/python/cpython/commit/5a5ce064b3baadcb79605c5a42ee3d0aee57cdfc
Sep 25, 2018https://github.com/python/cpython/pull/9548#event-1866639214
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 25, 2018https://github.com/python/cpython/pull/9548#issuecomment-424467004
@warsawhttps://github.com/warsaw
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 25, 2018https://github.com/python/cpython/pull/9548#event-1866639291
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9548
https://github.com/warsaw
warsaw https://github.com/warsaw
https://github.com/python/cpython/pull/9548/files/09dbd17fa63842d76199c21517ab9173f27ed109
Please reload this pagehttps://github.com/python/cpython/pull/9548
Please reload this pagehttps://github.com/python/cpython/pull/9548
https://github.com/ZackerySpytz
https://github.com/dsamersoff
https://github.com/bedevere-bot
https://github.com/warsaw
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.