Title: [3.10] gh-95041: Fix several minor issues in syslog.openlog() (GH-95058) by miss-islington · Pull Request #95262 · python/cpython · GitHub
Open Graph Title: [3.10] gh-95041: Fix several minor issues in syslog.openlog() (GH-95058) by miss-islington · Pull Request #95262 · python/cpython
X Title: [3.10] gh-95041: Fix several minor issues in syslog.openlog() (GH-95058) by miss-islington · Pull Request #95262 · python/cpython
Description: syslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally in the previous call to openlog() points to the freed memory. PySys_Audit() can crash if ident is NULL. There may be a race condition with syslog.syslog(), because the global reference to ident is decrefed before setting the new value. Possible use of freed memory if syslog.openlog() is called while the GIL is released in syslog.syslog(). (cherry picked from commit 68c555a) Co-authored-by: Serhiy Storchaka storchaka@gmail.com Issue: gh-95041
Open Graph Description: syslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally i...
X Description: syslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally i...
Opengraph URL: https://github.com/python/cpython/pull/95262
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:79fba1b3-4b2d-467e-239b-4767045eae07 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D33E:1CD6E3:87F70C:BDE302:696A5AA7 |
| html-safe-nonce | 8d5be33a1a5b8c0f19089e2ca25cad0eeafcfd550d9ec7c2cf6a5b4eddee60cd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzNFOjFDRDZFMzo4N0Y3MEM6QkRFMzAyOjY5NkE1QUE3IiwidmlzaXRvcl9pZCI6Ijc5MzYzNjIyODIxMDA2MTE3NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d412245598be2722d80c6090b859e71ef782f7b7ce2170c802e34985f1e2dc6c |
| hovercard-subject-tag | pull_request:1008092872 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/95262/files |
| twitter:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| og:image:alt | syslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally i... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width