René's URL Explorer Experiment


Title: gh-69426: only unescape properly terminated character entities in attribute values by sissbruecker · Pull Request #95215 · python/cpython · GitHub

Open Graph Title: gh-69426: only unescape properly terminated character entities in attribute values by sissbruecker · Pull Request #95215 · python/cpython

X Title: gh-69426: only unescape properly terminated character entities in attribute values by sissbruecker · Pull Request #95215 · python/cpython

Description: Fixes HTMLParser to only unescape named character references in attribute values if they are properly terminated. According to the HTML5 spec, named character references in attribute values should only be processed if they are not followed by an ASCII alphanumeric, or an equals sign. So the following references should be unescaped: ¢ ¢ foo ¢-foo While the following should not: ¢er ¢= This change adds an attribute value specific character unescaping logic that should cover these cases. Fixes: #69426 Issue: gh-69426

Open Graph Description: Fixes HTMLParser to only unescape named character references in attribute values if they are properly terminated. According to the HTML5 spec, named character references in attribute values should ...

X Description: Fixes HTMLParser to only unescape named character references in attribute values if they are properly terminated. According to the HTML5 spec, named character references in attribute values should ...

Opengraph URL: https://github.com/python/cpython/pull/95215

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f1211082-3e93-9ead-bee9-a395f37260d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA58:3F7705:2083F0E:2C432FC:6A5412C4
html-safe-noncee5f224a58f3ddb9a36d737d5a246a2b93f873cf7e21a1bcd40436550fcbf3fa1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTU4OjNGNzcwNToyMDgzRjBFOjJDNDMyRkM6NkE1NDEyQzQiLCJ2aXNpdG9yX2lkIjoiODA5ODYzNjA5Nzk5ODAzMzYwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac552907bd84ae0a447e1f6894612016cab08df8f6ff7a291b5abdb1921fd523fd
hovercard-subject-tagpull_request:1006607452
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/95215/files
twitter:imagehttps://avatars.githubusercontent.com/u/357820?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/357820?s=400&v=4
og:image:altFixes HTMLParser to only unescape named character references in attribute values if they are properly terminated. According to the HTML5 spec, named character references in attribute values should ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/95215/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95215%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95215%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/95215/files
Reloadhttps://github.com/python/cpython/pull/95215/files
Reloadhttps://github.com/python/cpython/pull/95215/files
Please reload this pagehttps://github.com/python/cpython/pull/95215/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/95215/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
sissbruecker:gh-69426-htmlparser-attribute-entitieshttps://github.com/sissbruecker/cpython/tree/gh-69426-htmlparser-attribute-entities
Conversation 31 https://github.com/python/cpython/pull/95215
Commits 8 https://github.com/python/cpython/pull/95215/commits
Checks 0 https://github.com/python/cpython/pull/95215/checks
Files changed https://github.com/python/cpython/pull/95215/files
Please reload this pagehttps://github.com/python/cpython/pull/95215/files
gh-69426: only unescape properly terminated character entities in attribute values https://github.com/python/cpython/pull/95215/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/95215/files
71a89f9 gh-69426: only unescape properly terminated character entities in att… sissbruecker Jul 24, 2022 https://github.com/python/cpython/pull/95215/commits/71a89f98c31e2f1285221568de73fbc1e09ad84d
bebae0a fix typo sissbruecker Jul 24, 2022 https://github.com/python/cpython/pull/95215/commits/bebae0aca8a4f40a6c48428852dd44436f7c1a2e
a7af750 Address review comments in parser.py sissbruecker Jan 14, 2023 https://github.com/python/cpython/pull/95215/commits/a7af75064a0262994177d9c3800707c3921c2a59
f915b19 Extract attribute tests from test_convert_charrefs sissbruecker Jan 14, 2023 https://github.com/python/cpython/pull/95215/commits/f915b193d1deef20be7a84e3ebd9bfca7e623350
6c65830 Refactor attribute unescape tests sissbruecker Jan 14, 2023 https://github.com/python/cpython/pull/95215/commits/6c65830dcdcb6fcfd1a22293cce85346674861ae
e8263ae Merge branch 'main' into gh-69426-htmlparser-attribute-entities serhiy-storchaka May 6, 2025 https://github.com/python/cpython/pull/95215/commits/e8263aed14201dc7da35644c7e01c1f8408c0cbc
ec1341b address review comments sissbruecker May 6, 2025 https://github.com/python/cpython/pull/95215/commits/ec1341bee1e0e6ca41126e1d300067c02555f2d4
fb77f97 fix docs class reference sissbruecker May 6, 2025 https://github.com/python/cpython/pull/95215/commits/fb77f973c122b62a37be77e0f72a8fc272161020
Clear filters https://github.com/python/cpython/pull/95215/files
Please reload this pagehttps://github.com/python/cpython/pull/95215/files
Please reload this pagehttps://github.com/python/cpython/pull/95215/files
parser.py https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
test_htmlparser.py https://github.com/python/cpython/pull/95215/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
2022-07-24-20-56-32.gh-issue-69426.unccw7.rst https://github.com/python/cpython/pull/95215/files#diff-0c7596b4a40fd4b2463cb709073585d5cd689d4a93b4c8e1134ecf23da39e057
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L498
Lib/html/parser.pyhttps://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
View file https://github.com/sissbruecker/cpython/blob/fb77f973c122b62a37be77e0f72a8fc272161020/Lib/html/parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/95215/{{ revealButtonHref }}
https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
serhiy-storchakahttps://github.com/serhiy-storchaka
May 7, 2025https://github.com/python/cpython/pull/95215/files#r2076838530
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/95215/files
https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
https://github.com/python/cpython/pull/95215/files#diff-da26f443eb16696a27ae56d506f3350528284855872c7fc98cb5a9231550ead8
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L500
Lib/test/test_htmlparser.pyhttps://github.com/python/cpython/pull/95215/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
View file https://github.com/sissbruecker/cpython/blob/fb77f973c122b62a37be77e0f72a8fc272161020/Lib/test/test_htmlparser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/95215/{{ revealButtonHref }}
https://github.com/python/cpython/pull/95215/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
https://github.com/python/cpython/pull/95215/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
https://github.com/python/cpython/pull/95215/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
Misc/NEWS.d/next/Library/2022-07-24-20-56-32.gh-issue-69426.unccw7.rsthttps://github.com/python/cpython/pull/95215/files#diff-0c7596b4a40fd4b2463cb709073585d5cd689d4a93b4c8e1134ecf23da39e057
View file https://github.com/sissbruecker/cpython/blob/fb77f973c122b62a37be77e0f72a8fc272161020/Misc/NEWS.d/next/Library/2022-07-24-20-56-32.gh-issue-69426.unccw7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/95215/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.