René's URL Explorer Experiment


Title: bpo-34780: Fix potential hang during stdin initialization on Windows by izbyshev · Pull Request #9520 · python/cpython · GitHub

Open Graph Title: bpo-34780: Fix potential hang during stdin initialization on Windows by izbyshev · Pull Request #9520 · python/cpython

X Title: bpo-34780: Fix potential hang during stdin initialization on Windows by izbyshev · Pull Request #9520 · python/cpython

Description: On Windows, if there is an outstanding operation on a synchronous pipe handle (e.g., ReadFile()), many other operations will block until the first one completes. This is true even for operations that normally complete immediately (PeekNamedPipe(), SetFilePointer(), etc.). Python performs fstat(fd) during file object initialization to check for attempts to open a directory, which is forbidden. If fd refers to a pipe, msvcrt calls PeekNamedPipe() to fill in st_size member of struct stat, potentially hanging the interpreter before execution of user code when stdin object is initialized in the conditions described above. fstat() on Windows can't distinguish between a file and a directory because it relies on GetFileType(), which returns FILE_TYPE_DISK in both cases. Therefore, skipping the no-op check avoids the hang. https://bugs.python.org/issue34780

Open Graph Description: On Windows, if there is an outstanding operation on a synchronous pipe handle (e.g., ReadFile()), many other operations will block until the first one completes. This is true even for operations th...

X Description: On Windows, if there is an outstanding operation on a synchronous pipe handle (e.g., ReadFile()), many other operations will block until the first one completes. This is true even for operations th...

Opengraph URL: https://github.com/python/cpython/pull/9520

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1eef698f-a9ec-a5f9-d735-27a94a45ae3b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA9E:1E7225:266A52:35465D:6A63029D
html-safe-nonce23987ac7e97849b4cf36dd393bc0164a545eeeebbeb96c81de2658f57506c8a1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTlFOjFFNzIyNToyNjZBNTI6MzU0NjVEOjZBNjMwMjlEIiwidmlzaXRvcl9pZCI6Ijg3MTE4MDU0MTYwOTAzMDUxODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac012b49c1db69d7c4b0c3716f7173b5340aca936787cee54f798cef6a29a226df
hovercard-subject-tagpull_request:217528308
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/9520/files
twitter:imagehttps://avatars.githubusercontent.com/u/11427362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11427362?s=400&v=4
og:image:altOn Windows, if there is an outstanding operation on a synchronous pipe handle (e.g., ReadFile()), many other operations will block until the first one completes. This is true even for operations th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None14517cd57568049be7ed25bfe9708f10d1e36b7254adfd920dfb9d44bcc71c41
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b2ed33e3827bc186c45c037f9274b5493aaca4c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9520/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9520%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9520%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9520/files
Reloadhttps://github.com/python/cpython/pull/9520/files
Reloadhttps://github.com/python/cpython/pull/9520/files
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
izbyshevhttps://github.com/izbyshev
python:2.7https://github.com/python/cpython/tree/2.7
izbyshev:bpo-34780https://github.com/izbyshev/cpython/tree/bpo-34780
Conversation 10 https://github.com/python/cpython/pull/9520
Commits 1 https://github.com/python/cpython/pull/9520/commits
Checks 0 https://github.com/python/cpython/pull/9520/checks
Files changed https://github.com/python/cpython/pull/9520/files
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
bpo-34780: Fix potential hang during stdin initialization on Windows https://github.com/python/cpython/pull/9520/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/9520/files
33cf462 bpo-34780: Fix potential hang during stdin initialization on Windows Sep 23, 2018 https://github.com/python/cpython/pull/9520/commits/33cf4629a493a7adb9fdc3655d4639bf6c4014dc
Clear filters https://github.com/python/cpython/pull/9520/files
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
test_io.py https://github.com/python/cpython/pull/9520/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
2018-09-23-23-02-46.bpo-34780.PIJ3OU.rst https://github.com/python/cpython/pull/9520/files#diff-2a44d8caa4b8035d9279bbf667cf74625eb2b6617012a465c4d2ec20d7a8043c
posixmodule.c https://github.com/python/cpython/pull/9520/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
fileobject.c https://github.com/python/cpython/pull/9520/files#diff-2d7216c74ba0507849abd705ce8f24fa7dfa147ed60ce6ff0e42a24c4c2301e6
Lib/test/test_io.pyhttps://github.com/python/cpython/pull/9520/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
View file https://github.com/izbyshev/cpython/blob/33cf4629a493a7adb9fdc3655d4639bf6c4014dc/Lib/test/test_io.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9520/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9520/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/9520/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/9520/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/9520/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
Misc/NEWS.d/next/Windows/2018-09-23-23-02-46.bpo-34780.PIJ3OU.rsthttps://github.com/python/cpython/pull/9520/files#diff-2a44d8caa4b8035d9279bbf667cf74625eb2b6617012a465c4d2ec20d7a8043c
View file https://github.com/izbyshev/cpython/blob/33cf4629a493a7adb9fdc3655d4639bf6c4014dc/Misc/NEWS.d/next/Windows/2018-09-23-23-02-46.bpo-34780.PIJ3OU.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9520/{{ revealButtonHref }}
Modules/posixmodule.chttps://github.com/python/cpython/pull/9520/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/izbyshev/cpython/blob/33cf4629a493a7adb9fdc3655d4639bf6c4014dc/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9520/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9520/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
eryksunhttps://github.com/eryksun
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220505236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
izbyshevhttps://github.com/izbyshev
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220568704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
eryksunhttps://github.com/eryksun
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220675393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
https://github.com/python/cpython/pull/9520/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
Objects/fileobject.chttps://github.com/python/cpython/pull/9520/files#diff-2d7216c74ba0507849abd705ce8f24fa7dfa147ed60ce6ff0e42a24c4c2301e6
View file https://github.com/izbyshev/cpython/blob/33cf4629a493a7adb9fdc3655d4639bf6c4014dc/Objects/fileobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9520/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9520/files#diff-2d7216c74ba0507849abd705ce8f24fa7dfa147ed60ce6ff0e42a24c4c2301e6
eryksunhttps://github.com/eryksun
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220506803
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
izbyshevhttps://github.com/izbyshev
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220576779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
eryksunhttps://github.com/eryksun
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220677334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
izbyshevhttps://github.com/izbyshev
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220691713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
abovehttps://github.com/python/cpython/pull/9520#discussion_r220675393
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
eryksunhttps://github.com/eryksun
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220698167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
izbyshevhttps://github.com/izbyshev
Sep 26, 2018https://github.com/python/cpython/pull/9520/files#r220751000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9520/files
https://github.com/python/cpython/pull/9520/files#diff-2d7216c74ba0507849abd705ce8f24fa7dfa147ed60ce6ff0e42a24c4c2301e6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.