René's URL Explorer Experiment


Title: gh-95041: Fix several minor issues in syslog.openlog() by serhiy-storchaka · Pull Request #95058 · python/cpython · GitHub

Open Graph Title: gh-95041: Fix several minor issues in syslog.openlog() by serhiy-storchaka · Pull Request #95058 · python/cpython

X Title: gh-95041: Fix several minor issues in syslog.openlog() by serhiy-storchaka · Pull Request #95058 · python/cpython

Description: syslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally in the previous call to openlog() points to the freed memory. PySys_Audit() can crash if ident is NULL. There may be a race condition with syslog.syslog(), because the global reference to ident is decrefed before setting the new value. Issue: gh-95041

Open Graph Description: syslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally i...

X Description: syslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally i...

Opengraph URL: https://github.com/python/cpython/pull/95058

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5a6e5697-24ac-45f6-7473-aef31ea16b5c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8114:920F1:8C31E2:C7ECCF:696A5A64
html-safe-nonce8b38fb36aeb3fcb63b19189e6fbc90d3d2d88bf742ccfd109d45e2b2a8204c97
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTE0OjkyMEYxOjhDMzFFMjpDN0VDQ0Y6Njk2QTVBNjQiLCJ2aXNpdG9yX2lkIjoiNzI3NTA4NzE3NDIyMDUzNjQyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7207b1fe9bf26f0e8388be9172553351f4a72046011b4c70cfa317c5ab623e78
hovercard-subject-tagpull_request:1002517469
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/95058/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altsyslog_get_argv() swallows exceptions, but not in all cases. if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/95058/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95058%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95058%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/95058/files
Reloadhttps://github.com/python/cpython/pull/95058/files
Reloadhttps://github.com/python/cpython/pull/95058/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/95058/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/95058/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:syslog-openloghttps://github.com/serhiy-storchaka/cpython/tree/syslog-openlog
Conversation 3 https://github.com/python/cpython/pull/95058
Commits 3 https://github.com/python/cpython/pull/95058/commits
Checks 0 https://github.com/python/cpython/pull/95058/checks
Files changed https://github.com/python/cpython/pull/95058/files
Please reload this pagehttps://github.com/python/cpython/pull/95058/files
gh-95041: Fix several minor issues in syslog.openlog() https://github.com/python/cpython/pull/95058/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/95058/files
c317048 gh-95041: Fix several minor issues in syslog.openlog() serhiy-storchaka Jul 20, 2022 https://github.com/python/cpython/pull/95058/commits/c317048f3afed6c0d4a2b30d7f41bb56c67a1289
f067dcd Merge branch 'main' into syslog-openlog serhiy-storchaka Jul 25, 2022 https://github.com/python/cpython/pull/95058/commits/f067dcd5b44f41259fc12b2cbc7c077b6d25c069
7e5a375 Fix the remaining issue: serhiy-storchaka Jul 25, 2022 https://github.com/python/cpython/pull/95058/commits/7e5a375dc41fae630aaf5be08495feb21a11d265
Clear filters https://github.com/python/cpython/pull/95058/files
Please reload this pagehttps://github.com/python/cpython/pull/95058/files
Please reload this pagehttps://github.com/python/cpython/pull/95058/files
Modules/syslogmodule.chttps://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
View file https://github.com/serhiy-storchaka/cpython/blob/7e5a375dc41fae630aaf5be08495feb21a11d265/Modules/syslogmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/95058/{{ revealButtonHref }}
https://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com/python/cpython/pull/95058/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.