| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ce6e1437-99f7-7ad9-2f36-f9a7824aed15 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 953E:2ECB0B:794F71:AEF9D7:696A0C67 |
| html-safe-nonce | 1f6d1257a8826bfd9d52d4b642367b0cddfc9cfd5cd1aab4682ac303a6ee8126 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTNFOjJFQ0IwQjo3OTRGNzE6QUVGOUQ3OjY5NkEwQzY3IiwidmlzaXRvcl9pZCI6Ijc0MjIzOTgwMDY5NDMxNTczNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cbbead57d6c6aaddb5dc023b6e3ec1ce40f775acc011c03381a2ce8d833a4487 |
| hovercard-subject-tag | pull_request:1001006247 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/95012/files |
| twitter:image | https://avatars.githubusercontent.com/u/2150438?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2150438?s=400&v=4 |
| og:image:alt | This improves code readability and performance by delegating all of the argument parsing logic to Clinic.
Fixes #95011
Issue: gh-95011 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/95012/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95012%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F95012%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/95012/files |
| Reload | https://github.com/python/cpython/pull/95012/files |
| Reload | https://github.com/python/cpython/pull/95012/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:main | https://github.com/python/cpython/tree/main |
| noamcohen97:clinic-syslog | https://github.com/noamcohen97/cpython/tree/clinic-syslog |
|
Conversation
41
| https://github.com/python/cpython/pull/95012 |
|
Commits
22
| https://github.com/python/cpython/pull/95012/commits |
|
Checks
0
| https://github.com/python/cpython/pull/95012/checks |
|
Files changed
| https://github.com/python/cpython/pull/95012/files |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
|
gh-95011: Migrate syslog module to Argument Clinic
| https://github.com/python/cpython/pull/95012/files#top |
|
Show all changes
22 commits
| https://github.com/python/cpython/pull/95012/files |
|
6e2cc36
Migrated syslog module to Argument Clinic
noamcohen97 Jul 19, 2022
| https://github.com/python/cpython/pull/95012/commits/6e2cc369593a33f65f8db51876f38424637c7ef5 |
|
565d4b9
reformat syslog functions doc
noamcohen97 Jul 20, 2022
| https://github.com/python/cpython/pull/95012/commits/565d4b94df0de3451dd903c332c13d8747658137 |
|
8626c65
change syslog audit args formatting
noamcohen97 Jul 20, 2022
| https://github.com/python/cpython/pull/95012/commits/8626c65b6e73ca12ae8eeed08f4f29d8e0e31824 |
|
0585b4d
Merge branch 'main' into clinic-syslog
Jul 25, 2022
| https://github.com/python/cpython/pull/95012/commits/0585b4dd00fc262f29bc7cb764a088fbc8969da3 |
|
a2844f0
Update Modules/syslogmodule.c
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/a2844f05df53b734e8e5905b1cfbd80ebcdfa6f9 |
|
9b853db
Update Modules/syslogmodule.c
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/9b853db597f69cff988dc2fde212db4e2d67f199 |
|
30db659
syslog: better test coverage
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/30db6590c2e75cf8a141cda37a8f363b71d2e1f1 |
|
dde4e7c
syslog: fix ref leak
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/dde4e7cdffba6aabeb5582b01ba9b1d5240197d3 |
|
a90f93d
fix whitespace issues
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/a90f93df0ddbed7fb3dce823c23eb9ee7a515a7b |
|
54d4f04
Merge remote-tracking branch 'upstream/main' into clinic-syslog
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/54d4f045160b73155d945dfaa3b1e4f8e20d73a9 |
|
1aa615d
Merge branch 'main' into clinic-syslog
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/1aa615dcf00b8a5585a369b4a33d184e27009788 |
|
895a492
use `support.import_helper.import_module`
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/895a492c77aaf5cb6f006b41a14547e200bf9e5a |
|
3d29577
syslog: pep 7
noamcohen97 Jul 26, 2022
| https://github.com/python/cpython/pull/95012/commits/3d2957708c1f509abc1bb79ac9ee609d3e875a6c |
|
29680c9
use the str converter
noamcohen97 Jul 27, 2022
| https://github.com/python/cpython/pull/95012/commits/29680c9dc6a0b034ef642a86d8c0ddfe0db93c68 |
|
149e646
Merge remote-tracking branch 'upstream/main' into clinic-syslog
noamcohen97 Aug 17, 2022
| https://github.com/python/cpython/pull/95012/commits/149e646ea2fc47304710afcb39664093ec94bb25 |
|
430d12c
regen clinic
noamcohen97 Aug 17, 2022
| https://github.com/python/cpython/pull/95012/commits/430d12c2375494f69a2e7380e1b4499a23bef028 |
|
fd6e589
regen global strings
noamcohen97 Aug 17, 2022
| https://github.com/python/cpython/pull/95012/commits/fd6e5890ad1bc154ea14dc8301bd5669cbfccc41 |
|
0e0d9c6
Merge branch 'main' into clinic-syslog
noamcohen97 Sep 7, 2022
| https://github.com/python/cpython/pull/95012/commits/0e0d9c69a62e06d302d26b7edc92d016d3e931cb |
|
f28b332
Merge remote-tracking branch 'upstream/main' into clinic-syslog
noamcohen97 Oct 7, 2022
| https://github.com/python/cpython/pull/95012/commits/f28b3326d99b580a1bed0711c6e5b70422e6a871 |
|
7a812bc
Merge branch 'main' into clinic-syslog
noamcohen97 Oct 7, 2022
| https://github.com/python/cpython/pull/95012/commits/7a812bc61b07b19d474ba4414c4ba4de320d900b |
|
8903e8b
remove backported tests
noamcohen97 Oct 8, 2022
| https://github.com/python/cpython/pull/95012/commits/8903e8bc61f42547d7664506649c0df583bc1338 |
|
e09825c
Delete 2022-07-19-16-32-52.gh-issue-95011.P5t6l9.rst
serhiy-storchaka Oct 8, 2022
| https://github.com/python/cpython/pull/95012/commits/e09825c4f2a5655dd3321995f1d3a67bc23e7cc6 |
|
Clear filters
| https://github.com/python/cpython/pull/95012/files |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
|
pycore_global_strings.h
| https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
|
pycore_runtime_init_generated.h
| https://github.com/python/cpython/pull/95012/files#diff-69a1fc720f0b1e9005cf7717dd81c823399da81dd2f6480664b51238c1ef93f0 |
|
syslogmodule.c.h
| https://github.com/python/cpython/pull/95012/files#diff-02551f8255a08d1a800ca29005dd4675dc22269e0ac7c2f396d51cc864791b5e |
|
syslogmodule.c
| https://github.com/python/cpython/pull/95012/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810 |
| Include/internal/pycore_global_strings.h | https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
|
View file
| https://github.com/noamcohen97/cpython/blob/e09825c4f2a5655dd3321995f1d3a67bc23e7cc6/Include/internal/pycore_global_strings.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/95012/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
|
| https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
|
| https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
|
| https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
|
| https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
|
| https://github.com/python/cpython/pull/95012/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf |
| Include/internal/pycore_runtime_init_generated.h | https://github.com/python/cpython/pull/95012/files#diff-69a1fc720f0b1e9005cf7717dd81c823399da81dd2f6480664b51238c1ef93f0 |
|
View file
| https://github.com/noamcohen97/cpython/blob/e09825c4f2a5655dd3321995f1d3a67bc23e7cc6/Include/internal/pycore_runtime_init_generated.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
| Modules/clinic/syslogmodule.c.h | https://github.com/python/cpython/pull/95012/files#diff-02551f8255a08d1a800ca29005dd4675dc22269e0ac7c2f396d51cc864791b5e |
|
View file
| https://github.com/noamcohen97/cpython/blob/e09825c4f2a5655dd3321995f1d3a67bc23e7cc6/Modules/clinic/syslogmodule.c.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
| Please reload this page | https://github.com/python/cpython/pull/95012/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |