René's URL Explorer Experiment


Title: gh-72889: remove redundant `mock.Mock()._is_coroutine = False` workarounds by graingert · Pull Request #94926 · python/cpython · GitHub

Open Graph Title: gh-72889: remove redundant `mock.Mock()._is_coroutine = False` workarounds by graingert · Pull Request #94926 · python/cpython

X Title: gh-72889: remove redundant `mock.Mock()._is_coroutine = False` workarounds by graingert · Pull Request #94926 · python/cpython

Description: these work-arounds were made redundant by python/asyncio#459 Issue: Fix asyncio.iscoroutinefunction to handle Mock objects #72889

Open Graph Description: these work-arounds were made redundant by python/asyncio#459 Issue: Fix asyncio.iscoroutinefunction to handle Mock objects #72889

X Description: these work-arounds were made redundant by python/asyncio#459 Issue: Fix asyncio.iscoroutinefunction to handle Mock objects #72889

Opengraph URL: https://github.com/python/cpython/pull/94926

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:32622d28-d683-22d5-6c60-30c15f76bd06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0B2:1CC7E0:40CF7:59137:69696192
html-safe-nonce0403788235a221cdc6176a5bc19def68414b84c0484055ed3f88effb6f30e687
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEIyOjFDQzdFMDo0MENGNzo1OTEzNzo2OTY5NjE5MiIsInZpc2l0b3JfaWQiOiI4NDI5ODYzOTgwMTQ1MTQwMTE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2bba4a2a9710cb05328b7e97957c9f56fa906b5a102d445789a1a88a0a707a10
hovercard-subject-tagpull_request:998648897
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/94926/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6dda1624b0e86ff5b460cf10356afa4d6bc0a333b17e344e77c83b1eaa059101/python/cpython/pull/94926
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6dda1624b0e86ff5b460cf10356afa4d6bc0a333b17e344e77c83b1eaa059101/python/cpython/pull/94926
og:image:altthese work-arounds were made redundant by python/asyncio#459 Issue: Fix asyncio.iscoroutinefunction to handle Mock objects #72889
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegraingert
hostnamegithub.com
expected-hostnamegithub.com
None48487c1ad776a7975b7132d95f4240ff3ae37cd5b8e3cb597102a4edb76738f1
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release669463fcc54773a88c1f5a44eef6b99a5504b9c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/94926#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94926
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94926
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/94926
Reloadhttps://github.com/python/cpython/pull/94926
Reloadhttps://github.com/python/cpython/pull/94926
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/94926
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/94926
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/94926#issue-comment-box
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
graingert:remove-redudant-mock-is-coroutine-workaroundshttps://github.com/graingert/cpython/tree/remove-redudant-mock-is-coroutine-workarounds
gh-72889: remove redundant mock.Mock()._is_coroutine = False workarounds https://github.com/python/cpython/pull/94926#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
graingert:remove-redudant-mock-is-coroutine-workaroundshttps://github.com/graingert/cpython/tree/remove-redudant-mock-is-coroutine-workarounds
Conversation 5 https://github.com/python/cpython/pull/94926
Commits 2 https://github.com/python/cpython/pull/94926/commits
Checks 0 https://github.com/python/cpython/pull/94926/checks
Files changed https://github.com/python/cpython/pull/94926/files
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/graingert
graingerthttps://github.com/graingert
Jul 17, 2022https://github.com/python/cpython/pull/94926#issue-1307104764
Please reload this pagehttps://github.com/python/cpython/pull/94926
python/asyncio#459https://github.com/python/asyncio/pull/459
Fix asyncio.iscoroutinefunction to handle Mock objects #72889https://github.com/python/cpython/issues/72889
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.com/graingert
remove redundant mock.Mock()._is_coroutine = False workaroundshttps://github.com/python/cpython/pull/94926/commits/bfafdb52049749f023ec8df8216f6ad66252862a
bfafdb5https://github.com/python/cpython/pull/94926/commits/bfafdb52049749f023ec8df8216f6ad66252862a
https://github.com/graingert
graingerthttps://github.com/graingert
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/ec4745b5f2c2a460f12c97243c5b7d875f24b0c8/.github/CODEOWNERS#L8
July 17, 2022 13:56https://github.com/python/cpython/pull/94926#event-7007493027
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Jul 17, 2022https://github.com/python/cpython/pull/94926#event-7007493101
https://github.com/graingert
graingerthttps://github.com/graingert
Jul 17, 2022 https://github.com/python/cpython/pull/94926#pullrequestreview-1041132200
View reviewed changes https://github.com/python/cpython/pull/94926/files/bfafdb52049749f023ec8df8216f6ad66252862a
Lib/test/test_asyncio/test_base_events.pyhttps://github.com/python/cpython/pull/94926/files/bfafdb52049749f023ec8df8216f6ad66252862a#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
graingerthttps://github.com/graingert
Jul 17, 2022https://github.com/python/cpython/pull/94926#discussion_r922839081
Please reload this pagehttps://github.com/python/cpython/pull/94926
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cpython/Lib/asyncio/coroutines.pyhttps://github.com/python/cpython/blob/2f841442354f41f2490cef76e9ba24bfef9dfbea/Lib/asyncio/coroutines.py#L245-L248
2f84144https://github.com/python/cpython/commit/2f841442354f41f2490cef76e9ba24bfef9dfbea
cpython/Lib/asyncio/coroutines.pyhttps://github.com/python/cpython/blob/ec4745b5f2c2a460f12c97243c5b7d875f24b0c8/Lib/asyncio/coroutines.py#L16-L23
ec4745bhttps://github.com/python/cpython/commit/ec4745b5f2c2a460f12c97243c5b7d875f24b0c8
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.com/graingert
graingerthttps://github.com/graingert
Jul 17, 2022https://github.com/python/cpython/pull/94926#issuecomment-1186529004
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.com/graingert
Merge branch 'main' into remove-redudant-mock-is-coroutine-workaroundshttps://github.com/python/cpython/pull/94926/commits/d794dfd35c1e6b98290ddcd4095cf9f3383c4a20
d794dfdhttps://github.com/python/cpython/pull/94926/commits/d794dfd35c1e6b98290ddcd4095cf9f3383c4a20
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jul 17, 2022https://github.com/python/cpython/pull/94926#event-7007744121
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jul 17, 2022 https://github.com/python/cpython/pull/94926#pullrequestreview-1041164022
View reviewed changes https://github.com/python/cpython/pull/94926/files/d794dfd35c1e6b98290ddcd4095cf9f3383c4a20
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/94926#pullrequestreview-1041164022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 17, 2022https://github.com/python/cpython/pull/94926#event-7007745645
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
07aeb74https://github.com/python/cpython/commit/07aeb7405ea42729b95ecae225f1d96a4aea5121
Jul 17, 2022https://github.com/python/cpython/pull/94926#event-7007746171
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jul 17, 2022https://github.com/python/cpython/pull/94926#issuecomment-1186575972
@graingerthttps://github.com/graingert
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 17, 2022https://github.com/python/cpython/pull/94926#event-7007746222
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 17, 2022https://github.com/python/cpython/pull/94926#issuecomment-1186575996
GH-94934https://github.com/python/cpython/pull/94934
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jul 17, 2022https://github.com/python/cpython/pull/94926#event-7007746349
miss-islingtonhttps://github.com/miss-islington
Jul 17, 2022 https://github.com/python/cpython/pull/94926#ref-commit-ed2722b
https://github.com/graingert
https://github.com/miss-islington
pythongh-72889https://github.com/python/cpython/issues/72889
: Remove redundant mock.Mock()._is_coroutine = False wo…https://github.com/miss-islington/cpython/commit/ed2722b0a3b1ab6a787980db48725599942966ce
ed2722bhttps://github.com/miss-islington/cpython/commit/ed2722b0a3b1ab6a787980db48725599942966ce
pythonGH-94926https://github.com/python/cpython/pull/94926
07aeb74https://github.com/miss-islington/cpython/commit/07aeb7405ea42729b95ecae225f1d96a4aea5121
https://github.com/graingert
graingerthttps://github.com/graingert
July 17, 2022 17:23https://github.com/python/cpython/pull/94926#event-7007747091
miss-islingtonhttps://github.com/miss-islington
Jul 17, 2022 https://github.com/python/cpython/pull/94926#ref-commit-8d0249e
https://github.com/miss-islington
https://github.com/graingert
gh-72889https://github.com/python/cpython/issues/72889
: Remove redundant mock.Mock()._is_coroutine = False workarou…https://github.com/python/cpython/commit/8d0249e3458109f3d3b5d0e2b87cbf9d58dce072
8d0249ehttps://github.com/python/cpython/commit/8d0249e3458109f3d3b5d0e2b87cbf9d58dce072
GH-94926https://github.com/python/cpython/pull/94926
07aeb74https://github.com/python/cpython/commit/07aeb7405ea42729b95ecae225f1d96a4aea5121
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Aug 12, 2022 https://github.com/python/cpython/pull/94926#ref-issue-1303833875
Metabug: Improving C-level coverage #94808 https://github.com/python/cpython/issues/94808
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94926
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/94926/files/d794dfd35c1e6b98290ddcd4095cf9f3383c4a20
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/94926
https://github.com/graingert
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.