René's URL Explorer Experiment


Title: GH-94694: Fix column offsets for multi-line method lookups by brandtbucher · Pull Request #94697 · python/cpython · GitHub

Open Graph Title: GH-94694: Fix column offsets for multi-line method lookups by brandtbucher · Pull Request #94697 · python/cpython

X Title: GH-94694: Fix column offsets for multi-line method lookups by brandtbucher · Pull Request #94697 · python/cpython

Description: If we're given an AST that doesn't make much sense here, just wipe out the column info instead of crashing later. Also, don't try to include the dot in the column span. Issue: gh-94694

Open Graph Description: If we're given an AST that doesn't make much sense here, just wipe out the column info instead of crashing later. Also, don't try to include the dot in the column span. Issue: gh-94694

X Description: If we're given an AST that doesn't make much sense here, just wipe out the column info instead of crashing later. Also, don't try to include the dot in the column span. Issue: gh-94694

Opengraph URL: https://github.com/python/cpython/pull/94697

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:32e53430-ecfd-bae8-3123-ed67d2ecf02b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1D6:4CEB4:1022186:1609569:6969F345
html-safe-nonce6e5830348071dbb09941e93cb644526151ebcd04c9efcf934b26c41153de0cf1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUQ2OjRDRUI0OjEwMjIxODY6MTYwOTU2OTo2OTY5RjM0NSIsInZpc2l0b3JfaWQiOiI4NjMxNjcyNjM5Mjc0NDgwNDUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf661641fefc100f82540a36b66eac39aaca26e9adb70b7c1ae9fe5186b260139
hovercard-subject-tagpull_request:992103695
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/94697/files
twitter:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
og:image:altIf we're given an AST that doesn't make much sense here, just wipe out the column info instead of crashing later. Also, don't try to include the dot in the column span. Issue: gh-94694
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/94697/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94697%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94697%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/94697/files
Reloadhttps://github.com/python/cpython/pull/94697/files
Reloadhttps://github.com/python/cpython/pull/94697/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/94697/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/94697/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:fix-method-colshttps://github.com/brandtbucher/cpython/tree/fix-method-cols
Conversation 18 https://github.com/python/cpython/pull/94697
Commits 6 https://github.com/python/cpython/pull/94697/commits
Checks 0 https://github.com/python/cpython/pull/94697/checks
Files changed https://github.com/python/cpython/pull/94697/files
Please reload this pagehttps://github.com/python/cpython/pull/94697/files
GH-94694: Fix column offsets for multi-line method lookups https://github.com/python/cpython/pull/94697/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/94697/files
937a3db Add failing regression test brandtbucher Jul 8, 2022 https://github.com/python/cpython/pull/94697/commits/937a3dbefcf549b571e45e4a32081437ad55b49f
dd5a391 Fix invalid column math brandtbucher Jul 8, 2022 https://github.com/python/cpython/pull/94697/commits/dd5a39195c2159afa4868ddbee06ed4e482b44a6
ffd3413 Add additional tests for column locations brandtbucher Jul 8, 2022 https://github.com/python/cpython/pull/94697/commits/ffd3413fe84c2900095c7eae366d8c7da2edffe2
53ba444 blurb add brandtbucher Jul 8, 2022 https://github.com/python/cpython/pull/94697/commits/53ba4445a038e3430b1f6609c167f973c943699d
33dc4d8 Update comment brandtbucher Jul 8, 2022 https://github.com/python/cpython/pull/94697/commits/33dc4d8a911512fa310dc262b1c641f26c89cc9d
13c07ff Feedback from code review brandtbucher Jul 9, 2022 https://github.com/python/cpython/pull/94697/commits/13c07ff7f39a51803872a3d07eacc473bce68f78
Clear filters https://github.com/python/cpython/pull/94697/files
Please reload this pagehttps://github.com/python/cpython/pull/94697/files
Please reload this pagehttps://github.com/python/cpython/pull/94697/files
test_compile.py https://github.com/python/cpython/pull/94697/files#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
test_traceback.py https://github.com/python/cpython/pull/94697/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
2022-07-08-16-44-11.gh-issue-94694.VkL2CM.rst https://github.com/python/cpython/pull/94697/files#diff-ab1b29379868684c29cec64a11aa86e3497bc20564b3f7f8f1708ef2d97ebc3a
compile.c https://github.com/python/cpython/pull/94697/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
Lib/test/test_compile.pyhttps://github.com/python/cpython/pull/94697/files#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
View file https://github.com/brandtbucher/cpython/blob/13c07ff7f39a51803872a3d07eacc473bce68f78/Lib/test/test_compile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94697/{{ revealButtonHref }}
https://github.com/python/cpython/pull/94697/files#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
https://github.com/python/cpython/pull/94697/files#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
Lib/test/test_traceback.pyhttps://github.com/python/cpython/pull/94697/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
View file https://github.com/brandtbucher/cpython/blob/13c07ff7f39a51803872a3d07eacc473bce68f78/Lib/test/test_traceback.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94697/{{ revealButtonHref }}
https://github.com/python/cpython/pull/94697/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
https://github.com/python/cpython/pull/94697/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
Misc/NEWS.d/next/Core and Builtins/2022-07-08-16-44-11.gh-issue-94694.VkL2CM.rsthttps://github.com/python/cpython/pull/94697/files#diff-ab1b29379868684c29cec64a11aa86e3497bc20564b3f7f8f1708ef2d97ebc3a
View file https://github.com/brandtbucher/cpython/blob/13c07ff7f39a51803872a3d07eacc473bce68f78/Misc/NEWS.d/next/Core%20and%20Builtins/2022-07-08-16-44-11.gh-issue-94694.VkL2CM.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94697/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L228
Python/compile.chttps://github.com/python/cpython/pull/94697/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
View file https://github.com/brandtbucher/cpython/blob/13c07ff7f39a51803872a3d07eacc473bce68f78/Python/compile.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94697/{{ revealButtonHref }}
https://github.com/python/cpython/pull/94697/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
https://github.com/python/cpython/pull/94697/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.