René's URL Explorer Experiment


Title: gh-94518: [_posixsubprocess] Replace variable validity flags with reserved values by arhadthedev · Pull Request #94687 · python/cpython · GitHub

Open Graph Title: gh-94518: [_posixsubprocess] Replace variable validity flags with reserved values by arhadthedev · Pull Request #94687 · python/cpython

X Title: gh-94518: [_posixsubprocess] Replace variable validity flags with reserved values by arhadthedev · Pull Request #94687 · python/cpython

Description: Currently, _posixsubprocess.c uses group and user ids together with flags of whether the corrsponding variables were initialized. However such an implicit "either initialized or look somewhere else" confuses both a reader (another mental connection to constantly track between functions) and a compiler (warnings on potentially uninitialized variables). Instead, we can utilize a special group/user id as a flag value defined by POSIX but uses nowhere else. Namely: gid: call_setgid = False → gid = -1 uid: call_setuid = False → uid = -1 groups: call_setgroups = False → groups = NULL (obtained with (groups_list != Py_None) ? groups : NULL) This PR is required for gh-94519. PS.: @tiran I applied your suggestion from gh-94519 as this, separate PR to keep that one limited in scope and reviewable. Issue: gh-94518

Open Graph Description: Currently, _posixsubprocess.c uses group and user ids together with flags of whether the corrsponding variables were initialized. However such an implicit "either initialized or look somewhere...

X Description: Currently, _posixsubprocess.c uses group and user ids together with flags of whether the corrsponding variables were initialized. However such an implicit "either initialized or look somew...

Opengraph URL: https://github.com/python/cpython/pull/94687

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:33b1a72f-5570-732b-6dcd-8dddfe96d1c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA91A:1851F5:CADD18:1168EC0:6969EF5A
html-safe-nonce608ca519a4f8a46562733ad111067a1a698ca168d40412b94361fda7eda8e4cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTFBOjE4NTFGNTpDQUREMTg6MTE2OEVDMDo2OTY5RUY1QSIsInZpc2l0b3JfaWQiOiI2NjEyMDA4NDEwNzQxNDMwNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacddc1cc456fa654915bf0290c79b7e97382043e217a9b05a1e42961d2ec9bbd43
hovercard-subject-tagpull_request:991551519
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/94687/files
twitter:imagehttps://avatars.githubusercontent.com/u/4881073?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4881073?s=400&v=4
og:image:altCurrently, _posixsubprocess.c uses group and user ids together with flags of whether the corrsponding variables were initialized. However such an implicit "either initialized or look somewhere...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/94687/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94687%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94687%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/94687/files
Reloadhttps://github.com/python/cpython/pull/94687/files
Reloadhttps://github.com/python/cpython/pull/94687/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/94687/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/94687/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
arhadthedev:posixsubprocess-no-callsetxidhttps://github.com/arhadthedev/cpython/tree/posixsubprocess-no-callsetxid
Conversation 18 https://github.com/python/cpython/pull/94687
Commits 14 https://github.com/python/cpython/pull/94687/commits
Checks 0 https://github.com/python/cpython/pull/94687/checks
Files changed https://github.com/python/cpython/pull/94687/files
Please reload this pagehttps://github.com/python/cpython/pull/94687/files
gh-94518: [_posixsubprocess] Replace variable validity flags with reserved values https://github.com/python/cpython/pull/94687/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/94687/files
1b3250e Replace call_setgid/call_setuid in _posixsubprocess with gid/uid==-1 arhadthedev Jul 8, 2022 https://github.com/python/cpython/pull/94687/commits/1b3250e96bd3398f6a79ed85258250fa375f916c
c292331 Merge branch 'main' into posixsubprocess-no-callsetxid arhadthedev Jul 22, 2022 https://github.com/python/cpython/pull/94687/commits/c292331fddd5d3c9460371738a323c3bf9b5ac7f
7d431a3 Add a NEWS entry arhadthedev Jul 22, 2022 https://github.com/python/cpython/pull/94687/commits/7d431a39feb6617a178e59d3344b0829ef35b457
06f2a01 Address Gregory's review in gh-94519 arhadthedev Jul 26, 2022 https://github.com/python/cpython/pull/94687/commits/06f2a01637465f93331c00db32a157a078876e89
aaec16e Use negative groups_size for "don't call setgroups" arhadthedev Jul 27, 2022 https://github.com/python/cpython/pull/94687/commits/aaec16efae3da5bf3d3e78eb7355d34f39e86fb8
c9bf4f6 Check num_groups for emptiness, not groups_list arhadthedev Jul 27, 2022 https://github.com/python/cpython/pull/94687/commits/c9bf4f64f74a7ff266b5db8df7d899fba3ba87e7
069d769 Restore assertions in do_fork_exec() arhadthedev Jul 27, 2022 https://github.com/python/cpython/pull/94687/commits/069d7694f55177dc76bf5de8d88ecd5b62cf9b7d
6a236e5 Tighten scope of relevant short lived variables arhadthedev Jul 27, 2022 https://github.com/python/cpython/pull/94687/commits/6a236e52fdbecb011d00131210743c617262d5c4
8c06be1 Fix `PermissionError: [Errno 1] Operation not permitted` exception arhadthedev Jul 27, 2022 https://github.com/python/cpython/pull/94687/commits/8c06be1ef1dbb0b9fea70b7e9376b63c855a9525
3ccdb78 Merge branch 'main' into posixsubprocess-no-callsetxid arhadthedev Oct 6, 2022 https://github.com/python/cpython/pull/94687/commits/3ccdb78dc8c37beaa376811f545db83609f8038e
d3c0e6c Merge branch 'main' into posixsubprocess-no-callsetxid arhadthedev Oct 29, 2022 https://github.com/python/cpython/pull/94687/commits/d3c0e6c194e887386507e6963a36df6f6da1974f
cfdf639 Merge branch 'main' into posixsubprocess-no-callsetxid arhadthedev Nov 14, 2022 https://github.com/python/cpython/pull/94687/commits/cfdf639bdee1e86683c744ab922784c0c39a81c5
0e997c0 Merge branch 'main' into posixsubprocess-no-callsetxid arhadthedev Nov 29, 2022 https://github.com/python/cpython/pull/94687/commits/0e997c06d0a56cedd49b0c1356471ee5a5c0551b
66c836b Merge branch 'main' into posixsubprocess-no-callsetxid arhadthedev Jan 14, 2023 https://github.com/python/cpython/pull/94687/commits/66c836b6ce7e6271113758af94be71eae05fd386
Clear filters https://github.com/python/cpython/pull/94687/files
Please reload this pagehttps://github.com/python/cpython/pull/94687/files
Please reload this pagehttps://github.com/python/cpython/pull/94687/files
2022-07-22-13-38-37.gh-issue-94518._ZP0cz.rst https://github.com/python/cpython/pull/94687/files#diff-09ffdd08a351d4cd7ed97abe19481091a56f201cacc4bcd20226dc5de061d40f
_posixsubprocess.c https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
Misc/NEWS.d/next/Library/2022-07-22-13-38-37.gh-issue-94518._ZP0cz.rsthttps://github.com/python/cpython/pull/94687/files#diff-09ffdd08a351d4cd7ed97abe19481091a56f201cacc4bcd20226dc5de061d40f
View file https://github.com/arhadthedev/cpython/blob/66c836b6ce7e6271113758af94be71eae05fd386/Misc/NEWS.d/next/Library/2022-07-22-13-38-37.gh-issue-94518._ZP0cz.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94687/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L585
Modules/_posixsubprocess.chttps://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
View file https://github.com/arhadthedev/cpython/blob/66c836b6ce7e6271113758af94be71eae05fd386/Modules/_posixsubprocess.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94687/{{ revealButtonHref }}
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
Please reload this pagehttps://github.com/python/cpython/pull/94687/files
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/94687/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.