| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:44512261-a317-f23e-596f-a02298a1ace8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDEA:2E86DB:A74BA6:EE3593:69690294 |
| html-safe-nonce | 7c5cd5621e6c4f3946ebe5330f4205b05e7e5857d8d1be70cf75564f8e67a3cc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREVBOjJFODZEQjpBNzRCQTY6RUUzNTkzOjY5NjkwMjk0IiwidmlzaXRvcl9pZCI6IjkxNDE2MzM0NjM3NDYxMDE5MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d23d9b251b7b417580a1a6e2eaf5f5ac908b5cc195b510c5a727dbab3aa77455 |
| hovercard-subject-tag | pull_request:988760968 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/94604/files |
| twitter:image | https://avatars.githubusercontent.com/u/883786?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/883786?s=400&v=4 |
| og:image:alt | This PR optmizes list.pop
Benchmark results
x=[1,2]; x.pop(0): Mean +- std dev: [m2] 81.8 ns +- 2.5 ns -> [pr_special] 68.9 ns +- 2.0 ns: 1.19x faster
x=[1,2]; x.pop(1): Mean +- std dev: [m2] 65... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e6156bd4ef9f2dc8dadf4c49a8f7ed8532186388cef72eda3ccb9f0ab3b8cfca |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fd1938215b152e2c6a29cf56fec07fd9f91f1203 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/94604/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94604%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94604%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/94604/files |
| Reload | https://github.com/python/cpython/pull/94604/files |
| Reload | https://github.com/python/cpython/pull/94604/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/94604/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/94604/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| corona10 | https://github.com/corona10 |
| python:main | https://github.com/python/cpython/tree/main |
| eendebakpt:performance/list_pop | https://github.com/eendebakpt/cpython/tree/performance/list_pop |
|
Conversation
20
| https://github.com/python/cpython/pull/94604 |
|
Commits
17
| https://github.com/python/cpython/pull/94604/commits |
|
Checks
0
| https://github.com/python/cpython/pull/94604/checks |
|
Files changed
| https://github.com/python/cpython/pull/94604/files |
| Please reload this page | https://github.com/python/cpython/pull/94604/files |
|
gh-94603: micro optimize list.pop
| https://github.com/python/cpython/pull/94604/files#top |
|
Show all changes
17 commits
| https://github.com/python/cpython/pull/94604/files |
|
79ac0ff
optimize list.pop
eendebakpt Jul 6, 2022
| https://github.com/python/cpython/pull/94604/commits/79ac0ff8ec6cbf29e4070dba797165b44b806654 |
|
4cf3c19
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 6, 2022
| https://github.com/python/cpython/pull/94604/commits/4cf3c199dbeb556843a6e11ccb392802babaa756 |
|
4db7ec5
fix news item
eendebakpt Jul 6, 2022
| https://github.com/python/cpython/pull/94604/commits/4db7ec56a2ac9c5c0479a56449df3eb36882259c |
|
1512885
Update Objects/listobject.c
eendebakpt Jul 8, 2022
| https://github.com/python/cpython/pull/94604/commits/1512885e242707ba2aa84346e410316d61bc5730 |
|
58e38d6
Update Objects/listobject.c
eendebakpt Jul 10, 2022
| https://github.com/python/cpython/pull/94604/commits/58e38d6ec7e07406cb65545e72a2d2ad42442950 |
|
e55907c
Merge branch 'main' into performance/list_pop
eendebakpt Jul 26, 2022
| https://github.com/python/cpython/pull/94604/commits/e55907c10947afc351999878b57612a4cd8406d4 |
|
a97f93e
Merge branch 'main' into performance/list_pop
eendebakpt Jul 28, 2022
| https://github.com/python/cpython/pull/94604/commits/a97f93e3388fb76b84018bf4d25263ded25c9160 |
|
a711050
Merge branch 'main' into performance/list_pop
eendebakpt Aug 10, 2022
| https://github.com/python/cpython/pull/94604/commits/a711050f3a6d7aaebd3fce2165cff847ff126ce5 |
|
b1ebb5c
Merge branch 'main' into performance/list_pop
eendebakpt Aug 22, 2022
| https://github.com/python/cpython/pull/94604/commits/b1ebb5c243ebb334ca5e5f9e5ae54a169855b0d7 |
|
12411a9
Merge branch 'main' into performance/list_pop
eendebakpt Sep 19, 2022
| https://github.com/python/cpython/pull/94604/commits/12411a99d01de5b6d7f45048b642f9d61a650d08 |
|
8940af7
Merge branch 'main' into performance/list_pop
eendebakpt Oct 19, 2022
| https://github.com/python/cpython/pull/94604/commits/8940af77b3559e9f07ef60010803dd550699fb45 |
|
9635cfe
Merge branch 'main' into performance/list_pop
eendebakpt Nov 9, 2022
| https://github.com/python/cpython/pull/94604/commits/9635cfe89ca404ef6ca1d33bc2ad114bae28d632 |
|
91afa40
Merge branch 'main' into performance/list_pop
eendebakpt Dec 22, 2022
| https://github.com/python/cpython/pull/94604/commits/91afa40f9923e36b6447b70fde25354455d3e964 |
|
44a4efe
Apply suggestions from code review
eendebakpt Dec 26, 2022
| https://github.com/python/cpython/pull/94604/commits/44a4efe94f07040f73b0d3d0a84942001c8d5733 |
|
7c6c9fa
rename to size_after_pop
eendebakpt Dec 26, 2022
| https://github.com/python/cpython/pull/94604/commits/7c6c9fa0f441e65aad6037fc7705514ffaec0940 |
|
7c1a835
make variable const
eendebakpt Dec 26, 2022
| https://github.com/python/cpython/pull/94604/commits/7c1a8355d7ca723039d05546d171a2359644ce1c |
|
23eb3aa
Update Objects/listobject.c
corona10 Dec 27, 2022
| https://github.com/python/cpython/pull/94604/commits/23eb3aa79c6e0fe9d0bcf4a969adb975f6d40bae |
|
Clear filters
| https://github.com/python/cpython/pull/94604/files |
| Please reload this page | https://github.com/python/cpython/pull/94604/files |
| Please reload this page | https://github.com/python/cpython/pull/94604/files |
|
2022-07-06-18-44-00.gh-issue-94603.Q_03xV.rst
| https://github.com/python/cpython/pull/94604/files#diff-25149925dd7ff66b9bfc4329d0eb5e25886c2a2e96d16b4904c74291c2bf021a |
|
listobject.c
| https://github.com/python/cpython/pull/94604/files#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81 |
| Misc/NEWS.d/next/Core and Builtins/2022-07-06-18-44-00.gh-issue-94603.Q_03xV.rst | https://github.com/python/cpython/pull/94604/files#diff-25149925dd7ff66b9bfc4329d0eb5e25886c2a2e96d16b4904c74291c2bf021a |
|
View file
| https://github.com/eendebakpt/cpython/blob/23eb3aa79c6e0fe9d0bcf4a969adb975f6d40bae/Misc/NEWS.d/next/Core%20and%20Builtins/2022-07-06-18-44-00.gh-issue-94603.Q_03xV.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/94604/{{ revealButtonHref }} |
| Objects/listobject.c | https://github.com/python/cpython/pull/94604/files#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81 |
|
View file
| https://github.com/eendebakpt/cpython/blob/23eb3aa79c6e0fe9d0bcf4a969adb975f6d40bae/Objects/listobject.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/94604/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/94604/files#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81 |
|
| https://github.com/python/cpython/pull/94604/files#diff-67a42c5c0990c7aceea040ffc07905299aab97d64dc49adb256f85340b2c7e81 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |